Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0014010Openbravo ERP00. Application dictionarypublic2010-07-20 12:222010-08-14 00:00
rafaroda 
iperdomo 
normalmajoralways
closedfixed 
20Community Appliance
2.50 
2.50MP21 
Core
No
0014010: Switching from edit to grid view using keyboard shortcut does not work
Switching from edit to grid view using keyboard shortcut Ctrl+G http://wiki.openbravo.com/wiki/ERP/2.50/User_Manual#Keyboard_shortcuts [^]
Tested in Ubuntu 10.04 + Firefox 3.6 + Openbravo ERP 3.0 RC1

1) Log in and select Sales Order tab.
2) Use Ctrl+G to switch from Edit to Grid view and vice-versa

Nothing happens.
No tags attached.
related to defect 0013989 closed alostale The generated HTML code of the refresh button is different when using the new layout 
Issue History
2010-07-20 12:22rafarodaNew Issue
2010-07-20 12:22rafarodaAssigned To => dbaz
2010-07-21 18:23mtaalIssue Monitored: mtaal
2010-08-11 15:26dbazAssigned Todbaz => iperdomo
2010-08-11 15:49iperdomoRelationship addedrelated to 0013989
2010-08-11 17:04iperdomoNote Added: 0029895
2010-08-11 17:31iperdomoStatusnew => scheduled
2010-08-11 17:31iperdomofix_in_branch => pi
2010-08-11 17:31iperdomoProjectModules => Openbravo ERP
2010-08-11 17:32iperdomoCategoryClient Application => 00. Application dictionary
2010-08-11 17:32iperdomoFixed in Version => 2.50MP21
2010-08-11 17:32iperdomofix_in_branchpi =>
2010-08-11 17:34hgbotCheckin
2010-08-11 17:34hgbotNote Added: 0029897
2010-08-11 17:34hgbotStatusscheduled => resolved
2010-08-11 17:34hgbotResolutionopen => fixed
2010-08-11 17:34hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e485d4ccc28711d77ba936d2be21677a24ffbfed [^]
2010-08-12 21:12hudsonbotCheckin
2010-08-12 21:12hudsonbotNote Added: 0029927
2010-08-13 14:37dbazStatusresolved => closed
2010-08-14 00:00anonymoussf_bug_id0 => 3044623

Notes
(0029895)
iperdomo   
2010-08-11 17:04   
The problem is the same as the related issue 0013989 since the HTML generated in the toolbar is different in 2.50 and the new layout.


HTML in 2.50 LeftBar

<a id="buttonEdition" onclick="submitCommandForm('EDIT', true, null, 'Module_Relation.html', '_self', null, false);return false;" href="#" class="Main_LeftTabsBar_ButtonRight">
                  <img border="0" src="../web/images/blank.gif" title="Form View" alt="Form View" class="Main_LeftTabsBar_ButtonRight_Icon Main_LeftTabsBar_ButtonRight_Icon_edition">
</a>

<a id="buttonRelation" onclick="submitCommandForm('RELATION', isUserChanges, null, 'Module_Relation.html', '_self', null, true);return false;" href="#" class="Main_LeftTabsBar_ButtonRight">
                  <img border="0" src="../web/images/blank.gif" title="Grid View" alt="Grid View" class="Main_LeftTabsBar_ButtonRight_Icon Main_LeftTabsBar_ButtonRight_Icon_relation">
                </a>

----

HTML generated in the Toolbar

<a id="linkButtonEdition" onblur="this.hideFocus=false" onclick="return false;" onmouseout="window.status='';return true;" onmouseover="window.status='Form View';return true;" class="Main_ToolBar_Button_Selected" href="#"><img border="0" id="buttonEdition" title="Form View" src="../web/images/blank.gif" class="Main_ToolBar_Button_Icon Main_ToolBar_Button_Icon_Edition"></a>

<a id="linkButtonRelation" onblur="this.hideFocus=false" onclick="submitCommandForm('RELATION', isUserChanges, null, 'Module_Relation.html', '_self', null, true);return false;" onmouseout="window.status='';return true;" onmouseover="window.status='Grid View';return true;" class="Main_ToolBar_Button" href="#"><img border="0" id="buttonRelation" title="Grid View" src="../web/images/blank.gif" class="Main_ToolBar_Button_Icon Main_ToolBar_Button_Icon_Relation"></a>

Proposed solution is to 'hack' the Toolbar and remove the *link* part of the id when is ButtonRelation and ButtonEdition
(0029897)
hgbot   
2010-08-11 17:34   
Repository: erp/devel/pi
Changeset: e485d4ccc28711d77ba936d2be21677a24ffbfed
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Wed Aug 11 17:34:05 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/e485d4ccc28711d77ba936d2be21677a24ffbfed [^]

Fixes issue 14010: Fixes ID generation for new buttons in the toolbar
- The ID of the HTML button tag must match the one in 2.50

---
M src/org/openbravo/erpCommon/utility/ToolBar_Button.java
M src/org/openbravo/erpCommon/utility/ToolBar_Image.java
---
(0029927)
hudsonbot   
2010-08-12 21:12   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/e485d4ccc287 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/dd00ba1c00c6 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18116.obx [^]