Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0013989Openbravo ERPA. Platformpublic2010-07-16 18:542010-08-12 00:00
Reporteriperdomo 
Assigned Toalostale 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS Version2.6.30-gentoo-r5
Product Versionpi 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0013989: The generated HTML code of the refresh button is different when using the new layout
DescriptionWhen using the new layout, the 'classic' refresh button is hidden, and a new refresh button is added to the toolbar. The generated HTML from the classic and new button is different.

In the classic layout the id="buttonRefresh" is assigned to a <A> tag that contains a <IMG> inside. Note: the the link <A> has the javascript onclick handler.

When using the new layout the generated id is in the opposite order, the id="buttonRefresh" is assigned to the <IMG> tag, and the <A> still contains the javascript handler onclick, and this makes the code that this code fails:
getElementById("buttonRefresh").onclick();

Steps To Reproduce* Using the new layout, try to execute in a generated window the following code:

typeof getElementById("buttonRefresh").onclick()

It should return "function"

eg. in classic layout:
>>> typeof appFrame.document.getElementById("buttonRefresh").onclick
"function"


Proposed SolutionAttached you'll find a "partial" solution. Needs to be rechecked and discussed.
Additional Information
TagsNo tags attached.
Relationships
related to defect 0013988 closed gorkaion Transaction.java servlet in this module calls ToolBar.java with wrong parameter... 
related to feature request 0013891 closed dbaz ToolBar and LeftTabsBar classes need to be changed for New Layout 
related to defect 0014010 closed iperdomo Switching from edit to grid view using keyboard shortcut does not work 
Attached Filesdiff Toolbar.diff (1,819) 2010-07-16 18:54
https://issues.openbravo.com/file_download.php?file_id=2775&type=bug
Issue History
Date ModifiedUsernameFieldChange
2010-07-16 18:54iperdomoNew Issue
2010-07-16 18:54iperdomoAssigned To => alostale
2010-07-16 18:54iperdomoFile Added: Toolbar.diff
2010-07-16 18:54iperdomoOBNetwork customer => No
2010-07-16 18:55shuehnerRelationship addedrelated to 0013988
2010-07-16 18:55iperdomoRelationship addedrelated to 0013891
2010-07-19 08:25alostaleStatusnew => scheduled
2010-07-29 10:50hgbotCheckin
2010-07-29 10:50hgbotNote Added: 0029662
2010-07-29 10:50hgbotStatusscheduled => resolved
2010-07-29 10:50hgbotResolutionopen => fixed
2010-07-29 10:50hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/acbf6d8e882270a802380082359732da68987e29 [^]
2010-07-29 22:17hudsonbotCheckin
2010-07-29 22:17hudsonbotNote Added: 0029686
2010-08-11 10:47iperdomoNote Added: 0029883
2010-08-11 10:47iperdomoStatusresolved => closed
2010-08-11 15:49iperdomoRelationship addedrelated to 0014010
2010-08-12 00:00anonymoussf_bug_id0 => 3043343

Notes
(0029662)
hgbot   
2010-07-29 10:50   
Repository: erp/devel/pi
Changeset: acbf6d8e882270a802380082359732da68987e29
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Jul 29 10:50:08 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/acbf6d8e882270a802380082359732da68987e29 [^]

fixed bug 13989: refresh button is different when using the new layout

  Make an special case when generating toolbar for refresh button id, in order
  to use the same id as it was used in the 2.50 layout.

---
M src/org/openbravo/erpCommon/utility/ToolBar_Button.java
M src/org/openbravo/erpCommon/utility/ToolBar_Image.java
---
(0029686)
hudsonbot   
2010-07-29 22:17   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/acbf6d8e8822 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/5b23128e2fc6 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17934.obx [^]
(0029883)
iperdomo   
2010-08-11 10:47   
Tested on pi @ rev a45ffdf7b265