Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0013983Openbravo ERPA. Platformpublic2010-07-16 14:032010-08-18 00:00
Reporternetworkb 
Assigned Toalostale 
PriorityurgentSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version2.50MP19 
Target Version2.50MP21Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0013983: Adding new table (in a module) to a core dataset is not possible without core being in development.
DescriptionThe trigger ad_dataset_table_mod_trg does not check if that module attached to the ad_dataset_table is in development but instead checks if the module attached to the ad_dataset (parent) is in development.

This leads to the problem written in the summary.

If there is not apparent reason for this different then standard behavior this should be modified to allow this usecase.
Steps To ReproduceCreate a new module, mark it as default and as in development
Verify that the core module is NOT marked as in evelopment.
Goto to the 'Client definition' record of the Dataset window
Goto to the 'Table' tab in this window
Click new verify that the module Combobox uses the newly created module
Click save.
See error message stating:
ERROR: Cannot insert/delete objects in a module not in development.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-07-16 14:03shuehnerNew Issue
2010-07-16 14:03shuehnerAssigned To => alostale
2010-07-16 14:03shuehnerOBNetwork customer => No
2010-07-16 14:04shuehnerSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=588#r588
2010-07-19 08:25alostaleStatusnew => scheduled
2010-07-21 13:12networkbOBNetwork customerNo => Yes
2010-07-21 13:12networkbReportershuehner => networkb
2010-07-21 13:12networkbSeverityminor => major
2010-07-21 13:12networkbversionpi => 2.50MP19
2010-07-21 13:12networkbTarget Version => 2.50MP21
2010-07-23 09:56alostaleNote Added: 0029497
2010-07-23 10:52hgbotCheckin
2010-07-23 10:52hgbotNote Added: 0029506
2010-07-23 10:52hgbotStatusscheduled => resolved
2010-07-23 10:52hgbotResolutionopen => fixed
2010-07-23 10:52hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/965b96738de419524210cd0657782df96e3a3bd3 [^]
2010-07-27 15:41hudsonbotCheckin
2010-07-27 15:41hudsonbotNote Added: 0029603
2010-08-17 18:09shuehnerNote Added: 0030083
2010-08-17 18:09shuehnerStatusresolved => closed
2010-08-17 18:24shuehnerNote Added: 0030086
2010-08-18 00:00anonymoussf_bug_id0 => 3047306

Notes
(0029497)
alostale   
2010-07-23 09:56   
This issue was introduced by changeset f35165459454 [1].

It added ad_module_id column to ad_dataset_table and ad_dataset_column tables but it did not modified the triggers to check the correct module for them (previously module for their parent ad_dataset record was correctly checked).

[1] https://code.openbravo.com/erp/devel/pi/rev/f35165459454 [^]
(0029506)
hgbot   
2010-07-23 10:52   
Repository: erp/devel/pi
Changeset: 965b96738de419524210cd0657782df96e3a3bd3
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Jul 23 10:51:43 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/965b96738de419524210cd0657782df96e3a3bd3 [^]

fixed bug 13983: Add new table to core dataset not possible without core in dev

  The module checked to be in development was the one in parent AD_Dataset, not
  the one in the record itself.

  This has been fixed for AD_Dataset_Table and AD_Dataset_Column.

---
M src-db/database/model/triggers/AD_DATASET_COLUMN_MOD_TRG.xml
M src-db/database/model/triggers/AD_DATASET_TABLE_MOD_TRG.xml
---
(0029603)
hudsonbot   
2010-07-27 15:41   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/965b96738de4 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/634cc0909ed2 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17922.obx [^]
(0030083)
shuehner   
2010-08-17 18:09   
Tested on pi_pg, rev: e87917805d68.
Described use-case no works. Technical change did re-add two sorting calls which have been removed by some earlier commit by accident. -> Closing as fixed
(0030086)
shuehner   
2010-08-17 18:24   
Note previous message about closing the issue has wrong text... please ignore

Tested on pi_pg, rev: e87917805d68.
Now adding a table or column (in a module) to a dataset definition of another modue (i.e. core) works fine.