Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0013947Openbravo ERPY. DBSourceManagerpublic2010-07-13 13:012010-07-27 15:41
Reportermarvintm 
Assigned Tomarvintm 
PriorityimmediateSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0013947: update.database.mod doesn't correctly take into account foreign keys for AD tables which are extended by a module
DescriptionIf a module adds columns to an Application Dictionary table, in some cases the foreign keys will not be removed from the AD model, and therefore they will be dropped and created twice.
Steps To ReproduceIn a fresh MP19 install Advanced Payments and Receivables (which will also pull the new UI Selector modules). This will show some warnings related to some foreing keys being dropped and created twice.
Proposed SolutionDBSM needs to be changed to fix this problem.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-07-13 13:01marvintmNew Issue
2010-07-13 13:01marvintmAssigned To => marvintm
2010-07-13 13:05hgbotCheckin
2010-07-13 13:05hgbotNote Added: 0029257
2010-07-13 13:05hgbotStatusnew => resolved
2010-07-13 13:05hgbotResolutionopen => fixed
2010-07-13 13:05hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/c80022d61c9c207ea7bd855722c1abd5cd4d0beb [^]
2010-07-13 13:07hgbotCheckin
2010-07-13 13:07hgbotNote Added: 0029258
2010-07-13 13:07hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/c80022d61c9c207ea7bd855722c1abd5cd4d0beb [^] => http://code.openbravo.com/erp/devel/dbsm-main/rev/c978edcb7064709b909861321890e13ccb827767 [^]
2010-07-14 04:44hudsonbotCheckin
2010-07-14 04:44hudsonbotNote Added: 0029295
2010-07-14 16:28shuehnerNote Added: 0029313
2010-07-14 16:28shuehnerStatusresolved => closed
2010-07-15 00:00anonymoussf_bug_id0 => 3029720
2010-07-23 13:00hgbotCheckin
2010-07-23 13:00hgbotNote Added: 0029530
2010-07-23 13:03hgbotCheckin
2010-07-23 13:03hgbotNote Added: 0029531
2010-07-27 15:41hudsonbotCheckin
2010-07-27 15:41hudsonbotNote Added: 0029605

Notes
(0029257)
hgbot   
2010-07-13 13:05   
Repository: erp/devel/pi
Changeset: c80022d61c9c207ea7bd855722c1abd5cd4d0beb
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Tue Jul 13 13:02:59 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/c80022d61c9c207ea7bd855722c1abd5cd4d0beb [^]

Fixed issue 13947. FKs will now be managed correctly if a module adds columns to the AD

---
M src-db/database/lib/dbsourcemanager.jar
---
(0029258)
hgbot   
2010-07-13 13:07   
Repository: erp/devel/dbsm-main
Changeset: c978edcb7064709b909861321890e13ccb827767
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Tue Jul 13 13:02:08 2010 +0200
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/c978edcb7064709b909861321890e13ccb827767 [^]

Fixed issue 13947. FKs will now be managed correctly if a module adds columns to the AD

---
M src/org/openbravo/ddlutils/task/AlterDatabaseDataMod.java
---
(0029295)
hudsonbot   
2010-07-14 04:44   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/c80022d61c9c [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/2a91111beef4 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17878.obx [^]
(0029313)
shuehner   
2010-07-14 16:28   
Tested in pi, rev: b4fdc3108285 on both postgresql + oracle
Tested doing: install of adv payables and receviables module rebuild via mmc (which does update.database.mod in this case) then set all modules in development, do consistency test regarding structure changes. Also checked that the described warnings/problem are no longer present in the update log.
(0029530)
hgbot   
2010-07-23 13:00   
Repository: erp/devel/dbsm-main
Changeset: 4fa01d918254ed530a27ee870d342dc36f5bb128
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Fri Jul 23 12:59:49 2010 +0200
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/4fa01d918254ed530a27ee870d342dc36f5bb128 [^]

Related to issue 13947. Cleaned update.database.mod changes a bit.
Moved log messages inside the if() clause, so that if they will not be shown if there is no database model to update for that particular module. Also, moved the removeDeletedFKTriggers method call inside that if clause too, for basically the same reason.

---
M src/org/openbravo/ddlutils/task/AlterDatabaseDataMod.java
---
(0029531)
hgbot   
2010-07-23 13:03   
Repository: erp/devel/pi
Changeset: fa203c41fbfd5a441b3f890f8aecf62ee7e09336
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Fri Jul 23 13:03:10 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/fa203c41fbfd5a441b3f890f8aecf62ee7e09336 [^]

Related to issue 13947. Cleaned update.database.mod changes a bit.
Moved log messages inside the if() clause, so that if they will not be shown if there is no database model to update for that particular module. Also, moved the removeDeletedFKTriggers method call inside that if clause too, for basically the same reason.

---
M src-db/database/lib/dbsourcemanager.jar
---
(0029605)
hudsonbot   
2010-07-27 15:41   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/fa203c41fbfd [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/634cc0909ed2 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17922.obx [^]