Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0013924Openbravo ERPA. Platformpublic2010-07-08 14:052010-07-10 11:23
Reportershuehner 
Assigned Toalostale 
PriorityurgentSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0013924: Problem with preferences having empty value -> Can'T login
DescriptionFollowing situation:

A module ship a row for ad_preferences for setting a startpage with some non-empty value and without any filter on user or role etc...

Now i wanted to create a more specific preference for a specified user 'classic' with an empty value which should have higher priority.

After doing this change i could not change role or login anymore because of some NPE happening.

Error as logged during login process:
930160 [http-8080-6] ERROR org.openbravo.erpCommon.security.Menu - HTTPSecureAppServlet.service() - exception caught:
java.lang.NullPointerException
    at org.openbravo.erpCommon.businessUtility.Preferences.isHigherPriority(Preferences.java:444)
    at org.openbravo.erpCommon.businessUtility.Preferences.getAllPreferences(Preferences.java:74)
    at org.openbravo.base.secureApp.LoginUtils.fillSessionArguments(LoginUtils.java:201)
    at org.openbravo.base.secureApp.HttpSecureAppServlet.service(HttpSecureAppServlet.java:311)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
Steps To Reproducei.e. Install new layout modules (navigationbar)
Create a new user called 'classic' assign it i.e. System Administrator role
Create a new preference for entry startpage with no value
which is restricted to Username: 'classic'
Logout
Try to login -> does not work, NPE in the log
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-07-08 14:05shuehnerNew Issue
2010-07-08 14:05shuehnerAssigned To => alostale
2010-07-08 14:05shuehnerOBNetwork customer => No
2010-07-08 14:43hgbotCheckin
2010-07-08 14:43hgbotNote Added: 0029164
2010-07-08 14:43hgbotStatusnew => resolved
2010-07-08 14:43hgbotResolutionopen => fixed
2010-07-08 14:43hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/2fbed15478c0439b5b8065e23accfc20c5e2921f [^]
2010-07-09 13:32shuehnerNote Added: 0029186
2010-07-09 13:32shuehnerStatusresolved => closed
2010-07-10 00:00anonymoussf_bug_id0 => 3027597
2010-07-10 11:23hudsonbotCheckin
2010-07-10 11:23hudsonbotNote Added: 0029206

Notes
(0029164)
hgbot   
2010-07-08 14:43   
Repository: erp/devel/pi
Changeset: 2fbed15478c0439b5b8065e23accfc20c5e2921f
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Jul 08 14:43:34 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/2fbed15478c0439b5b8065e23accfc20c5e2921f [^]

fixed issue 13924: Problem with preferences having empty value

  Prevent NPE when comparing preferences with null value

---
M src/org/openbravo/erpCommon/businessUtility/Preferences.java
---
(0029186)
shuehner   
2010-07-09 13:32   
Tested working fine now, no NPE anymore and the correct, more strict preference is used.
(0029206)
hudsonbot   
2010-07-10 11:23   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/2fbed15478c0 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/8cb9c6ccb2e4 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17829.obx [^]