Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0013916ModulesButlerpublic2010-07-07 17:582010-07-10 11:23
Reporteralostale 
Assigned Toalostale 
PriorityimmediateSeveritycriticalReproducibilitysometimes
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned To
Support ticket
OBNetwork customerNo
Regression introduced in release
Summary0013916: Licenses with big number of modules are not activable
DescriptionThe original cause for issue 0013894 is that butler generates licenses that are longer than the maximum column size where they are stored in the ERP DB.

Issue 0013894 fixes the problem in new Openbravo ERP versions, but the issue is still present for older versions. If this happens an instance for this license will not be possible to activate.
Steps To Reproduce-Obtain a license with a big number of commercial modules associated (around 60)
-Try to activate an instance in a Openbravo ERP <=2.50mp19 -> The error described in 0013894 appears.
Proposed SolutionWhen trying to activate an instance, send the instance core version (only for >=mp20). In case this info is not send, it means the instance is <mp20, so check the size of the generated key, in case it is higher than 4000 chars, re-generate it removing all the modules that do not fit in the key size but making sure core is in.

In this way the instance will loose some modules information (preventing installing or updating them) but at least it would be possible to update to >=mp20 and refresh license then.

In order to make aware the user of this problem, the only possible solution is to append to the license's customer name a text like follows:

 Customer Name -- Limited to xx modules!! Upgrade to 2.50MP20 and refresh the license to obtain all of them.
Additional Information
TagsNo tags attached.
Relationships
related to defect 0013894 closed alostale Openbravo ERP Activation an instance fails if the license contains too many modules 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-07-07 17:58alostaleNew Issue
2010-07-07 17:58alostaleAssigned To => alostale
2010-07-07 17:58alostaleOBNetwork customer => No
2010-07-07 18:05hgbotCheckin
2010-07-07 18:05hgbotNote Added: 0029136
2010-07-07 18:08hgbotCheckin
2010-07-07 18:08hgbotNote Added: 0029138
2010-07-07 18:08hgbotStatusnew => resolved
2010-07-07 18:08hgbotResolutionopen => fixed
2010-07-07 18:08hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.butler.ops/rev/8077d18a4444a835218521a634a5609325255859 [^]
2010-07-07 18:18hgbotCheckin
2010-07-07 18:18hgbotNote Added: 0029141
2010-07-08 08:05alostaleStatusresolved => new
2010-07-08 08:05alostaleResolutionfixed => open
2010-07-08 08:05alostaleRelationship addedrelated to 0013894
2010-07-08 08:05alostaleStatusnew => scheduled
2010-07-08 08:05alostalefix_in_branch => pi
2010-07-08 08:06alostaleStatusscheduled => resolved
2010-07-08 08:06alostaleResolutionopen => fixed
2010-07-09 10:24marvintmNote Added: 0029178
2010-07-09 10:24marvintmStatusresolved => closed
2010-07-10 11:23hudsonbotCheckin
2010-07-10 11:23hudsonbotNote Added: 0029201

Notes
(0029136)
hgbot   
2010-07-07 18:05   
Repository: erp/devel/pi
Changeset: d6bdb910859089c22d1588dfd0362fb43eed364e
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Jul 07 18:04:39 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/d6bdb910859089c22d1588dfd0362fb43eed364e [^]

related to issue 13916: Licenses with big number of modules are not activable

  Send from Openbravo ERP core version when activating an Instance.

---
M src/org/openbravo/erpCommon/obps/ActiveInstanceProcess.java
---
(0029138)
hgbot   
2010-07-07 18:08   
Repository: erp/pmods/org.openbravo.butler.ops
Changeset: 8077d18a4444a835218521a634a5609325255859
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Jul 07 18:08:43 2010 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.butler.ops/rev/8077d18a4444a835218521a634a5609325255859 [^]

fixed issue 13916: Licenses with big number of modules are not activable

  Receive from erp the core version, if it is not reveived version is <mp20.
  In this case limit the size of the generated license to 4000 characters, by
  not including modules.

---
M src/org/openbravo/butler/ops/ActivationKeyGetter.java
---
(0029141)
hgbot   
2010-07-07 18:18   
Repository: erp/pmods/org.openbravo.butler.ops
Changeset: 7d5819b60131b89d19add9f8352f5abbcd5d4b34
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Jul 07 18:18:11 2010 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.butler.ops/rev/7d5819b60131b89d19add9f8352f5abbcd5d4b34 [^]

related to issue 13916: Added missing parameter

---
M src/org/openbravo/butler/ops/DownloadActivation.java
---
(0029178)
marvintm   
2010-07-09 10:24   
Verified that in MP20 "candidate" the activation of the license goes fine, and that in MP19, the activation goes as fine as it can go (only a limited amount of modules are active, and you see the intended message in the Customer Name field in the Instance Activation window).
(0029201)
hudsonbot   
2010-07-10 11:23   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/d6bdb9108590 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/8cb9c6ccb2e4 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17829.obx [^]