Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0013911 | Openbravo ERP | Z. Others | public | 2010-07-07 13:38 | 2011-11-04 19:56 |
|
| Reporter | shuehner | |
| Assigned To | mtaal | |
| Priority | low | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | no change required | |
| Platform | | OS | 5 | OS Version | |
| Product Version | 2.50 | |
| Target Version | | Fixed in Version | | |
| Merge Request Status | |
| Review Assigned To | |
| OBNetwork customer | |
| Web browser | |
| Modules | User Interface Application |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0013911: Multiple instances of the online help window can be opened - Is this checked for safety (like classic windows) |
| Description | Classic windows in the multi-tab interface are restricted to only open one instance of a specific window at a time.
However the new online-help inside a tab does not have this restrictions currently.
It is needed to check the code of the online help (including the builtin help-editor to check if that is safe, or the same restrictions (one instance) should be applied. |
| Steps To Reproduce | |
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2010-07-07 13:38 | shuehner | New Issue | |
| 2010-07-07 13:38 | shuehner | Assigned To | => mtaal |
| 2010-07-08 23:16 | mtaal | Note Added: 0029173 | |
| 2010-07-08 23:16 | mtaal | Note Added: 0029174 | |
| 2010-07-08 23:16 | mtaal | Status | new => feedback |
| 2010-07-09 14:04 | shuehner | Note Added: 0029188 | |
| 2010-07-09 14:06 | shuehner | Status | feedback => new |
| 2010-07-12 00:33 | mtaal | Note Added: 0029213 | |
| 2010-07-12 00:33 | mtaal | Status | new => feedback |
| 2011-09-07 13:28 | mtaal | Priority | urgent => none |
| 2011-09-07 13:28 | mtaal | Priority | none => low |
| 2011-10-07 11:10 | dmitry_mezentsev | Note Added: 0041545 | |
| 2011-11-04 19:56 | mtaal | Status | feedback => closed |
| 2011-11-04 19:56 | mtaal | Resolution | open => no change required |
|
Notes |
|
|
(0029173)
|
|
mtaal
|
|
2010-07-08 23:16
|
|
I checked the code in the DisplayHelp.java class and saw this:
String strClave = vars.getSessionValue("Help.clave");
vars.removeSessionValue("Help.clave");
so subsequent request can remove a session value. This at first sight means that the help can not be shown in multiple tabs. However, I checked the complete project and I could not find a case where the session variable Help.clave is actually set. So based on that conclusion afaics the DisplayHelp is MDI safe! |
|
|
|
(0029174)
|
|
mtaal
|
|
2010-07-08 23:16
|
|
|
|
|
|
Would be fine if there wouldn't exist some methods in VariablesSecureapp with strange semantics... :(
The writes to this session-variable are hidden behind those calls:
vars.getRequiredGlobalVariable("inpClave", "Help.clave");
Doing a grep in the ad_help package for 'Help.clave' shows about three of them. |
|
|
|
(0029213)
|
|
mtaal
|
|
2010-07-12 00:33
|
|
Hi Stefan,
Do you see any issues here? It seems that there is little change of issues here (compared to the advantage of having multiple help windows open).
I don't understand the code good enough myself...
gr. Martin |
|
|
|
|
Hello Guys,
This issue is in a feedback status for quite a while.
Do you consider it as a valid one?
If so please schedule it, if not - let´s close.
Thanks. |
|