Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0013909Openbravo ERPZ. Otherspublic2010-07-07 13:302010-12-09 16:03
Reportershuehner 
Assigned Tomtaal 
PriorityurgentSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version2.50 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesUser Interface Application
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0013909: Registration popup is now shown always, even after using 'Decline'
DescriptionNew layout now shows the registration popup after login. After using the decline option in the popup and logging out/in the popup is shown again.

Expected result: after using decline the popup is never shown again.
Steps To Reproduce
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0013872 closed mtaal HeartbeatPopup and register popup are not shown at all in new UI. 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-07-07 13:30shuehnerNew Issue
2010-07-07 13:30shuehnerAssigned To => mtaal
2010-07-07 13:31shuehnerPrioritynormal => urgent
2010-07-07 16:17shuehnerRelationship addedrelated to 0013872
2010-07-07 23:51hgbotCheckin
2010-07-07 23:51hgbotNote Added: 0029151
2010-07-07 23:51hgbotStatusnew => resolved
2010-07-07 23:51hgbotResolutionopen => fixed
2010-07-07 23:51hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/4289ad5e71e89f6b82ca6f02fd4a26105ecfd26e [^]
2010-07-07 23:52hgbotCheckin
2010-07-07 23:52hgbotNote Added: 0029152
2010-07-07 23:52hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/4289ad5e71e89f6b82ca6f02fd4a26105ecfd26e [^] => http://code.openbravo.com/erp/mods/org.openbravo.client.application/rev/c19fc4df65a936fa44ffd2e929a1085234af78d9 [^]
2010-07-08 13:56shuehnerNote Added: 0029158
2010-07-08 13:56shuehnerStatusresolved => new
2010-07-08 13:56shuehnerResolutionfixed => open
2010-07-08 23:42hgbotCheckin
2010-07-08 23:42hgbotNote Added: 0029176
2010-07-08 23:42hgbotStatusnew => resolved
2010-07-08 23:42hgbotResolutionopen => fixed
2010-07-08 23:42hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/mods/org.openbravo.client.application/rev/c19fc4df65a936fa44ffd2e929a1085234af78d9 [^] => http://code.openbravo.com/erp/devel/pi/rev/07813f3009e745898246d790679986995152ce30 [^]
2010-07-09 13:55shuehnerNote Added: 0029187
2010-07-09 13:55shuehnerStatusresolved => closed
2010-07-10 11:23hudsonbotCheckin
2010-07-10 11:23hudsonbotNote Added: 0029204
2010-07-10 16:12hudsonbotCheckin
2010-07-10 16:12hudsonbotNote Added: 0029209
2010-12-09 16:03anonymoussf_bug_id0 => 3133310

Notes
(0029151)
hgbot   
2010-07-07 23:51   
Repository: erp/devel/pi
Changeset: 4289ad5e71e89f6b82ca6f02fd4a26105ecfd26e
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Jul 07 23:51:20 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/4289ad5e71e89f6b82ca6f02fd4a26105ecfd26e [^]

Fixes issue 13909: Registration popup is now shown always, even after using 'Decline'

---
M src/org/openbravo/erpCommon/ad_process/HeartbeatProcess.java
M src/org/openbravo/erpCommon/utility/VerticalMenu.java
---
(0029152)
hgbot   
2010-07-07 23:52   
Repository: erp/mods/org.openbravo.client.application
Changeset: c19fc4df65a936fa44ffd2e929a1085234af78d9
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Jul 07 23:51:58 2010 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.client.application/rev/c19fc4df65a936fa44ffd2e929a1085234af78d9 [^]

Fixes issue 13909: Registration popup is now shown always, even after using 'Decline'

---
M src/org/openbravo/client/application/HeartBeatPopupActionHandler.java
---
(0029158)
shuehner   
2010-07-08 13:56   
Reopening to solve coding-style/defensive-coding issue.
Please use switch instead of if/then/else-cascade for both checks of the enum.
(0029176)
hgbot   
2010-07-08 23:42   
Repository: erp/devel/pi
Changeset: 07813f3009e745898246d790679986995152ce30
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Thu Jul 08 23:41:54 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/07813f3009e745898246d790679986995152ce30 [^]

fixes issue 13909: Registration popup is now shown always, even after using 'Decline'

---
M src/org/openbravo/erpCommon/utility/VerticalMenu.java
---
(0029187)
shuehner   
2010-07-09 13:55   
Reviewed and tested now working fine in new layout (which same behavior as in old layout). Code is now centralized and called from both places. Tested behavior for classic layout using live builds -> still working fine.
(0029204)
hudsonbot   
2010-07-10 11:23   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/4289ad5e71e8 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/8cb9c6ccb2e4 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17829.obx [^]
(0029209)
hudsonbot   
2010-07-10 16:12   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/07813f3009e7 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/ba2af91d3aab [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17830.obx [^]