Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0013894Openbravo ERPA. Platformpublic2010-07-05 19:492010-07-10 00:00
Reportershuehner 
Assigned Toalostale 
PriorityimmediateSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0013894: Activation an instance fails if the license contains too many modules
DescriptionWhen trying to activate one of our test-licenses using stage-butler this failed as the butler response data (encrypted+base64-encoded) had size 4096 while the field activation_key in ad_system in which we store this only has size 4000. -> Fails to activate.

Secondly when trying to display this error message some NPE happens (Which is already displayed as possible NPE in eclipse (location InstanceManagement line 394).

doing the following hack for testing, let us finish the activation:
alter table ad_system alter column activation_key type varchar(10000);
update ad_column set fieldlength = 10000 where ad_column_id= '6ABF02FADF644959E040007F010125A8';
Steps To Reproduce
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0013901 closed alostale Openbravo ERP api check build 176 fails 
related to defect 0013916 closed alostale Modules Licenses with big number of modules are not activable 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-07-05 19:49shuehnerNew Issue
2010-07-05 19:49shuehnerAssigned To => alostale
2010-07-05 19:49shuehnerOBNetwork customer => No
2010-07-05 19:50shuehnerNote Added: 0029070
2010-07-06 09:48hgbotCheckin
2010-07-06 09:48hgbotNote Added: 0029079
2010-07-06 09:48hgbotStatusnew => resolved
2010-07-06 09:48hgbotResolutionopen => fixed
2010-07-06 09:48hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/73e5034ab377d929f447bdd53b71e46ebae05bf5 [^]
2010-07-06 12:40alostaleRelationship addedrelated to 0013901
2010-07-07 12:38hudsonbotCheckin
2010-07-07 12:38hudsonbotNote Added: 0029114
2010-07-08 08:05alostaleRelationship addedrelated to 0013916
2010-07-09 09:51marvintmNote Added: 0029177
2010-07-09 09:51marvintmStatusresolved => closed
2010-07-10 00:00anonymoussf_bug_id0 => 3027596

Notes
(0029070)
shuehner   
2010-07-05 19:50   
Doing this query in stage-butler-db:
SELECT l.customer_name, m.butops_license_id, count(m.*) from butops_module m, butops_license l where l.butops_license_id = m.butops_license_id group by m.butops_license_id, l.customer_name order by count desc;

Shows a license count per license for the test-licences of 51, and counts for normal licences <=38 (which perhaps some exceptions ... check sql-output)

The exact limit for the failure to happens is not yet known.
(0029079)
hgbot   
2010-07-06 09:48   
Repository: erp/devel/pi
Changeset: 73e5034ab377d929f447bdd53b71e46ebae05bf5
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Jul 06 09:47:33 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/73e5034ab377d929f447bdd53b71e46ebae05bf5 [^]

fixed bug 13894: Activation an instance fails if the license contains too many modules

  AD_System.Activation_key column is now a CLOB to allow licenses with a big number of
  granted modules.

  Fixed NPW when trying to show the message in case of a problem during the license activation

---
M src-db/database/model/tables/AD_SYSTEM.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src/org/openbravo/erpCommon/ad_forms/InstanceManagement.java
---
(0029114)
hudsonbot   
2010-07-07 12:38   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/73e5034ab377 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/d555a35070ee [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17817.obx [^]
(0029177)
marvintm   
2010-07-09 09:51   
Tested that a license which previously failed can now be applied with this change.