Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0013881Openbravo ERPZ. Otherspublic2010-07-02 19:202011-09-07 13:44
Reportershuehner 
Assigned Tomtaal 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionunable to reproduce 
PlatformOS5OS Version
Product Version2.50 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesUser Interface Application
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0013881: Back button handling not working in one special case
DescriptionBack button handling is not working correctly in the special case described below
Steps To ReproduceUsing new layout
As openbravo admin role
goto general ledger report
use 01.01.2000 - 13.12.2010
and the select the smallbazaar accounting schema
use search (the report output is shown as html below then)
follow first link (31-12-2006)
Follow link in resulting page (Journal Entry 1)
Note a new classic window was opened in the same tab
Use browser back button
-> Error: You do not have sufficient privileges to access this page

plus info in log:

a3196480 785526 [http-8080-3] ERROR org.openbravo.base.VariablesBase - Input: MANUAL not accepted by filter: org.openbravo.base.filter.ValueListFilter@6be9ad6c
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0013882 closed shuehner Error thrown from i.e. ValueListFilter Value 'zz' is not an accepted input should contain error location (stacktrace) in logfile 
Attached Filespatch utils_js.patch (4,726) 2010-07-03 21:30
https://issues.openbravo.com/file_download.php?file_id=2742&type=bug
Issue History
Date ModifiedUsernameFieldChange
2010-07-02 19:20shuehnerNew Issue
2010-07-02 19:20shuehnerAssigned To => mtaal
2010-07-02 19:20shuehnerOBNetwork customer => No
2010-07-02 19:21shuehnerRelationship addedrelated to 0013882
2010-07-03 21:29mtaalNote Added: 0029042
2010-07-03 21:30mtaalFile Added: utils_js.patch
2010-12-06 07:48alostaleStatusnew => scheduled
2011-09-07 13:44mtaalStatusscheduled => closed
2011-09-07 13:44mtaalResolutionopen => unable to reproduce

Notes
(0029042)
mtaal   
2010-07-03 21:29   
I studied this case in detail. There are a number of obstacles to overcome:
- the computation of the command/mode variable in the utils.js in the sendWindowInfoToMDI does not take into account that windows can have many different types of commands. The current computation defaults to 'manual' for a manual window, resulting in the error page being shown (You do not have sufficient privileges to access this page)
- One way of making this method more advanced is to let it find the command parameter which was used to post the form.
- However this command parameter is not present in the url but is often a posted form attribute. The utils.js is run when the page returns to the browser so the posted info is lost.
- A solution can be to append the command parameter to each url when the submitCommandForm method is called. This approach has been tried and gives good results (more testing is needed).
- Then when the utils.js is run in the browser the command can be read from the url and placed in the history.

See the attached diff for this change.

Another change which is needed is that in the Menu.java the set of allowed commands should be extended/or not limited.

As this issue requires multiple changes in core code and also is a specific case of a manual window it is not done as part of rc1.