Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0013849 | Openbravo ERP | Z. Others | public | 2010-06-30 17:30 | 2022-02-01 08:09 |
|
| Reporter | mtaal | |
| Assigned To | Triage Platform Base | |
| Priority | normal | Severity | major | Reproducibility | have not tried |
| Status | new | Resolution | out of date | |
| Platform | | OS | 5 | OS Version | |
| Product Version | 2.50 | |
| Target Version | | Fixed in Version | | |
| Merge Request Status | |
| Review Assigned To | |
| OBNetwork customer | |
| Web browser | |
| Modules | User Interface Application |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0013849: Code in some modules is copied from core, needs to be refactored in core to prevent duplicate code |
| Description | Some modules have code duplicated from core. To prevent this code duplication the code in core needs to be refactored to separate methods which can be called from the modules.
Specifically the following code has to be checked/refactored:
- KernelServlet.logout method and its uses
- AlertActionHandler.execute method |
| Steps To Reproduce | |
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2010-06-30 17:30 | mtaal | New Issue | |
| 2010-06-30 17:30 | mtaal | Assigned To | => mtaal |
| 2010-06-30 17:37 | shuehner | Issue Monitored: shuehner | |
| 2010-06-30 17:47 | shuehner | Note Added: 0028931 | |
| 2010-07-01 18:48 | shuehner | Severity | minor => major |
| 2010-07-01 18:50 | shuehner | Note Added: 0028963 | |
| 2010-07-07 13:31 | shuehner | Note Added: 0029124 | |
| 2010-08-31 09:41 | hgbot | Checkin | |
| 2010-08-31 09:41 | hgbot | Note Added: 0030509 | |
| 2010-08-31 10:00 | hgbot | Checkin | |
| 2010-08-31 10:00 | hgbot | Note Added: 0030516 | |
| 2010-09-03 14:37 | hgbot | Checkin | |
| 2010-09-03 14:37 | hgbot | Note Added: 0030604 | |
| 2010-12-06 07:48 | alostale | Status | new => scheduled |
| 2012-06-15 17:12 | alostale | Type | defect => design defect |
| 2016-10-21 11:00 | mtaal | Status | scheduled => closed |
| 2016-10-21 11:00 | mtaal | Resolution | open => out of date |
| 2016-10-21 13:17 | mtaal | Tag Attached: MT_closed_out_of_date | |
| 2016-10-21 14:08 | mtaal | Assigned To | mtaal => platform |
| 2016-10-21 14:09 | mtaal | Status | closed => new |
| 2016-10-21 14:12 | mtaal | Tag Detached: MT_closed_out_of_date | |
| 2022-02-01 08:09 | alostale | Assigned To | platform => Triage Platform Base |
|
Notes |
|
|
|
More places to be checked:
UserInfoWidgetAction (.. UserSessionResetter (for i.e. RoleChange))
KernelServlet integration with core HSAS servlet |
|
|
|
|
|
Also code for getRoles in UserInfoWidgetActionHandler |
|
|
|
|
|
new code of hearbeat/registration popup is also copied from core file |
|
|
|
(0030509)
|
|
hgbot
|
|
2010-08-31 09:41
|
|
Repository: erp/mods/org.openbravo.client.kernel
Changeset: 55365a0b4d68c9e97f8e7daeb5fd72e371c3d27a
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Aug 31 09:40:12 2010 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.client.kernel/rev/55365a0b4d68c9e97f8e7daeb5fd72e371c3d27a [^]
Renamed AuthenticatingServlet, fixes issue 14376: Move wrapping in contextual seem request from KernelServlet & DatasourceServlet to super class. Related to issue 13849: Code in some modules is copied from core, needs to be refactored in core to prevent duplicate code
---
M src/org/openbravo/client/kernel/KernelServlet.java
A src/org/openbravo/client/kernel/BaseKernelServlet.java
R src/org/openbravo/client/kernel/AuthenticatingServlet.java
---
|
|
|
|
(0030516)
|
|
hgbot
|
|
2010-08-31 10:00
|
|
|
|
|
(0030604)
|
|
hgbot
|
|
2010-09-03 14:37
|
|
|