Openbravo Issue Tracking System - Modules
View Issue Details
0013747ModulesNew selectorspublic2010-06-23 14:082010-06-30 12:17
shuehner 
iperdomo 
normalmajorhave not tried
closedfixed 
5
 
 
0013747: New selectors module (the conversion module) produces wad errors after its process has been run
After using the 'Update to nwe selectors' process of the conversion module and running compile.complete lots of NPE's are shown in normal compilation.

Example:
     [java] 16677 [main] INFO org.openbravo.wad.Wad - Processing Window: Business Partner - Tab: Product Template - id: 800009
     [java] java.lang.NullPointerException
     [java] at org.openbravo.wad.controls.WADControl.columnIdentifier(WADControl.java:377)
     [java] at org.openbravo.wad.WadUtility.columnIdentifier(WadUtility.java:157)
     [java] at org.openbravo.wad.Wad.processTabJava(Wad.java:1797)
     [java] 17001 [main] ERROR org.openbravo.wad.Wad - Problem at close of the file: 800009
     [java] at org.openbravo.wad.Wad.processTab(Wad.java:1065)
     [java] at org.openbravo.wad.Wad.main(Wad.java:419)

No tags attached.
Issue History
2010-06-23 14:08shuehnerNew Issue
2010-06-23 14:08shuehnerAssigned To => iperdomo
2010-06-23 14:10shuehnerNote Added: 0028697
2010-06-23 14:10shuehnerNote Added: 0028698
2010-06-23 16:40iperdomoCategoryUser Interface Selector => New selectors
2010-06-23 16:41iperdomoStatusnew => scheduled
2010-06-23 16:41iperdomofix_in_branch => pi
2010-06-24 09:59hgbotCheckin
2010-06-24 09:59hgbotNote Added: 0028728
2010-06-24 09:59hgbotStatusscheduled => resolved
2010-06-24 09:59hgbotResolutionopen => fixed
2010-06-24 09:59hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/92c5a224fb80002f1628869b6ff37b492bf6235b [^]
2010-06-24 14:56shuehnerNote Added: 0028740
2010-06-24 14:56shuehnerStatusresolved => closed
2010-06-30 12:17hudsonbotCheckin
2010-06-30 12:17hudsonbotNote Added: 0028902

Notes
(0028697)
shuehner   
2010-06-23 14:10   
Note:
Reverting the update-references for a single affected tab/column makes the error go away.

I.e. testcase:
ant compile -Dtab='Business' -Dtr=no
Look at error in 'Contact tab' of Business partner window:

sql to revert the references change:
update ad_column set ad_reference_id = '30' where ad_column_id = '5844';
update ad_column set ad_reference_value_id = '800057' where ad_column_id = '5844';
Note ad_column_id 5844 is c_pbartner_id column of 'contact' tab (field linking to parent tab Business partner).
(0028698)
shuehner   
2010-06-23 14:10   
Guess for cause: special wad logic for 'read-only selector' fields rendered as normal read-only textfields (which are used in core to work around bad performance with huge list of entries in dropdowns)
(0028728)
hgbot   
2010-06-24 09:59   
Repository: erp/devel/pi
Changeset: 92c5a224fb80002f1628869b6ff37b492bf6235b
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Thu Jun 24 09:58:01 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/92c5a224fb80002f1628869b6ff37b492bf6235b [^]

Fixes issue 13747: Prevents NPE when changing reference to new selector
The NPE happens on fields of child tabs and are associated with the column
marked as 'link to parent'. Changed the way to check for value 'Y' to prevent
the NPE.

---
M src-wad/src/org/openbravo/wad/controls/WADControl.java
---
(0028740)
shuehner   
2010-06-24 14:56   
Reviewed+tested, now wad compilation of the changed tabs works with the NPE and the changed fields seem to be working fine.
(0028902)
hudsonbot   
2010-06-30 12:17   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/92c5a224fb80 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/0670375d782d [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17726.obx [^]