Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0013724Openbravo ERPY. DBSourceManagerpublic2010-06-22 15:322012-03-02 15:39
Reportershuehner 
Assigned Tomarvintm 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version3.0MP9 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0013724: export.config.script fails with non-applied changes in some other module extending the AD
DescriptionHaving unpackaed a newer module version files into modules/ which contain a change extending some AD_dataset table and not having applied those to the database yet.

Then doing export.config.script this fails as the xml-files contain the definition for the new column (extending some ad_table) but the corresponding data in the database is not yet present -> failure

[exportconfigscript] 108205 INFO - Module added to comparison: 21F679F2BEC342CD870705F92DBEC3E2
[exportconfigscript] 108211 INFO - Module added to comparison: 3D1C583F6590438482D997B56332B761
[exportconfigscript] 108213 INFO - Module added to comparison: 0
[exportconfigscript] 108217 INFO - Module added to comparison: 46B62703B1BC4459BD209119B90398F4
[exportconfigscript] 108220 INFO - Module added to comparison: 4B828F4D03264080AA1D2057B13F613C
[exportconfigscript] 108222 INFO - Module added to comparison: A44B9BA75C354D8FB2E3F7D6EB6BFDC4
[exportconfigscript] 108231 INFO - Module added to comparison: 5EB4F15C80684ACA904756BDC12ADBE5
[exportconfigscript] 108234 INFO - Module added to comparison: A918E3331C404B889D69AA9BFAFB23AC
[exportconfigscript] 108239 INFO - Module added to comparison: EC356CEE3D46416CA1EBEEB9AB82EDB9
[exportconfigscript] 108242 INFO - Module added to comparison: F8D1B3ECB3474E8DA5C216473C840DF1
[exportconfigscript] 108249 INFO - Module added to comparison: C696E2946E774F2AB85CD2F23DAAB009
[exportconfigscript] 108254 INFO - Module added to comparison: 382C52ECFBDF4E54A018A51D3F9876D3
[exportconfigscript] java.lang.IllegalArgumentException: Invalid property name 'FILTER_EXPRESSION'
[exportconfigscript] at org.apache.commons.beanutils.BasicDynaBean.getDynaProperty(BasicDynaBean.java:369)
[exportconfigscript] at org.apache.commons.beanutils.BasicDynaBean.get(BasicDynaBean.java:125)
[exportconfigscript] at org.apache.ddlutils.alteration.DataComparator.compareRows(DataComparator.java:187)
[exportconfigscript] at org.apache.ddlutils.alteration.DataComparator.compareTablesToUpdate(DataComparator.java:144)
[exportconfigscript] at org.apache.ddlutils.alteration.DataComparator.compare(DataComparator.java:86)
[exportconfigscript] at org.openbravo.ddlutils.task.ExportConfigScript.doExecute(ExportConfigScript.java:201)
[exportconfigscript] at org.openbravo.ddlutils.task.BaseDatabaseTask.execute(BaseDatabaseTask.java:87)
Steps To ReproduceHave pi (rev: fd9d90c149d1)
Have UI Selector module 1.0.7 installed
udpate.database and recompile
remove 1.0.7 module folder and replace it by mercurial clone of the same module (rev: 14356502d10f)
have one template in delveopment
run export.config.script

see failure
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Fileszip org.openbravo.antonion.1.0.zip (6,439) 2012-02-23 17:08
https://issues.openbravo.com/file_download.php?file_id=5022&type=bug
zip org.openbravo.antonion.zip (6,910) 2012-02-23 17:08
https://issues.openbravo.com/file_download.php?file_id=5023&type=bug
Issue History
Date ModifiedUsernameFieldChange
2010-06-22 15:32shuehnerNew Issue
2010-06-22 15:32shuehnerAssigned To => marvintm
2010-06-23 10:31alostaleStatusnew => scheduled
2010-06-23 10:31alostalefix_in_branch => pi
2012-02-23 17:08marvintmFile Added: org.openbravo.antonion.1.0.zip
2012-02-23 17:08marvintmFile Added: org.openbravo.antonion.zip
2012-02-23 17:10marvintmNote Added: 0045416
2012-02-23 17:40hgbotCheckin
2012-02-23 17:40hgbotNote Added: 0045419
2012-02-23 17:40hgbotStatusscheduled => resolved
2012-02-23 17:40hgbotResolutionopen => fixed
2012-02-23 17:40hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/334833f4c3a7927d855c61f66516cd27efbb2587 [^]
2012-02-23 17:54marvintmNote Added: 0045421
2012-02-24 11:27hgbotCheckin
2012-02-24 11:27hgbotNote Added: 0045440
2012-02-24 11:27hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/334833f4c3a7927d855c61f66516cd27efbb2587 [^] => http://code.openbravo.com/erp/devel/dbsm-main/rev/53542248c8400b29d7c492e7ee11814626c30048 [^]
2012-02-28 10:35AugustoMauchNote Added: 0045509
2012-02-28 10:35AugustoMauchStatusresolved => closed
2012-02-28 10:35AugustoMauchFixed in Version => 3.0MP9
2012-03-02 15:39hudsonbotCheckin
2012-03-02 15:39hudsonbotNote Added: 0045945

Notes
(0045416)
marvintm   
2012-02-23 17:10   
To reproduce an equivalent issue (the root cause is the same), go through the following steps:

- Unzip the contents of the attached file "org.openbravo.antonion1.0.zip" to the modules folder of Openbravo.
- Execute ant update.database
- Remove the module, and unzip the contents of the attached file "org.openbravo.antonion.zip" to the modules folder of Openbravo.
- Execute:
ant export.config.script

An exception will be raised.
(0045419)
hgbot   
2012-02-23 17:40   
Repository: erp/devel/pi
Changeset: 334833f4c3a7927d855c61f66516cd27efbb2587
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Thu Feb 23 17:32:29 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/334833f4c3a7927d855c61f66516cd27efbb2587 [^]

Fixed issue 19855. Comparator is now consistent and transitive. Fixed issue 13724. Dataset information will now be loaded from the database instead of the XML files.

---
M src-db/database/lib/dbsourcemanager.jar
---
(0045421)
marvintm   
2012-02-23 17:54   
Test plan:

Basically, all dataset-using dbsourcemanager tasks need to be tested. So:

- Test that update.database and export.database produce the desired results (install a module, for instance, and export another module).
- Test that if a change in the AD is done, and export.config.script is executed, the change goes to the configuration script
- Test that the problem described in the previous note (using the attached files) does not happen with the new version of dbsourcemanager
(0045440)
hgbot   
2012-02-24 11:27   
Repository: erp/devel/dbsm-main
Changeset: 53542248c8400b29d7c492e7ee11814626c30048
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Thu Feb 23 17:26:05 2012 +0100
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/53542248c8400b29d7c492e7ee11814626c30048 [^]

Fixed issue 13724. Dataset information will now be loaded from the database instead of the XML files.
Therefore, errors such as the one reported in the issue, caused by the dataset definition not being consistent with the state of the database, will no longer happen.

---
M src/org/openbravo/ddlutils/task/ExportConfigScript.java
M src/org/openbravo/ddlutils/util/OBDataset.java
---
(0045509)
AugustoMauch   
2012-02-28 10:35   
Code reviewed and verified
(0045945)
hudsonbot   
2012-03-02 15:39   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/544d64e0c159 [^]

Maturity status: Test