0013683: Review/Fix LoginUtils.fillSessionArguments function

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0013683

Openbravo ERP

A. Platform

public

2010-06-17 13:16

2022-02-01 08:08

Reporter

iperdomo

Assigned To

Triage Platform Base

Priority

high

Severity

minor

Reproducibility

have not tried

Status

acknowledged

Resolution

open

Platform

OS Version

2.6.30-gentoo-r5

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0013683: Review/Fix LoginUtils.fillSessionArguments function

Description

The fillSessionArguments executed in 2 cases:
* In the login process just after validating the username/password
* Using the change role window, where you can change the user's role, client, organization, etc

This function returns false when something went wrong trying to complete one of the steps in the process, changing a OBContext or setting one of the required session values.

In the login process when fillSessionArguments returns false, the process redirects to logout directly. This is correct and not a problem.

The problem is when changing role. Since the changes inside are not atomic (one transaction) the OBContext could be changed and non of the session variables reset or set the new ones. The process prompts an error message to the user, but the state is inconsistent, the OBContext is changed so, some DAL based process could use the _new_ context, where some of the session variables are using the _old_ state.

Steps To Reproduce

Proposed Solution

The fillSessionArguments should be atomic, with the possibility to rollback the previous state on an error. This is a problem just when changing role using the 'Change Role' window.

Additional Information