Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0013667Openbravo ERPA. Platformpublic2010-06-15 19:422010-07-06 00:00
Reportershuehner 
Assigned Toiperdomo 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target Version2.50MP20Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0013667: Minor cleanup in /modulescript/HBFix_data.xsql
DescriptionThis xsql file of the HBFix modulescript does define a few xsql-methods which are not used at all by the corresponding java file.

At least:
- updateNotActive
- selectUserId

Please check all those and remove the unused ones.
Steps To Reproduce
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 00136252.50MP19 closed iperdomo [HB] When Heartbeat is enabled a process request in Scheduled state must exist 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-06-15 19:42shuehnerNew Issue
2010-06-15 19:42shuehnerAssigned To => iperdomo
2010-06-15 19:44shuehnerNote Added: 0028473
2010-06-16 09:42iperdomoStatusnew => acknowledged
2010-06-16 09:42iperdomoTarget Version => 2.50MP20
2010-06-16 09:42iperdomoStatusacknowledged => scheduled
2010-06-16 09:42iperdomofix_in_branch => pi
2010-06-16 09:59iperdomoRelationship addedrelated to 0013625
2010-07-05 13:16hgbotCheckin
2010-07-05 13:16hgbotNote Added: 0029055
2010-07-05 13:16hgbotStatusscheduled => resolved
2010-07-05 13:16hgbotResolutionopen => fixed
2010-07-05 13:16hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/6f09e1d5b1617646eda1b30aba3cadf368df112a [^]
2010-07-05 13:54shuehnerNote Added: 0029061
2010-07-05 13:54shuehnerStatusresolved => closed
2010-07-05 20:41hudsonbotCheckin
2010-07-05 20:41hudsonbotNote Added: 0029072
2010-07-06 00:00anonymoussf_bug_id0 => 3025608

Notes
(0028473)
shuehner   
2010-06-15 19:44   
When doing this change, please add a small comment to the modulescript java-code explaining what it does (perhaps mention link to corresponding mantis issue).
(0029055)
hgbot   
2010-07-05 13:16   
Repository: erp/devel/pi
Changeset: 6f09e1d5b1617646eda1b30aba3cadf368df112a
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Mon Jul 05 13:15:25 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/6f09e1d5b1617646eda1b30aba3cadf368df112a [^]

Fixes issue 13667: Code cleanup. Removed unused methods, class commented

---
M src-util/modulescript/build/classes/org/openbravo/modulescript/HBFix.class
M src-util/modulescript/build/classes/org/openbravo/modulescript/HBFixData.class
M src-util/modulescript/src/org/openbravo/modulescript/HBFix.java
M src-util/modulescript/src/org/openbravo/modulescript/HBFix_data.xsql
---
(0029061)
shuehner   
2010-07-05 13:54   
Verified, change is only removing unneeded methods (checked via compilation), and adds an explanatory comment to the ModuleScript.
(0029072)
hudsonbot   
2010-07-05 20:41   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/6f09e1d5b161 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/a11139370c90 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17805.obx [^]