Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0013665Openbravo ERPA. Platformpublic2010-06-15 17:442023-03-22 01:40
Reportershuehner 
Assigned ToAugustoMauch 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version3.0MP16 
Merge Request Status
Review Assigned Todbaz
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0013665: When disabling heartbeat, the process for sending beats is only unscheduled in running tomcat, butrunning again after tomcat res
Descriptiontart.

The code for disabling heartbeat does not modify the process_request to update its status (or delete the request). It only unschedules it in the currently running scheduler (inside the currently running tomcat).

This means that the process will be running again after you restart tomcat, however as the ad_system_info flag is set to heartbeat disabled this process will not really send beat.
-> priority: minor

As just wrong local behavior but not functional problem (as no beats get send after disabling it)
Steps To ReproduceCheck code in TestHearbeat servlet around line 111

The pr instance (process request) is read from the db, then not modified, then saved....

Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0018214 closed alostale Scheduled processes executed on tomcat restart 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-06-15 17:44shuehnerNew Issue
2010-06-15 17:44shuehnerAssigned To => alostale
2010-06-15 18:38shuehnerNote Added: 0028459
2010-06-23 10:41alostaleStatusnew => scheduled
2011-11-16 17:26alostaleRelationship addedrelated to 0018214
2012-09-19 16:18AugustoMauchClosed by => alostale
2012-09-19 16:20AugustoMauchNote Added: 0052230
2012-09-19 16:20AugustoMauchIssue Monitored: alostale
2012-09-19 16:22hgbotCheckin
2012-09-19 16:22hgbotNote Added: 0052231
2012-09-19 16:22hgbotStatusscheduled => resolved
2012-09-19 16:22hgbotResolutionopen => fixed
2012-09-19 16:22hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/d9a38ada2c86d12ca540e1401734cf0b98ccfc9b [^]
2012-09-26 11:52AugustoMauchAssigned Toalostale => AugustoMauch
2012-09-26 11:52AugustoMauchNote Added: 0052616
2012-09-26 11:52AugustoMauchStatusresolved => new
2012-09-26 11:52AugustoMauchResolutionfixed => open
2012-09-26 11:52AugustoMauchClosed byalostale => dbaz
2012-09-26 11:52AugustoMauchStatusnew => scheduled
2012-09-26 11:52AugustoMauchStatusscheduled => resolved
2012-09-26 11:52AugustoMauchResolutionopen => fixed
2012-09-26 17:20hudsonbotCheckin
2012-09-26 17:20hudsonbotNote Added: 0052787
2012-09-26 17:52dbazNote Added: 0052805
2012-09-26 17:52dbazStatusresolved => closed
2012-09-26 17:52dbazFixed in Version => 3.0MP16
2023-03-22 01:40kitftfyNote Added: 0147790
2023-03-22 09:30shuehnerNote Deleted: 0147790

Notes
(0028459)
shuehner   
2010-06-15 18:38   
Updated info from testing this behavior. The process_request does get modified to status unscheduled somehow (perhaps by the scheduler itself). However in that case the

OBDal.getInstance().save(pr);

in TestHearbeat line 111 seems to be useless.
(0052230)
AugustoMauch   
2012-09-19 16:20   
Test plan:
 Check that after the change it has not changed the way heartbeat is unscheduled:
- Check that heartbeat is scheduled in the Process Request window
- Open the Heartbeat Configuration window and disable heartbeat.
- Go back to the Process Request window, and check that heartbeat status is unscheduled.
- Go back to Heartbeat Configuration and enable heartbeat again.
- In the Process Request window, check that heartbeat status is scheduled again.
(0052231)
hgbot   
2012-09-19 16:22   
Repository: erp/devel/pi
Changeset: d9a38ada2c86d12ca540e1401734cf0b98ccfc9b
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Sep 19 16:17:34 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/d9a38ada2c86d12ca540e1401734cf0b98ccfc9b [^]

Fixes issue 13665: Remove unnecessary DAL save

When heartbeat is disabled, the process request is fetched with DAL, and used to unschedule the process. The process request itself it is not explicitly modified, so there is no need to save it.

---
M src/org/openbravo/erpCommon/ad_process/TestHeartbeat.java
---
(0052616)
AugustoMauch   
2012-09-26 11:52   
Reopened to change Closed by field
(0052787)
hudsonbot   
2012-09-26 17:20   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b780e90c6452 [^]

Maturity status: Test
(0052805)
dbaz   
2012-09-26 17:52   
Reviewed @ changeset: 18052 - 8a0aed9bd90d