Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0013664 | Openbravo ERP | A. Platform | public | 2010-06-15 17:26 | 2011-01-27 00:00 |
|
| Reporter | shuehner | |
| Assigned To | shuehner | |
| Priority | urgent | Severity | major | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | pi | |
| Target Version | | Fixed in Version | | |
| Merge Request Status | |
| Review Assigned To | |
| OBNetwork customer | |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0013664: api-check should get special case for newly added std-boolean-constraint for newly added columns. |
| Description | The api-check always complains about newly added constraint. However those are safe, if they only concern newly added columns.
However detecting this would mean parsing all the sql-check-string which is unfeasible.
However a simple special case occurs often. A new char(1) (aka boolean) column is added and the usual check-constraint (for 'Y','N') with it. This constraint has a defined syntax always and should be able to be detected easily.
Adding this special case to the api-check would mean less false-positives which need to be handled differently. |
| Steps To Reproduce | |
| Proposed Solution | Add new special case to api-check
in case a new check constraint is added and matches the pattern for the standard 'Y','N' constraint and hte column name in the pattern is also a newly added column in the same check -> don't report as error
in all other cases -> report as done now |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2010-06-15 17:26 | shuehner | New Issue | |
| 2010-06-15 17:26 | shuehner | Assigned To | => alostale |
| 2011-01-24 17:46 | shuehner | Assigned To | alostale => shuehner |
| 2011-01-24 17:52 | hgbot | Checkin | |
| 2011-01-24 17:52 | hgbot | Note Added: 0033842 | |
| 2011-01-24 17:53 | shuehner | Note Added: 0033843 | |
| 2011-01-24 17:57 | hgbot | Checkin | |
| 2011-01-24 17:57 | hgbot | Note Added: 0033844 | |
| 2011-01-24 17:57 | hgbot | Status | new => resolved |
| 2011-01-24 17:57 | hgbot | Resolution | open => fixed |
| 2011-01-24 17:57 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/b8c227ba3b2400ddea4052259ef72299444b0627 [^] |
| 2011-01-26 12:04 | marvintm | Status | resolved => closed |
| 2011-01-27 00:00 | anonymous | sf_bug_id | 0 => 3166237 |
|
Notes |
|
|
(0033842)
|
|
hgbot
|
|
2011-01-24 17:52
|
|
Repository: erp/devel/dbsm-main
Changeset: b411b82706ed8a7c14066e4827fd3fdd9a1e4c98
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Mon Jan 24 17:51:09 2011 +0100
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/b411b82706ed8a7c14066e4827fd3fdd9a1e4c98 [^]
Issue 13664: Skip complaining about new bool-constraint for new columns
Adding a new boolean column with its 'usual' boolean constraint is fine and
common so special case it in the api-check so no complaint is generated.
Api-Check errors are still generated for other new constraints
as well as warnings for changing check constraints.
To allow to follow that reasoning an info message block is added to the output
for informal messages not letting the api-check fail.
---
M src/org/openbravo/ddlutils/task/CheckAPI.java
M src/org/openbravo/ddlutils/task/CheckAPIDistribution.java
M src/org/openbravo/ddlutils/util/ValidateAPI.java
M src/org/openbravo/ddlutils/util/ValidateAPIModel.java
---
|
|
|
|
|
Tested in pi using the following three testcases
a.) add new boolean column + check constraint for it together -> no error but info message now
b.) add boolean check constraint for existing column -> should trigger error as before
c.) add non-boolean check constraint (some other check constraint) -> should trigger error as before
all worked fine. |
|
|
|
(0033844)
|
|
hgbot
|
|
2011-01-24 17:57
|
|
Repository: erp/devel/pi
Changeset: b8c227ba3b2400ddea4052259ef72299444b0627
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Mon Jan 24 17:57:12 2011 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/b8c227ba3b2400ddea4052259ef72299444b0627 [^]
Fixed 13664: Skip complaining about new bool-constraint for new columns
Adding a new boolean column with its 'usual' boolean constraint is fine and
common so special case it in the api-check so no complaint is generated.
Api-Check errors are still generated for other new constraints
as well as warnings for changing check constraints.
To allow to follow that reasoning an info message block is added to the output
for informal messages not letting the api-check fail.
---
M src-db/database/lib/dbsourcemanager.jar
---
|
|