Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0013641Openbravo ERPY. DBSourceManagerpublic2010-06-14 12:202010-07-17 00:00
Reporternetworkb 
Assigned Tomarvintm 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version2.50MP18 
Target Version2.50MP20Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0013641: The export.database task fails when a function or trigger has been created from pgAdmin on windows
DescriptionThe export.database task fails when a function or trigger has been created from pgAdmin on windows.

The problem is on the checkTranslationConsistency process.
This is because on windows instead of \n is used \r \n

Steps To Reproduce-Create a function on a database from pgadmin on windows.
-Try to export the database with ant export.database
You get this error:


[exportdatabase] ********************************************************
[exportdatabase] Found differences in FUNCTION_NAME
[exportdatabase] ********************************************************
[exportdatabase] java.lang.ArrayIndexOutOfBoundsException: 0
[exportdatabase] at org.apache.ddlutils.platform.PlatformImplBase.printDiff(PlatformImplBase.java:2981)
[exportdatabase] at org.apache.ddlutils.platform.postgresql.PostgreSqlPlatform.checkTranslationConsistency(PostgreSqlPlatform.java:472)
[exportdatabase] at org.openbravo.ddlutils.task.ExportDatabase.execute(ExportDatabase.java:120)
[exportdatabase] at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:288)
[exportdatabase] at sun.reflect.GeneratedMethodAccessor2.invoke(Unknown Source)
[exportdatabase] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
[exportdatabase] at java.lang.reflect.Method.invoke(Method.java:597)
[exportdatabase] at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:105)
[exportdatabase] at org.apache.tools.ant.Task.perform(Task.java:348)
[exportdatabase] at org.apache.tools.ant.Target.execute(Target.java:357)
[exportdatabase] at org.apache.tools.ant.Target.performTasks(Target.java:385)
[exportdatabase] at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1329)
[exportdatabase] at org.apache.tools.ant.helper.SingleCheckExecutor.executeTargets(SingleCheckExecutor.java:38)
[exportdatabase] at org.apache.tools.ant.Project.executeTargets(Project.java:1181)
[exportdatabase] at org.apache.tools.ant.taskdefs.Ant.execute(Ant.java:416)
[exportdatabase] at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:288)
[exportdatabase] at sun.reflect.GeneratedMethodAccessor2.invoke(Unknown Source)
[exportdatabase] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
[exportdatabase] at java.lang.reflect.Method.invoke(Method.java:597)
[exportdatabase] at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:105)
[exportdatabase] at org.apache.tools.ant.Task.perform(Task.java:348)
[exportdatabase] at org.apache.tools.ant.Target.execute(Target.java:357)
[exportdatabase] at org.apache.tools.ant.Target.performTasks(Target.java:385)
[exportdatabase] at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1329)
[exportdatabase] at org.apache.tools.ant.Project.executeTarget(Project.java:1298)
[exportdatabase] at org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41)
[exportdatabase] at org.apache.tools.ant.Project.executeTargets(Project.java:1181)
[exportdatabase] at org.apache.tools.ant.Main.runBuild(Main.java:698)
[exportdatabase] at org.apache.tools.ant.Main.startAnt(Main.java:199)
[exportdatabase] at org.apache.tools.ant.launch.Launcher.run(Launcher.java:257)
[exportdatabase] at org.apache.tools.ant.launch.Launcher.main(Launcher.java:104)

update.dbupdate.timestamp:
      [sql] Executing commands
      [sql] 1 of 1 SQL statements executed successfully

BUILD SUCCESSFUL
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-06-14 12:20networkbNew Issue
2010-06-14 12:20networkbAssigned To => marvintm
2010-06-14 12:20networkbOBNetwork customer => Yes
2010-06-14 13:02iciordiaStatusnew => acknowledged
2010-06-29 13:13hgbotCheckin
2010-06-29 13:13hgbotNote Added: 0028855
2010-06-29 13:13hgbotStatusacknowledged => resolved
2010-06-29 13:13hgbotResolutionopen => fixed
2010-06-29 13:13hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/ec19b75afff3696e7b308742bd3e35f9a8697101 [^]
2010-06-29 15:23hgbotCheckin
2010-06-29 15:23hgbotNote Added: 0028865
2010-06-29 15:23hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/ec19b75afff3696e7b308742bd3e35f9a8697101 [^] => http://code.openbravo.com/erp/devel/dbsm-main/rev/7f331c7ba43dbfc98851cf561f4551167a02b1a5 [^]
2010-07-02 14:50hudsonbotCheckin
2010-07-02 14:50hudsonbotNote Added: 0028994
2010-07-16 18:40shuehnerNote Added: 0029369
2010-07-16 18:40shuehnerStatusresolved => closed
2010-07-17 00:00anonymoussf_bug_id0 => 3030768

Notes
(0028855)
hgbot   
2010-06-29 13:13   
Repository: erp/devel/pi
Changeset: ec19b75afff3696e7b308742bd3e35f9a8697101
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Tue Jun 29 13:13:12 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/ec19b75afff3696e7b308742bd3e35f9a8697101 [^]

Fixed issue 13641. checkTranslationConsistency will work correctly on Windows

---
M src-db/database/lib/dbsourcemanager.jar
---
(0028865)
hgbot   
2010-06-29 15:23   
Repository: erp/devel/dbsm-main
Changeset: 7f331c7ba43dbfc98851cf561f4551167a02b1a5
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Tue Jun 29 13:12:53 2010 +0200
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/7f331c7ba43dbfc98851cf561f4551167a02b1a5 [^]

Fixed issue 13641. checkTranslationConsistency will work correctly on Windows

---
M src/org/apache/ddlutils/platform/PlatformImplBase.java
---
(0028994)
hudsonbot   
2010-07-02 14:50   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/ec19b75afff3 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/8fd5a427789e [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17797.obx [^]
(0029369)
shuehner   
2010-07-16 18:40   
Reviewed by me: fine. Tested that wrong behavior does not happen anymore by reporter, as i could not reproduce it myself even before applying the fix.