Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0013638Openbravo ERPA. Platformpublic2010-06-14 11:432010-06-16 19:01
shuehner 
marvintm 
immediatemajorhave not tried
closedfixed 
5
2.50MP18 
 
Core
No
0013638: AD_PREFERENCE table had new required column added without an onCreateDefault
A new required column "SELECTED" was added to this table, but its missing an onCreateDefault clause which will make module installations cause errors shown (not unll constraint cannot be activated...) if the module ships a row for this table and does not contain the new column in its sourcedata xml-file.
Regression
related to defect 0013640 closed AugustoMauch api-check needs to be updated to check for onCreateDefault for new,required columns in tables contained in the AD dataset 
Issue History
2010-06-14 11:43shuehnerNew Issue
2010-06-14 11:43shuehnerAssigned To => marvintm
2010-06-14 11:46shuehnerRelationship addedrelated to 0013640
2010-06-14 11:54shuehnerDescription Updatedbug_revision_view_page.php?rev_id=497#r497
2010-06-14 12:26hgbotCheckin
2010-06-14 12:26hgbotNote Added: 0028358
2010-06-14 12:26hgbotStatusnew => resolved
2010-06-14 12:26hgbotResolutionopen => fixed
2010-06-14 12:26hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e92cbd6025bea89de5c12cb8b9bdaca550d60805 [^]
2010-06-15 05:43hudsonbotCheckin
2010-06-15 05:43hudsonbotNote Added: 0028404
2010-06-15 16:31shuehnerNote Added: 0028453
2010-06-15 16:31shuehnerStatusresolved => closed
2010-06-16 00:00anonymoussf_bug_id0 => 3016776
2010-06-16 19:01psarobeTag Attached: Regression
2010-06-16 19:01psarobeversionpi => 2.50MP18

Notes
(0028358)
hgbot   
2010-06-14 12:26   
Repository: erp/devel/pi
Changeset: e92cbd6025bea89de5c12cb8b9bdaca550d60805
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Mon Jun 14 12:09:08 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/e92cbd6025bea89de5c12cb8b9bdaca550d60805 [^]

Fixed issue 13638. Added oncreatedefault to SELECTED column in AD_PREFERENCE.
As this is a sourcedata mandatory column, it needs an oncreatedefault.

---
M src-db/database/model/tables/AD_PREFERENCE.xml
---
(0028404)
hudsonbot   
2010-06-15 05:43   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/e92cbd6025be [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/f7644da65496 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17606.obx [^]
(0028453)
shuehner   
2010-06-15 16:31   
Tested using 'org.openbravo.advpaymentmngt' module which does insert new rows into ad_preference and was failing before as the selected column in ad_preference was missing the onCreateDefault definition.

Now the module installs without an error related to the column.