Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0013618Openbravo ERPA. Platformpublic2010-06-11 10:212010-06-16 00:00
Reporteriperdomo 
Assigned Toiperdomo 
PriorityurgentSeveritymajorReproducibilitysometimes
StatusclosedResolutionfixed 
PlatformOS20OS Version2.6.30-gentoo-r5
Product Version2.50MP18 
Target Version2.50MP19Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0013618: [HB] Problems with Heartbeat and misfired process requests and deactivation
Description* The way to identify if Heartbeat is enabled, is: Heartbeat is active at AD_System_Info, and there is a Scheduled process request (to send the beats periodically). This check doesn't take into account if the HB process request is in status Misfired (MIS).
* If you want to install a module this check fails on Misfired process requests, tells the user that Heartbeat is not enabled, the user enables it again, so the process creates a new process request
* The deactivation of heartbeat requires a double execution, due to a wrong logic
Steps To Reproduce* Update the heartbeat process request to Misfired (MIS) status
* Try to install a module
* You'll see that asks to enable Heartbeat again (wrong)
* Try to disable Hearbeat from the Menu, you'll see that you need to execute the process twice (wrong)
Proposed Solution* Consider a misfired (MIS) process request
Additional Information
TagsNo tags attached.
Relationships
related to defect 00136162.50MP19 closed iperdomo Misfired process requests are not handled properly 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-06-11 10:21iperdomoNew Issue
2010-06-11 10:21iperdomoAssigned To => iperdomo
2010-06-11 10:21iperdomoOBNetwork customer => No
2010-06-11 10:21iperdomoStatusnew => scheduled
2010-06-11 10:21iperdomofix_in_branch => pi
2010-06-11 10:22iperdomoPrioritynormal => urgent
2010-06-11 10:22iperdomofix_in_branchpi =>
2010-06-11 10:22iperdomoRelationship addedrelated to 0013616
2010-06-11 12:22hgbotCheckin
2010-06-11 12:22hgbotNote Added: 0028301
2010-06-11 12:22hgbotStatusscheduled => resolved
2010-06-11 12:22hgbotResolutionopen => fixed
2010-06-11 12:22hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/eb3434537214a27de070bf27c1bd201abe7ea36d [^]
2010-06-11 12:22hgbotCheckin
2010-06-11 12:22hgbotNote Added: 0028302
2010-06-12 22:48hudsonbotCheckin
2010-06-12 22:48hudsonbotNote Added: 0028328
2010-06-12 22:48hudsonbotCheckin
2010-06-12 22:48hudsonbotNote Added: 0028329
2010-06-15 19:10shuehnerNote Added: 0028469
2010-06-15 19:10shuehnerStatusresolved => closed
2010-06-16 00:00anonymoussf_bug_id0 => 3016774

Notes
(0028301)
hgbot   
2010-06-11 12:22   
Repository: erp/devel/pi
Changeset: eb3434537214a27de070bf27c1bd201abe7ea36d
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Fri Jun 11 11:20:26 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/eb3434537214a27de070bf27c1bd201abe7ea36d [^]

Fixes issue 13618: Fixes problem with misfired status, and double deactivation
The Heartbeat process could be in misfired status, this status is now
considered when evaluating if is enabled. The double deactivation was due to a
wrong logic when checking the request.

---
M src/org/openbravo/erpCommon/ad_process/HeartbeatProcess.java
M src/org/openbravo/erpCommon/ad_process/TestHeartbeat.java
---
(0028302)
hgbot   
2010-06-11 12:22   
Repository: erp/devel/pi
Changeset: 3b82a8f8e67f79c24b1b07207318e6ea9710e7f7
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Fri Jun 11 11:29:01 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/3b82a8f8e67f79c24b1b07207318e6ea9710e7f7 [^]

Related to issue 13618: Restored public constants

---
M src/org/openbravo/erpCommon/ad_process/HeartbeatProcess.java
---
(0028328)
hudsonbot   
2010-06-12 22:48   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/eb3434537214 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/0b85119b92bc [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17589.obx [^]
(0028329)
hudsonbot   
2010-06-12 22:48   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/3b82a8f8e67f [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/0b85119b92bc [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17589.obx [^]
(0028469)
shuehner   
2010-06-15 19:10   
Tested on pi/pgsql (rev: 8964c21d177f)
Tested, that:
- Using 'Enable Heartbeat' / 'Disable Heartbeat' does the correct action on the first try (update ad_system_info & update process_request)
- And the those action do also update the process_request correctly if the old process request was in state MIS (misfired) instead of scheduled or unscheduled.

All working fine -> Closing