Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0013616Openbravo ERPA. Platformpublic2010-06-11 10:122010-06-16 00:00
Reporteriperdomo 
Assigned Toiperdomo 
PriorityurgentSeveritymajorReproducibilitysometimes
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version2.50MP18 
Target Version2.50MP19Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0013616: Misfired process requests are not handled properly
DescriptionThe process request can have status misfired when a trigger misses an execution. The ProcessMonitor updates the status to Misfired (MIS) but the scheduling logic only take into account process in status Scheduled (SCH).
Steps To Reproduce* Schedule a process in the past to trigger a missed excution.
* Schedule this process to run a fixed amount of times every minute (just an exmple)
* Stop the tomcat server
* Restart the tomcat server

The process should be rescheduled to continue running the executions, but since is in status misfired is not rescheduled.
Proposed Solution* Remove from the ProcessMonitor the update on a misfired event
Additional Information
TagsNo tags attached.
Relationships
related to defect 00136182.50MP19 closed iperdomo [HB] Problems with Heartbeat and misfired process requests and deactivation 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-06-11 10:12iperdomoNew Issue
2010-06-11 10:12iperdomoAssigned To => iperdomo
2010-06-11 10:13iperdomoStatusnew => scheduled
2010-06-11 10:13iperdomofix_in_branch => pi
2010-06-11 10:22iperdomoRelationship addedrelated to 0013618
2010-06-11 10:27hgbotCheckin
2010-06-11 10:27hgbotNote Added: 0028296
2010-06-11 10:27hgbotStatusscheduled => resolved
2010-06-11 10:27hgbotResolutionopen => fixed
2010-06-11 10:27hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/ffad4a9982b0dfb6b90ee10f8bdcc9ccac55714e [^]
2010-06-12 22:48hudsonbotCheckin
2010-06-12 22:48hudsonbotNote Added: 0028326
2010-06-15 17:37shuehnerNote Added: 0028455
2010-06-15 17:37shuehnerStatusresolved => closed
2010-06-16 00:00anonymoussf_bug_id0 => 3016773

Notes
(0028296)
hgbot   
2010-06-11 10:27   
Repository: erp/devel/pi
Changeset: ffad4a9982b0dfb6b90ee10f8bdcc9ccac55714e
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Fri Jun 11 10:26:02 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/ffad4a9982b0dfb6b90ee10f8bdcc9ccac55714e [^]

Fixes issue 13616: Added misfired status to list, removed implementation.
The previous implementation on the mifired event,just updated the status
of the process request to Misfired (MIS), but almost all logic works with
Scheduled (SCH) requests, e.g. On the OBScheduler initialization
we just reschedule request on status: SCH

---
M src-db/database/sourcedata/AD_REFERENCE.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M src/org/openbravo/scheduling/ProcessMonitor.java
---
(0028326)
hudsonbot   
2010-06-12 22:48   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/ffad4a9982b0 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/0b85119b92bc [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17589.obx [^]
(0028455)
shuehner   
2010-06-15 17:37   
Reviewed+Tested. The scheduler is changed to never put a process request into the misfired state anymore.

This way there can't be any later problems because of a request being in state misfired.

A process scheduled in the past (and configured to be run periodically) is now correctly scheduled inside the same running tomcat and also after this tomcat has been restarted.