Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0013551Openbravo ERP00. Application dictionarypublic2010-06-07 12:382011-11-30 12:30
Reporterdalsasua 
Assigned Toguilleaer 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionUbuntu 9.04
Product Versionpi 
Target VersionpiFixed in Version3.0MP6 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0013551: When deleting a inclussion/dependency in a module, "is in development" flag is not checked
DescriptionInstall universities template (I guess will occur for every module having a include/dependency tab content)
Go to Application Dictionary || Module
Check that "In Development" check box is NOT active
Go to include tab
Remove any row
System allows to do so, even having the template not in development
Steps To Reproducesee description
Proposed Solutionin trigger AD_MODULE_DEPENDENCY_MOD_TRG add as well an "on delete" condition.
Additional Information
TagsOB3-Reviewed
Relationships
related to defect 0009540 closed alostale Mutating trigger error when trying to delete a module which has a module dependency 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-06-07 12:38dalsasuaNew Issue
2010-06-07 12:38dalsasuaAssigned To => alostale
2010-06-14 13:01iciordiaStatusnew => acknowledged
2011-11-17 17:47alostaleTag Attached: OB3-Reviewed
2011-11-23 10:23alostaleAssigned Toalostale => guilleaer
2011-11-25 10:30hgbotCheckin
2011-11-25 10:30hgbotNote Added: 0043201
2011-11-25 10:30hgbotStatusacknowledged => resolved
2011-11-25 10:30hgbotResolutionopen => fixed
2011-11-25 10:30hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/74a87a35819000e98bd5856c6e801af8f67b79dc [^]
2011-11-25 10:33alostaleStatusresolved => new
2011-11-25 10:33alostaleResolutionfixed => open
2011-11-25 10:33alostaleRelationship addedrelated to 0009540
2011-11-25 10:33alostaleStatusnew => scheduled
2011-11-25 10:33alostalefix_in_branch => pi
2011-11-25 10:34alostaleStatusscheduled => resolved
2011-11-25 10:34alostaleResolutionopen => fixed
2011-11-25 10:47alostaleNote Added: 0043204
2011-11-25 10:47alostaleStatusresolved => closed
2011-11-25 10:47alostaleFixed in Version => 3.0MP6
2011-11-30 12:30hudsonbotCheckin
2011-11-30 12:30hudsonbotNote Added: 0043442

Notes
(0043201)
hgbot   
2011-11-25 10:30   
Repository: erp/devel/pi
Changeset: 74a87a35819000e98bd5856c6e801af8f67b79dc
Author: Guillermo Álvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Thu Nov 24 18:00:32 2011 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/74a87a35819000e98bd5856c6e801af8f67b79dc [^]

Fixed issue 13551: if module is not in development mode you cant delete includes

---
M src-db/database/model/triggers/AD_MODULE_DEPENDENCY_MOD_TRG.xml
---
(0043204)
alostale   
2011-11-25 10:47   
Working on pi@74a87a358190

Code reviewed

Executed test cases:

*In both Oracle ad PG
 -Try to delete a dependency of a non in dev module. OK not allowed.
 -Try to delete a dependency of a in dev module. OK allowed.

Regression test:

This bug was introduced as fix for 0009540. Checking now 0009540 is not reproducible again.

*In both Oracle ad PG, grid and view forms:
 -Try to delete a non in dev module with dependencies. OK not allowed.
 -Try to delete an in dev module with dependencies. OK allowed.

Mutating table error is not raised anymore when deleting from UI because of how 3.0 children deletion is implemented, not relying on DB delete on cascade FKs but executing deletion for each child row.
(0043442)
hudsonbot   
2011-11-30 12:30   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/01809c7b3135 [^]

Maturity status: Test