Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0013537Openbravo ERPA. Platformpublic2010-06-04 19:072010-06-08 00:00
Reportershuehner 
Assigned Toalostale 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0013537: [NewCR] NPE in butler log when use Module tab of newly created forge project
DescriptionNPE in butler log when using Module tab of newly create forge project (which does not yet have a module assigned)

83.230.226.193 - - [04/Jun/2010:19:03:40 +0200] 33025 "GET /heartbeat-server/org.openbravo.utility.centralrepository.ui.sso/CentralRepository?navigate=ModuleTab&projectname=test1test2&projectId=715 HTTP/1.1" 200 461 "http://crtest.essentiaforge.org/projects/test1test2/module" [^] "Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.3) Gecko/20100423 Ubuntu/10.04 (lucid) Firefox/3.6.3"

==> /var/log/tomcat/butler.log <==
251ef582 19:03:41 [ajp-8009-3] ERROR org.openbravo.dal.core.ThreadHandler -
java.lang.NullPointerException
        at org.openbravo.utility.centralrepository.ui.sso.ModuleTab.printPageVersion(ModuleTab.java:166)
        at org.openbravo.utility.centralrepository.ui.sso.ModuleTab.doPost(ModuleTab.java:77)
Steps To ReproduceCreate a new project in the forge, mark the option 'module' when doing so
go to the projects page
Use the 'module' link on the top-menu
browser message says: Module not found
butler.log file has NPE
Proposed Solution
Additional Information
TagsNewCR
Relationships
related to defect 0013553 closed alostale [NewCR] Production forge has much nicer message when clicking on Module tab on a newly created project (not having a module yet) 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-06-04 19:07shuehnerNew Issue
2010-06-04 19:07shuehnerAssigned To => alostale
2010-06-04 19:08shuehnerTag Attached: NewCR
2010-06-04 19:08shuehnerNote Added: 0028008
2010-06-04 22:55hgbotCheckin
2010-06-04 22:55hgbotNote Added: 0028014
2010-06-04 22:55hgbotStatusnew => resolved
2010-06-04 22:55hgbotResolutionopen => fixed
2010-06-04 22:55hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.utility.centralrepository/rev/3e66944fd0079784c0cea0484a6050d633cf0c0c [^]
2010-06-07 12:55shuehnerRelationship addedrelated to 0013553
2010-06-07 12:56shuehnerNote Added: 0028052
2010-06-07 12:56shuehnerStatusresolved => closed
2010-06-08 00:00anonymoussf_bug_id0 => 3012881

Notes
(0028008)
shuehner   
2010-06-04 19:08   
In ModuleTab.java

around line 66:
        if (module == null) {
          printPageError(resp, "Module Not Found!");
        }

the error message is added however the servlet flow continues and later code fails as module == null
(0028014)
hgbot   
2010-06-04 22:55   
Repository: erp/pmods/org.openbravo.utility.centralrepository
Changeset: 3e66944fd0079784c0cea0484a6050d633cf0c0c
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Jun 04 22:54:08 2010 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.utility.centralrepository/rev/3e66944fd0079784c0cea0484a6050d633cf0c0c [^]

fixed bug 13537: prevent npe after showing no module found msg

---
M src/org/openbravo/utility/centralrepository/ui/sso/ModuleTab.java
---
(0028052)
shuehner   
2010-06-07 12:56   
Tested, NPE does no longer happen.