Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0013518Openbravo ERPA. Platformpublic2010-06-04 10:142010-06-18 00:00
Reporteriperdomo 
Assigned Toiperdomo 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS Version2.6.30-gentoo-r5
Product Version2.50MP18 
Target VersionFixed in Version2.50MP19 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0013518: ProcessBundle is not initilized on WAD generated code
DescriptionThe ProcessBundle has a init() methond that initializes the ProcessLogger, connection, among other things.

On WAD generated code, e.g. processes using 'Standard UI' the init method is not executed so some ProcessBundle members are null.
Steps To ReproduceCheck the WAD generated class:
* org.openbravo.erpCommon.ad_actionButton.ActionButton_Responser

Search for ProcessBundle class ocurrences, e.g.

ProcessBundle bundle = ProcessBundle.pinstance(pinstance, vars, this);
new ProcessRunner(bundle).execute(this);

As you can see the init() methond is not executed before running it.
Proposed SolutionCall the init() in the new instance call, e.g.

ProcessBundle bundle = ProcessBundle.pinstance(pinstance, vars, this).init(this);

Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-06-04 10:14iperdomoNew Issue
2010-06-04 10:14iperdomoAssigned To => iperdomo
2010-06-04 10:14iperdomoOBNetwork customer => No
2010-06-04 10:14iperdomoStatusnew => scheduled
2010-06-04 10:14iperdomofix_in_branch => pi
2010-06-04 12:04hgbotCheckin
2010-06-04 12:04hgbotNote Added: 0027946
2010-06-04 12:04hgbotStatusscheduled => resolved
2010-06-04 12:04hgbotResolutionopen => fixed
2010-06-04 12:04hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/869dd4f3577c08aeaa46e0d20cc1145d64b0ef7a [^]
2010-06-07 11:25iperdomoNote Added: 0028043
2010-06-07 11:25iperdomoStatusresolved => new
2010-06-07 11:25iperdomoResolutionfixed => open
2010-06-07 11:25iperdomoPriorityurgent => immediate
2010-06-07 11:25iperdomofix_in_branchpi =>
2010-06-07 11:25iperdomoStatusnew => scheduled
2010-06-07 11:25iperdomofix_in_branch => pi
2010-06-07 11:59hgbotCheckin
2010-06-07 11:59hgbotNote Added: 0028046
2010-06-07 11:59hgbotStatusscheduled => resolved
2010-06-07 11:59hgbotResolutionopen => fixed
2010-06-07 11:59hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/869dd4f3577c08aeaa46e0d20cc1145d64b0ef7a [^] => http://code.openbravo.com/erp/devel/pi/rev/9676c91a13200b8dbb637d07c00f34904ad5623b [^]
2010-06-07 21:20hudsonbotCheckin
2010-06-07 21:20hudsonbotNote Added: 0028080
2010-06-07 21:21hudsonbotCheckin
2010-06-07 21:21hudsonbotNote Added: 0028117
2010-06-07 23:43hudsonbotCheckin
2010-06-07 23:43hudsonbotNote Added: 0028122
2010-06-07 23:44hudsonbotCheckin
2010-06-07 23:44hudsonbotNote Added: 0028159
2010-06-17 15:36marvintmNote Added: 0028558
2010-06-17 15:36marvintmStatusresolved => closed
2010-06-17 15:36marvintmFixed in Version => 2.50MP19
2010-06-18 00:00anonymoussf_bug_id0 => 3017787

Notes
(0027946)
hgbot   
2010-06-04 12:04   
Repository: erp/devel/pi
Changeset: 869dd4f3577c08aeaa46e0d20cc1145d64b0ef7a
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Fri Jun 04 10:57:02 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/869dd4f3577c08aeaa46e0d20cc1145d64b0ef7a [^]

Fixes issue 13518: Added init() in ProcessBundle instances
The init call is used to initilze ProcessBundle memebers. For a proper
ProcessBundle is required to call it.

---
M src-wad/src/org/openbravo/wad/ActionButtonJava_Responser.javaxml
M src-wad/src/org/openbravo/wad/ActionButton_Responser.javaxml
M src-wad/src/org/openbravo/wad/javasource.javaxml
---
(0028043)
iperdomo   
2010-06-07 11:25   
This change triggers a problem in PL/SQL based processes
(0028046)
hgbot   
2010-06-07 11:59   
Repository: erp/devel/pi
Changeset: 9676c91a13200b8dbb637d07c00f34904ad5623b
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Mon Jun 07 11:58:27 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/9676c91a13200b8dbb637d07c00f34904ad5623b [^]

Fixes issue 13518: Added init call just for Java based calls
The pinstance() call is calling the init() methond inside, there is
no need to call it twice.

---
M src-wad/src/org/openbravo/wad/ActionButton_Responser.javaxml
M src-wad/src/org/openbravo/wad/javasource.javaxml
---
(0028080)
hudsonbot   
2010-06-07 21:20   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/869dd4f3577c [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/8b43a1f2fff4 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17563.obx [^]
(0028117)
hudsonbot   
2010-06-07 21:21   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/9676c91a1320 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/8b43a1f2fff4 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17563.obx [^]
(0028122)
hudsonbot   
2010-06-07 23:43   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/869dd4f3577c [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/8b43a1f2fff4 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17563.obx [^]
(0028159)
hudsonbot   
2010-06-07 23:44   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/9676c91a1320 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/8b43a1f2fff4 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17563.obx [^]
(0028558)
marvintm   
2010-06-17 15:36   
Tested with an implementation of the org.openbravo.scheduling.Process interface. Verified that the ProcessBundle was indeed initialized correctly, and for example the bundle.getLogger() object could be safely used.