Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0013432Openbravo ERPZ. Otherspublic2010-05-25 14:302010-06-30 12:16
Reporteradrianromero 
Assigned Toharikrishnan 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version2.50MP20Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0013432: Identifiers are now UUID and java code cannot suppose are integer values
DescriptionIn several parts of the code table identifier values are considered integers but this can be problematic with new registers where the identifier is created as an UUID that is no longer an integer value.

The problematic files are:

./org/openbravo/erpCommon/ad_process/ImportAccount.java: int newC_ValidCombination_ID = Integer.valueOf(respuestaCS.CValidCombinationId)
./org/openbravo/erpCommon/ws/services/WebServiceImpl.java: locationList[i] = Integer.valueOf(data[i].cLocationId).intValue();
./org/openbravo/erpCommon/ad_forms/Translation.java: final int AD_Client_ID = Integer.valueOf(strClient);
./org/openbravo/erpCommon/ad_forms/Translation.java: final int AD_Client_ID = Integer.valueOf(strClient);
./org/openbravo/erpCommon/utility/ReferencedTables.java: switch (Integer.valueOf(adReferenceId).intValue()) {
./org/openbravo/erpCommon/businessUtility/TabFilter.java: switch (Integer.valueOf(reference).intValue()) {
Steps To Reproduce
Proposed SolutionThe solution is not convert identifier values to integer and manage it as string values
Additional Information
TagsNo tags attached.
Relationships
related to defect 0013412 closed adrianromero SL_Order_DocType fails with non-numeric document type ID (i.e. newly created document types) 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-05-25 14:30adrianromeroNew Issue
2010-05-25 14:30adrianromeroAssigned To => adrianromero
2010-05-25 14:30adrianromeroOBNetwork customer => No
2010-05-25 14:30adrianromeroRelationship addedrelated to 0013412
2010-05-25 14:31adrianromeroStatusnew => scheduled
2010-05-25 14:31adrianromerofix_in_branch => pi
2010-06-22 06:13harikrishnanAssigned Toadrianromero => harikrishnan
2010-06-22 06:20hgbotCheckin
2010-06-22 06:20hgbotNote Added: 0028643
2010-06-22 06:20hgbotStatusscheduled => resolved
2010-06-22 06:20hgbotResolutionopen => fixed
2010-06-22 06:20hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/ac4d5bc99a6d183538c774ed2184431606cee603 [^]
2010-06-22 06:22harikrishnanNote Added: 0028644
2010-06-22 14:10hgbotCheckin
2010-06-22 14:10hgbotNote Added: 0028668
2010-06-22 14:10hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/ac4d5bc99a6d183538c774ed2184431606cee603 [^] => http://code.openbravo.com/erp/devel/pi/rev/0224f63396b4765abcb3cacf2c51b65a72e28117 [^]
2010-06-24 13:01adrianromeroNote Added: 0028737
2010-06-24 13:01adrianromeroStatusresolved => closed
2010-06-25 00:00anonymoussf_bug_id0 => 3021056
2010-06-30 12:16hudsonbotCheckin
2010-06-30 12:16hudsonbotNote Added: 0028888
2010-06-30 12:16hudsonbotCheckin
2010-06-30 12:16hudsonbotNote Added: 0028890

Notes
(0028643)
hgbot   
2010-06-22 06:20   
Repository: erp/devel/pi
Changeset: ac4d5bc99a6d183538c774ed2184431606cee603
Author: Harikrishnan Raja <harikrishnan.raja <at> openbravo.com>
Date: Tue Jun 22 09:46:20 2010 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/ac4d5bc99a6d183538c774ed2184431606cee603 [^]

Fixes Issue 13432: Identifiers are now UUID and java code cannot suppose are integer values.

---
M src/org/openbravo/erpCommon/ad_forms/Translation.java
M src/org/openbravo/erpCommon/ad_process/ImportAccount.java
M src/org/openbravo/erpCommon/businessUtility/TabFilter.java
M src/org/openbravo/erpCommon/utility/ReferencedTables.java
M src/org/openbravo/erpCommon/ws/services/WebService.java
M src/org/openbravo/erpCommon/ws/services/WebServiceImpl.java
---
(0028644)
harikrishnan   
2010-06-22 06:22   
Root Cause:

*In 2.40 Id is in integer,but in 2.5 its UUID.Hence this is changed to string.

Impact:

I have changed case statement to if else condition.so their is no impact in the functionality.
(0028668)
hgbot   
2010-06-22 14:10   
Repository: erp/devel/pi
Changeset: 0224f63396b4765abcb3cacf2c51b65a72e28117
Author: Harikrishnan Raja <harikrishnan.raja <at> openbravo.com>
Date: Tue Jun 22 17:39:42 2010 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/0224f63396b4765abcb3cacf2c51b65a72e28117 [^]

Fixes issue 13432: Reverting some files for changeset that cause API fail.

---
M src/org/openbravo/erpCommon/ws/services/WebService.java
M src/org/openbravo/erpCommon/ws/services/WebServiceImpl.java
---
(0028737)
adrianromero   
2010-06-24 13:01   
Issue reviewed
(0028888)
hudsonbot   
2010-06-30 12:16   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/ac4d5bc99a6d [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/0670375d782d [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17726.obx [^]
(0028890)
hudsonbot   
2010-06-30 12:16   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/0224f63396b4 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/0670375d782d [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17726.obx [^]