Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0013402Openbravo ERP07. Sales managementpublic2010-05-20 18:352010-06-10 00:00
Reporternetworkb 
Assigned Toadrianromero 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version2.50MP17 
Target Version2.50MP19Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0013402: ‘Create Lines From’ in Sales Invoice doesn’t work properly for a sales order with ‘Cancel Price Adjustment’
Description‘Create Lines From’ in Sales Invoice doesn’t work properly for a sales order with ‘Cancel Price Adjustment’. In the sales order no Price Adjustments records are included, however when the invoice is created a record is included. Same error with ‘Create Invoices from Order’.
Steps To Reproduce1. Master Data Management || Pricing || Price Adjustments || Adjustments
New Record
Name: Discount for Mafalda
Starting Date: 01-05-2010
Ending Date: 31-05-2010
Discount %: 10
Included Business Partners: All Selected
Included Product: All Selected
2. Master Data Management || Pricing || Price Adjustments || Adjustments >> Business Partner
New record
Business Partner: Mafalda Corporation
3. Master Data Management || Pricing || Price Adjustments || Adjustments >> Products
New Record
Product: Hat
4. Sales Management || Transactions || Sales Order || Header
New Record
Business Partner: Mafalda Corporation
Invoice Terms: Inmediate
Date Order: 20-05-2010
5. Sales Management || Transactions || Sales Order || Header >> Lines
New Record
Product: Hat
Cancel Price Adjustment: Y
Realize how net unit price changes when clicking ‘Cancel Price Adjustment’
6. Complete Sales Order

7. Sales Management || Transactions || Sales Invoice || Header
New Record
Business Partner: Mafalda Corporation
Date Invoice: 20-05-2010
8. ‘Create Lines From’ and select sales order created in 4.
9. Sales Management || Transactions || Sales Invoice || Header >> Lines
Realized Net Unit Price is right
10. Sales Management || Transactions || Sales Invoice || Header >> Lines >> Price Adjustments
Realized a new record has been added what’s wrong.


Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-05-20 18:35networkbNew Issue
2010-05-20 18:35networkbAssigned To => adrianromero
2010-05-21 11:16adrianromeroStatusnew => scheduled
2010-05-21 11:16adrianromerofix_in_branch => pi
2010-06-08 06:29hgbotCheckin
2010-06-08 06:29hgbotNote Added: 0028166
2010-06-08 06:29hgbotStatusscheduled => resolved
2010-06-08 06:29hgbotResolutionopen => fixed
2010-06-08 06:29hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/0569c1e9f6ee2d5cff020b91b0e72cc727c256d9 [^]
2010-06-08 06:30harikrishnanNote Added: 0028167
2010-06-08 12:10hudsonbotCheckin
2010-06-08 12:10hudsonbotNote Added: 0028174
2010-06-09 08:16sureshbabuNote Added: 0028199
2010-06-09 08:16sureshbabuStatusresolved => closed
2010-06-10 00:00anonymoussf_bug_id0 => 3014005

Notes
(0028166)
hgbot   
2010-06-08 06:29   
Repository: erp/devel/pi
Changeset: 0569c1e9f6ee2d5cff020b91b0e72cc727c256d9
Author: Harikrishnan Raja <harikrishnan.raja <at> openbravo.com>
Date: Tue Jun 08 09:58:48 2010 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/0569c1e9f6ee2d5cff020b91b0e72cc727c256d9 [^]

Fixes Issue 13402:The Cancel Price Adjustment is not checked while copying the Sales Order.

---
M src-db/database/model/triggers/C_INVOICELINE_TRG2.xml
M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom.java
M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_Invoice_data.xsql
---
(0028167)
harikrishnan   
2010-06-08 06:30   
Steps to test:

*Create a Price Adjustments with following details
    1.Master Data Management || Pricing || Price Adjustments || Adjustments
      Name: Discount for Mcgiver
      Starting Date: 01-05-2010
      Ending Date: 31-05-2010
      Discount %: 10
      Included Business Partners: All Selected
      Included Product: All Selected

    2.Master Data Management || Pricing || Price Adjustments || Adjustments >> Business Partner
         Business Partner: Mcgiver Corporation
         Master Data Management || Pricing || Price Adjustments || Adjustments >> Products
             Product: Hat

*Create a sales with business partner :mcgiver and product :hat.Check the Cancel Price Adjustment check box.
*Complete the sales order.
*Go to sales invoice create a invoice for the above order using Create lines From button.
*Now the price are copied with out price adjustments.

Root Cause:

*The Cancel Price Adjustment is not checked while copying the Sales Order.

Impact:

*The fix is in common place for both sales invoice and purchase invoice.The fix in Trigger will affect the purchase invoice also.But after verifying that its working as before.
(0028174)
hudsonbot   
2010-06-08 12:10   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/0569c1e9f6ee [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/a88fec5dfac2 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17567.obx [^]
(0028199)
sureshbabu   
2010-06-09 08:16   
verified