Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0013385Openbravo ERPA. Platformpublic2010-05-19 16:202012-04-02 06:11
Reportershuehner 
Assigned Tomigueldejuana 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0013385: buildvalidation does not give a useful error message if used with non-existing Openbravo.properties
DescriptionIf you use 'ant buildvalidation' in a working copy not having Openbravo.properties, then the following stacktrace is shown:

buildvalidation:
     [java] 0 [main] INFO org.openbravo.buildvalidation.BuildValidationHandler - Executing build validation: org.openbravo.buildvalidation.Cbpvendoracct
     [java] 10 [main] INFO org.openbravo.buildvalidation.BuildValidationHandler - Error executing build-validation: org.openbravo.buildvalidation.Cbpvendoracct
     [java] java.lang.reflect.InvocationTargetException
     [java] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
     [java] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
     [java] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
     [java] at java.lang.reflect.Method.invoke(Method.java:616)
     [java] at org.openbravo.buildvalidation.BuildValidationHandler.callExecute(BuildValidationHandler.java:94)
     [java] at org.openbravo.buildvalidation.BuildValidationHandler.main(BuildValidationHandler.java:67)
     [java] Caused by: java.lang.NullPointerException
     [java] at org.openbravo.buildvalidation.BuildValidation.getConnectionProvider(BuildValidation.java:55)
     [java] at org.openbravo.buildvalidation.Cbpvendoracct.execute(Cbpvendoracct.java:36)
     [java] ... 6 more
     [java] 12 [main] ERROR org.openbravo.buildvalidation.BuildValidationHandler - The build validation org.openbravo.buildvalidation.Cbpvendoracct couldn't be properly executed
Steps To Reproducesee description
Proposed SolutionShow a more useful error message like 'Could not find Openbravo.properties' instead of a NPE
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-05-19 16:20shuehnerNew Issue
2010-05-19 16:20shuehnerAssigned To => marvintm
2010-05-19 16:20shuehnerOBNetwork customer => No
2010-05-19 16:21shuehnerNote Added: 0027558
2010-05-24 08:42alostaleStatusnew => scheduled
2010-05-24 08:42alostalefix_in_branch => pi
2012-03-22 10:57marvintmAssigned Tomarvintm => migueldejuana
2012-03-22 15:35migueldejuanaNote Added: 0046656
2012-03-23 12:01hgbotCheckin
2012-03-23 12:01hgbotNote Added: 0046674
2012-03-23 12:01hgbotStatusscheduled => resolved
2012-03-23 12:01hgbotResolutionopen => fixed
2012-03-23 12:01hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/eff5eee6234b9d351ffb667d459327ad343584ed [^]
2012-03-23 12:12marvintmStatusresolved => closed
2012-04-02 06:11hudsonbotCheckin
2012-04-02 06:11hudsonbotNote Added: 0047209

Notes
(0027558)
shuehner   
2010-05-19 16:21   
Note: doing the steps needed to reproduce is not useful at all, just to tell the user in this case what he is doing wrong would be nice.
(0046656)
migueldejuana   
2012-03-22 15:35   
Test plan:

- Rename Openbravo.properties to Openbravo.properties.temp for example.
- Comment in the build.xml this line:

<target name="buildvalidation" depends="init, core.lib">
<!--<updatesystemstatus v="RB11"/>-->
    <condition property="buildValidation.var">
      <istrue value="${buildValidation}" />
    </condition>
    <ant dir="src-util/buildvalidation" target="buildvalidation" inheritAll="true" inheritRefs="true" />
  </target>

- launch: ant buildvalidation



No risky fix.
(0046674)
hgbot   
2012-03-23 12:01   
Repository: erp/devel/pi
Changeset: eff5eee6234b9d351ffb667d459327ad343584ed
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Mar 22 13:42:37 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/eff5eee6234b9d351ffb667d459327ad343584ed [^]

Fixed issue 13385: Added message in buildvalidation without Openbravo.properties
In buildvalidation ant task, with non-existing Openbravo.properties, the message: 'Could not find Openbravo.properties' has been added

---
M src-core/src/org/openbravo/buildvalidation/BuildValidation.java
---
(0047209)
hudsonbot   
2012-04-02 06:11   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7814864461ac [^]

Maturity status: Test