Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0013364 | Openbravo ERP | 07. Sales management | public | 2010-05-18 12:31 | 2010-06-16 00:00 |
|
| Reporter | networkb | |
| Assigned To | harikrishnan | |
| Priority | urgent | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | 2.50MP14 | |
| Target Version | 2.50MP19 | Fixed in Version | | |
| Merge Request Status | |
| Review Assigned To | |
| OBNetwork customer | |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0013364: The genereate invoices process does not work when there are many orders so when many invoices are going to be created |
| Description | The genereate invoices process does not work when there are many orders so when many invoices are going to be created |
| Steps To Reproduce | -Create 300 sales orders with invoice rule = immediate and with lines in organization A
-Complete the orders
-Go to Sales management > transactions > Generate invoices
-Select the organization A and click OK
-You get an error
The problem is because the variable v_Message on the c_invoice_create function is filled with the documentno of all the invoices created.
If many invoices are created, the variable can save all the documentno because the variable has lengh 2000, so you get an error. |
| Proposed Solution | -Show only the number of invoices created and not the documentno of all these invoices |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | has duplicate | design defect | 0013505 | | scheduled | dmiguelez | No of invoices created appear but the created invoice document numbers are not appearing |
|
| Attached Files |  create300orders.sql (1,358) 2010-05-27 12:50
https://issues.openbravo.com/file_download.php?file_id=2612&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2010-05-18 12:31 | networkb | New Issue | |
| 2010-05-18 12:31 | networkb | Assigned To | => adrianromero |
| 2010-05-18 12:35 | networkb | Severity | minor => major |
| 2010-05-18 13:06 | psarobe | Note Added: 0027415 | |
| 2010-05-18 13:06 | psarobe | Status | new => feedback |
| 2010-05-18 13:15 | networkb | Status | feedback => new |
| 2010-05-18 13:15 | networkb | Steps to Reproduce Updated | bug_revision_view_page.php?rev_id=380#r380 |
| 2010-05-18 13:32 | networkb | Proposed Solution updated | |
| 2010-05-18 13:49 | adrianromero | Note Added: 0027423 | |
| 2010-05-18 13:50 | adrianromero | Status | new => scheduled |
| 2010-05-18 13:50 | adrianromero | fix_in_branch | => pi |
| 2010-05-27 12:50 | networkb | Note Added: 0027775 | |
| 2010-05-27 12:50 | networkb | File Added: create300orders.sql | |
| 2010-06-02 17:56 | adrianromero | Relationship added | has duplicate 0013505 |
| 2010-06-09 14:14 | harikrishnan | Assigned To | adrianromero => harikrishnan |
| 2010-06-09 14:15 | hgbot | Checkin | |
| 2010-06-09 14:15 | hgbot | Note Added: 0028210 | |
| 2010-06-09 14:15 | hgbot | Status | scheduled => resolved |
| 2010-06-09 14:15 | hgbot | Resolution | open => fixed |
| 2010-06-09 14:15 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/7be8c400ed75de1aecd4d14d05bdbde26ac0c416 [^] |
| 2010-06-09 14:16 | harikrishnan | Note Added: 0028211 | |
| 2010-06-10 12:59 | hudsonbot | Checkin | |
| 2010-06-10 12:59 | hudsonbot | Note Added: 0028263 | |
| 2010-06-15 14:18 | arunkumar | Note Added: 0028445 | |
| 2010-06-15 14:18 | arunkumar | Status | resolved => closed |
| 2010-06-16 00:00 | anonymous | sf_bug_id | 0 => 3016763 |
|
Notes |
|
|
|
Hi,
Are you sure about the steps? Are you sure about the length of the variable? |
|
|
|
|
|
My proposal is to show the number of invoices created as suggested but also continue to show all document numbers created that fit in 2000 characters. I think that in the general case, when an small number of invoices is created, is good not to change the current behavior and show the document number of invoices created. |
|
|
|
|
|
An attach to create 300 orders with 5 lines each one has been added in order to anayze the problem |
|
|
|
(0028210)
|
|
hgbot
|
|
2010-06-09 14:15
|
|
Repository: erp/devel/pi
Changeset: 7be8c400ed75de1aecd4d14d05bdbde26ac0c416
Author: Harikrishnan Raja <harikrishnan.raja <at> openbravo.com>
Date: Wed Jun 09 17:44:00 2010 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/7be8c400ed75de1aecd4d14d05bdbde26ac0c416 [^]
Fixes issue 13364:The generate invoices process does not work when there are many orders so when many invoices are going to be created
---
M src-db/database/model/functions/C_INVOICE_CREATE.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
---
|
|
|
|
|
Steps to Test:
Prerequisite:
*Create 300 invoice using the attached sql file.
*Go to Generate Invoices under the sales management and execute for process.
*Now for 300 invoices its shows the success message for 10 invoice document no only.
Root Cause:
*The document no of all the 300 invoices then this exceeds 2000 length which is the size of v_message variable.
Impact:
*The condition is checked properly adding the message.Hence their is no impact in other areas. |
|
|
|
|
|
|
|
|
|