Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0013362Openbravo ERPZ. Otherspublic2010-05-18 12:112010-06-12 22:48
Reportershuehner 
Assigned Tosathiyan 
PriorityimmediateSeveritycriticalReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0013362: api check build 393 fails
DescriptionThis api check build fails:
http://builds.openbravo.com/job/erp_devel_pi-module-integrity-test/393/console [^]

 [checkAPI] 34843 ERROR - +++++++++++++++++++++++++++++++++++++++++++++++++++
 [checkAPI] 34847 ERROR - Errors in API model validation
 [checkAPI] 34852 ERROR - +++++++++++++++++++++++++++++++++++++++++++++++++++
 [checkAPI] 34859 ERROR - Check Constraint addition: table: C_BANKSTATEMENTLINE - Constraint: C_BANKSTATLN_PA_GLITEM_ID_CHK
Steps To Reproduce
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 00129292.50MP17 closed sathiyan in bank statement line allows select a debt payment and g/l item 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-05-18 12:11shuehnerNew Issue
2010-05-18 12:11shuehnerAssigned To => sathiyan
2010-05-18 12:11shuehnerOBNetwork customer => No
2010-05-18 12:13shuehnerRelationship addedrelated to 0012929
2010-05-18 14:50sathiyanNote Added: 0027429
2010-05-18 14:51sathiyanAssigned Tosathiyan => pjuvara
2010-05-18 15:11dalsasuaNote Added: 0027433
2010-05-18 15:22dalsasuaIssue Monitored: dalsasua
2010-05-18 20:43gorka_gilIssue Monitored: gorka_gil
2010-05-19 08:01pjuvaraStatusnew => scheduled
2010-05-19 08:01pjuvaraNote Added: 0027540
2010-05-19 08:01pjuvaraAssigned Topjuvara => sathiyan
2010-05-19 08:01pjuvarafix_in_branch => pi
2010-05-19 09:24hgbotCheckin
2010-05-19 09:24hgbotNote Added: 0027542
2010-05-19 09:24hgbotStatusscheduled => resolved
2010-05-19 09:24hgbotResolutionopen => fixed
2010-05-19 09:24hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/api-checks/rev/2056098543da1179fbbdd9e7ada6a39d99f1aa35 [^]
2010-05-19 11:48shuehnerNote Added: 0027553
2010-05-19 11:48shuehnerStatusresolved => closed
2010-05-20 00:00anonymoussf_bug_id0 => 3004344
2010-06-09 16:51hgbotCheckin
2010-06-09 16:51hgbotNote Added: 0028219
2010-06-12 22:48hudsonbotCheckin
2010-06-12 22:48hudsonbotNote Added: 0028322

Notes
(0027429)
sathiyan   
2010-05-18 14:50   
Hello Paolo,

The application should not allow that we select a debt payment and g/l item at same time in Financial Management || Receivables & Payables || Transactions || Bank Statement || Header - Line. So that I have added the following constraint.

<check name="C_BANKSTATLN_PA_GLITEM_ID_CHK"><![CDATA[((C_DEBT_PAYMENT_ID IS NOT NULL) AND (C_GLITEM_ID IS NULL)) OR (C_DEBT_PAYMENT_ID IS NULL)]]></check>

Could you please approve it?

Regards
Sathiyan.
(0027433)
dalsasua   
2010-05-18 15:11   
Sathiyan will also develop a build validation in order to check if it exists any row in database that doesn't fit the constraint, so update.database is not performed until data is correct.
(0027540)
pjuvara   
2010-05-19 08:01   
Exception approved.

Please publish an exception alert. Risk: medium.

In the alert, please specify instructions that end users can follow to correct any wrong data.
(0027542)
hgbot   
2010-05-19 09:24   
Repository: erp/devel/api-checks
Changeset: 2056098543da1179fbbdd9e7ada6a39d99f1aa35
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Wed May 19 09:26:17 2010 +0200
URL: http://code.openbravo.com/erp/devel/api-checks/rev/2056098543da1179fbbdd9e7ada6a39d99f1aa35 [^]

Fixed bug 13362: api check build 393

---
M model/model/tables/C_BANKSTATEMENTLINE.xml
---
(0027553)
shuehner   
2010-05-19 11:48   
api-change issue, build ok -> closing
(0028219)
hgbot   
2010-06-09 16:51   
Repository: erp/devel/pi
Changeset: 4ceee2f87eb902d2bfe39d6527e08c3f889ee746
Author: Sathiyan Sivaprakasam <sathiyan.sivaprakasam <at> openbravo.com>
Date: Wed Jun 09 20:21:03 2010 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/4ceee2f87eb902d2bfe39d6527e08c3f889ee746 [^]

error message has been changed for api issue 13362.

---
M src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/PaymentGLItemCheck.class
M src-util/buildvalidation/src/org/openbravo/buildvalidation/PaymentGLItemCheck.java
---
(0028322)
hudsonbot   
2010-06-12 22:48   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/4ceee2f87eb9 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/0b85119b92bc [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17589.obx [^]