Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0013315Openbravo ERPA. Platformpublic2010-05-13 15:532010-06-03 22:49
Reportershuehner 
Assigned Toalostale 
PriorityurgentSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Versionpi 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0013315: Confusing error message on CE when installing free module depending on newer (commercial) core
DescriptionWhen using a Community Instance and trying to install a free module (UI Selector Example) which depends on a newer core version (which is commercial) the installation stops with a message that an activation key is required (correct).

However:
The error message has some duplicated parts and fails to specify what part/module is commercial.
Steps To ReproduceHave erp with core version 2.50.16751 installed (or edit ad_module.version for ad_module_id='0' to have that version)

Then try to install the 'UI Selector Example' module (tested version 1.0.2) which depends on a newer core (>=MP15).

See attached screenshot for the wrong/confusing error message.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0013306 closed alostale Notification about pack / template being commercial while attempting to install it on a community instance is missing main point 
related to defect 00107732.50MP8 closed alostale Information shown when a module is not granted for installing is not correct 
related to defect 0013305 closed alostale Error popup showing result of CR dependency resolution has JS error 
related to defect 0013287 closed alostale When I install an obx file of Core, I get a null pointer exception error 
related to defect 0013414 closed shuehner In a community instance. Null pointer when trying to update a module 
Attached Filespng 13315.png (47,047) 2010-05-13 15:55
https://issues.openbravo.com/file_download.php?file_id=2556&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2010-05-13 15:53shuehnerNew Issue
2010-05-13 15:53shuehnerAssigned To => alostale
2010-05-13 15:55shuehnerNote Added: 0027205
2010-05-13 15:55shuehnerFile Added: 13315.png
2010-05-13 17:03pjuvaraNote Added: 0027208
2010-05-13 17:03pjuvaraPrioritynormal => urgent
2010-05-13 17:05pjuvaraNote Added: 0027209
2010-05-14 09:45alostaleRelationship addedrelated to 0013306
2010-05-14 09:45alostaleRelationship addedrelated to 0010773
2010-05-17 08:23alostaleRelationship addedrelated to 0013305
2010-05-17 08:24alostaleRelationship addedrelated to 0013287
2010-05-17 08:25alostaleStatusnew => scheduled
2010-05-17 16:25hgbotCheckin
2010-05-17 16:25hgbotNote Added: 0027371
2010-05-17 16:25hgbotStatusscheduled => resolved
2010-05-17 16:25hgbotResolutionopen => fixed
2010-05-17 16:25hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/5511763e80836f63a68164bed49a412c5d6cc527 [^]
2010-05-17 17:04hgbotCheckin
2010-05-17 17:04hgbotNote Added: 0027375
2010-05-17 17:04hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/5511763e80836f63a68164bed49a412c5d6cc527 [^] => http://code.openbravo.com/erp/devel/pi/rev/f985aad3ef14e8b18790b7120a2896cc21d297dc [^]
2010-05-19 13:18hgbotCheckin
2010-05-19 13:18hgbotNote Added: 0027556
2010-05-19 13:18hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/f985aad3ef14e8b18790b7120a2896cc21d297dc [^] => http://code.openbravo.com/erp/devel/pi/rev/6d330abd6826dcc9c5fdd9c00a0fbe21e7cfbc74 [^]
2010-05-19 16:55hgbotCheckin
2010-05-19 16:55hgbotNote Added: 0027563
2010-05-19 16:55hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/6d330abd6826dcc9c5fdd9c00a0fbe21e7cfbc74 [^] => http://code.openbravo.com/erp/devel/pi/rev/6a7a2295a014cf08b907f7f278c440791560f524 [^]
2010-05-19 17:53shuehnerNote Added: 0027567
2010-05-19 17:53shuehnerStatusresolved => closed
2010-05-20 00:00anonymoussf_bug_id0 => 3004341
2010-05-20 11:15hudsonbotCheckin
2010-05-20 11:15hudsonbotNote Added: 0027584
2010-05-20 11:15hudsonbotCheckin
2010-05-20 11:15hudsonbotNote Added: 0027586
2010-05-20 11:15hudsonbotCheckin
2010-05-20 11:15hudsonbotNote Added: 0027595
2010-05-20 11:16hudsonbotCheckin
2010-05-20 11:16hudsonbotNote Added: 0027596
2010-05-24 12:35hgbotCheckin
2010-05-24 12:35hgbotNote Added: 0027670
2010-05-24 12:35hgbotStatusclosed => resolved
2010-05-24 12:35hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/6a7a2295a014cf08b907f7f278c440791560f524 [^] => http://code.openbravo.com/erp/devel/pi/rev/0d4d27716b2af89f7ebe09e207ff37c85609ad14 [^]
2010-05-24 12:48shuehnerRelationship addedrelated to 0013414
2010-05-24 17:45shuehnerNote Added: 0027684
2010-05-24 17:45shuehnerStatusresolved => closed
2010-05-24 17:45shuehnerFixed in Version => pi
2010-06-03 22:49hudsonbotCheckin
2010-06-03 22:49hudsonbotNote Added: 0027918

Notes
(0027205)
shuehner   
2010-05-13 15:55   
This is especially important as for core a command line upgrade is possible which does not require to acquire a license.
(0027208)
pjuvara   
2010-05-13 17:03   
Upgrading priority as this is a significant issue. Please fix asap.
(0027209)
pjuvara   
2010-05-13 17:05   
Besides the wrong semantic of the message, there is also a grammar mistake:

It should be "The following module(s) are released under a commercial license that requires..."

The current version says "require" instead of "requires".
(0027371)
hgbot   
2010-05-17 16:25   
Repository: erp/devel/pi
Changeset: 5511763e80836f63a68164bed49a412c5d6cc527
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Mon May 17 16:25:17 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/5511763e80836f63a68164bed49a412c5d6cc527 [^]

fixed bug 13315: Confusing error message on CE installing community module depending on commercial one

---
M src/org/openbravo/erpCommon/ad_forms/ModuleManagement.java
---
(0027375)
hgbot   
2010-05-17 17:04   
Repository: erp/devel/pi
Changeset: f985aad3ef14e8b18790b7120a2896cc21d297dc
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Mon May 17 17:03:25 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/f985aad3ef14e8b18790b7120a2896cc21d297dc [^]

fixed bug 13315: Fix message installing commercial mods on community instances

---
M src/org/openbravo/erpCommon/ad_forms/ModuleManagement.java
M src/org/openbravo/erpCommon/ad_forms/ModuleManagement_ErrorCommercial.html
---
(0027556)
hgbot   
2010-05-19 13:18   
Repository: erp/devel/pi
Changeset: 6d330abd6826dcc9c5fdd9c00a0fbe21e7cfbc74
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed May 19 13:18:08 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/6d330abd6826dcc9c5fdd9c00a0fbe21e7cfbc74 [^]

fixed bug 13315: fixed message

---
M src/org/openbravo/erpCommon/ad_forms/ModuleManagement.java
---
(0027563)
hgbot   
2010-05-19 16:55   
Repository: erp/devel/pi
Changeset: 6a7a2295a014cf08b907f7f278c440791560f524
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed May 19 16:54:52 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/6a7a2295a014cf08b907f7f278c440791560f524 [^]

fixed bug 13315: fixed message when installing from obx

---
M src/org/openbravo/erpCommon/ad_forms/ModuleManagement.java
---
(0027567)
shuehner   
2010-05-19 17:53   
Tested on pi/pgsql, working fine now.
Testing on both community and activated instances:
- install from obx, commercial update to installed module (core), commercial not yet installed module
- installing community module
- install community module
- install commercial module not depending on other commercial mdules
- install commercial module depending on other commercial module
- install commercial module depending on other commercial module needed to be upgraded (i.e. core)
- install community module depending on commercial module needed to be upgraded (core): original defect here
(0027584)
hudsonbot   
2010-05-20 11:15   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/5511763e8083 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/a7901e097e1a [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17407.obx [^]
(0027586)
hudsonbot   
2010-05-20 11:15   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/f985aad3ef14 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/a7901e097e1a [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17407.obx [^]
(0027595)
hudsonbot   
2010-05-20 11:15   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/6d330abd6826 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/a7901e097e1a [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17407.obx [^]
(0027596)
hudsonbot   
2010-05-20 11:16   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/6a7a2295a014 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/a7901e097e1a [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17407.obx [^]
(0027670)
hgbot   
2010-05-24 12:35   
Repository: erp/devel/pi
Changeset: 0d4d27716b2af89f7ebe09e207ff37c85609ad14
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Mon May 24 12:35:09 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/0d4d27716b2af89f7ebe09e207ff37c85609ad14 [^]

fixed bug 13315: prevent NPE

---
M src/org/openbravo/erpCommon/ad_forms/ModuleManagement.java
---
(0027684)
shuehner   
2010-05-24 17:45   
(Re) tested on pi/pgsql, for notes about tests done see linked issue 13414
(0027918)
hudsonbot   
2010-06-03 22:49   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/0d4d27716b2a [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/c011484a38d9 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17407.obx [^]