Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0013303Openbravo ERPA. Platformpublic2010-05-12 12:252010-05-18 21:44
Reporteralostale 
Assigned Toalostale 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0013303: NPE when intalling commercial module in community instance
DescriptionWhen trying to install a commercial module in a Community instance a NPE message appear in after clicking the install button. It should appear a message saying the module is commercial and cannot be installed in that instance and a link to how to acquire a subscription.

When continuing the process, in the last step this message is shown:

Error:
Commercial modules installation is not allowed in a Community Edition Instance.Accruals and Deferrals
Steps To Reproduce
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-05-12 12:25alostaleNew Issue
2010-05-12 12:25alostaleAssigned To => alostale
2010-05-12 12:37hgbotCheckin
2010-05-12 12:37hgbotNote Added: 0027168
2010-05-12 12:37hgbotStatusnew => resolved
2010-05-12 12:37hgbotResolutionopen => fixed
2010-05-12 12:37hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/2fe0d70fbe073ddb5d5a749adbc543a22a4dee59 [^]
2010-05-12 17:11shuehnerNote Added: 0027176
2010-05-13 13:03shuehnerNote Added: 0027195
2010-05-13 13:03shuehnerNote Added: 0027196
2010-05-13 13:03shuehnerStatusresolved => closed
2010-05-14 00:00anonymoussf_bug_id0 => 3001315
2010-05-18 21:44hudsonbotCheckin
2010-05-18 21:44hudsonbotNote Added: 0027516

Notes
(0027168)
hgbot   
2010-05-12 12:37   
Repository: erp/devel/pi
Changeset: 2fe0d70fbe073ddb5d5a749adbc543a22a4dee59
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed May 12 12:37:15 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/2fe0d70fbe073ddb5d5a749adbc543a22a4dee59 [^]

fixed bug 13303: NPE when intalling commercial module in community instance

---
M src/org/openbravo/erpCommon/ad_forms/ModuleManagement_ErrorCommercial.html
M src/org/openbravo/erpCommon/obps/ActivationKey.java
---
(0027176)
shuehner   
2010-05-12 17:11   
Review & testing done:
- Verify intended change (NPE does not appear anymore, a useful error message appears)
- Verify usage of all changes going back all call-tree for assumption (Community edition aka instanceProperties == null) and verify behaviour by reviewing/reading code.
(0027195)
shuehner   
2010-05-13 13:03   
Additional testing splitted with qa-team and me:
-Install/upgrade community/commercial modules in both community+activated instance
-testing of behaviour of converted licenses
-testing of behaviour of valid license with expired subscription for a module
(0027196)
shuehner   
2010-05-13 13:03   
Closing after review+testing done which is described in the last two notes.
(0027516)
hudsonbot   
2010-05-18 21:44   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/2fe0d70fbe07 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/aa11838d5f80 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17380.obx [^]