0013281: [REST] when inserting an object through REST allow setting the organization through xml

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0013281

Openbravo ERP

A. Platform

public

2010-05-11 06:49

2010-05-18 21:44

Reporter

mtaal

Assigned To

mtaal

Priority

normal

Severity

major

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

2.50MP17

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0013281: [REST] when inserting an object through REST allow setting the organization through xml

Description

When a new object is passed in through a POST REST request the client/org are always set to the current client/org of the user. This eventhough the xml may contain a valid organization (for the current client of the user and accessible for the user).

For example, for sales orders a user can choose the organization in the sales order entry. The same should be allowed through REST.

Steps To Reproduce

1) set the default role to Openbravo Admin but with organization 0 (*)
2) upload through REST (and a POST request) the attached order xml
3) you will get an error:
<ob:error xmlns:ob="http://www.openbravo.com"><message>org.openbravo.service.web.InvalidContentException: [^] Object Order(null) is new but not writable
Caused by: Object Order(null) is new but not writable</message></ob:error>

Proposed Solution

Allow setting the organization through REST if it is a valid/writable organization for the user.

Changes: see the XMLEntityConverter:
1) this has to be moved to after setting all many-to-one properties:

      if (!writable && bob.isNewOBObject()) {
        error("Object " + entityName + "(" + id + ") is new but not writable");
        return bob;
      }
2) This has to be changed to check if the org is a valid/writable org for the user:

          final boolean orgUpdate = bob instanceof OrganizationEnabled
              && p.getName().equals(Client.PROPERTY_ORGANIZATION);
          if (!isOptionClientImport() && currentValue != null && (clientUpdate || orgUpdate)) {

Additional Information

Tags

No tags attached.

Relationships

related to

defect

0013283

2.50MP17

closed

mtaal

[REST] use organization of the object to retrieved referenced objects

Attached Files