Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0013156Openbravo ERP02. Master data managementpublic2010-04-29 10:202010-05-26 00:00
Reporternetworkb 
Assigned Toadrianromero 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version2.50MP14 
Target Version2.50MP17Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0013156: C_ValidCombination_Get does not work properly
DescriptionThis function is not working properly, when inserting new Journal Entries (using IDL module).

If more than two records are imported, with same account but diferent products, or BP, only the first validcombination is inserted.

When C_ValidCombination_Get is called, with an account, its valid combination is created. However, if same function is called with same account, and a product, function returns the first valid combination.

And that is not correct. It should create a new one for account + product.
Steps To Reproduce(Note: IDL module must be installed)

Import csv attached.

Then, test in database that only one accounting combination is created:

select * from c_validcombination order by created desc
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filescsv Nat3.csv (836) 2010-04-29 10:20
https://issues.openbravo.com/file_download.php?file_id=2500&type=bug
Issue History
Date ModifiedUsernameFieldChange
2010-04-29 10:20networkbNew Issue
2010-04-29 10:20networkbAssigned To => adrianromero
2010-04-29 10:20networkbFile Added: Nat3.csv
2010-04-29 10:20networkbOBNetwork customer => Yes
2010-04-29 10:27networkbSummaryC_GetValidCombination does not work properly => C_ValidCombination_Get does not work properly
2010-04-29 10:27networkbDescription Updatedbug_revision_view_page.php?rev_id=295#r295
2010-05-04 13:30adrianromeroStatusnew => scheduled
2010-05-05 17:54hgbotCheckin
2010-05-05 17:54hgbotNote Added: 0026963
2010-05-05 17:54hgbotStatusscheduled => resolved
2010-05-05 17:54hgbotResolutionopen => fixed
2010-05-05 17:54hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/df3237be3b3fbcec2ad414de3922b28046b15be4 [^]
2010-05-05 18:00adrianromeroNote Added: 0026964
2010-05-11 18:19jpabloaeTarget Version2.50MP16 => 2.50MP17
2010-05-18 21:43hudsonbotCheckin
2010-05-18 21:43hudsonbotNote Added: 0027484
2010-05-25 18:52eduardo_ArgalNote Added: 0027733
2010-05-25 18:52eduardo_ArgalStatusresolved => closed
2010-05-26 00:00anonymoussf_bug_id0 => 3007108

Notes
(0026963)
hgbot   
2010-05-05 17:54   
Repository: erp/devel/pi
Changeset: df3237be3b3fbcec2ad414de3922b28046b15be4
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Wed May 05 17:53:12 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/df3237be3b3fbcec2ad414de3922b28046b15be4 [^]

Fixes issue 0013156: C_ValidCombination_Get does not work properly

---
M src-db/database/model/functions/C_VALIDCOMBINATION_GET.xml
---
(0026964)
adrianromero   
2010-05-05 18:00   
# Testing of the issue:
To test the issue just follow the steps to test and verify that an accounting combination is created for each product
# Explanation of the changeset that fixes the issue:
It has been modified the SQL filter in the C_VALIDCOMBINATION_GET procedure that verifies it already exists a valid combination for the required accounting dimensions. This filter was wrong because it the accounting dimension to verify was null and already existed a valid combination with that accounting dimension not null it returned it and this is wrong.
# Other areas affected by the changeset:
All other procedures that invoked the C_VALIDCOMBINATION_GET are affected by this change. But the logic modified is only related to this procedure so the fix is correct for all.
(0027484)
hudsonbot   
2010-05-18 21:43   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/df3237be3b3f [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/aa11838d5f80 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17380.obx [^]
(0027733)
eduardo_Argal   
2010-05-25 18:52   
ok