Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0013135Openbravo ERPA. Platformpublic2010-04-27 14:592010-05-15 00:00
Reportershuehner 
Assigned Tomtaal 
PriorityurgentSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Versionpi 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0013135: OBContext.getLanguage() returns 'wrong' language, if user does not have a default language set
DescriptionWith two system languages active (en_US + es_ES) the getLanguage() call did return es_ES as a language, even if no user had set his language to es_ES.

Caused by getLanguage fallback code not using the system-client language in case no user-default language is set.
Steps To Reproducesee steps to reproduce in issue 12768
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0012768 closed shuehner Data audit window shows record changes in the wrong language 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-04-27 14:59shuehnerNew Issue
2010-04-27 14:59shuehnerAssigned To => mtaal
2010-04-27 14:59shuehnerRelationship addedblocks 0012768
2010-04-27 22:32hgbotCheckin
2010-04-27 22:32hgbotNote Added: 0026734
2010-04-27 22:32hgbotStatusnew => resolved
2010-04-27 22:32hgbotResolutionopen => fixed
2010-04-27 22:32hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/d61ce2cd289253212f817a70cc3eb57e103efbce [^]
2010-05-14 12:16shuehnerNote Added: 0027236
2010-05-14 12:16shuehnerStatusresolved => closed
2010-05-14 12:16shuehnerFixed in Version => pi
2010-05-14 15:28hudsonbotCheckin
2010-05-14 15:28hudsonbotNote Added: 0027304
2010-05-15 00:00anonymoussf_bug_id0 => 3001856

Notes
(0026734)
hgbot   
2010-04-27 22:32   
Repository: erp/devel/pi
Changeset: d61ce2cd289253212f817a70cc3eb57e103efbce
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Apr 27 22:32:28 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/d61ce2cd289253212f817a70cc3eb57e103efbce [^]

fixes issue 13135: OBContext.getLanguage() returns 'wrong' language, if user does not have a default language set
fixes issue 13136: OBContext.getLanguage does only use users' default language, and does not honor language change in the role change popup

---
M src-test/org/openbravo/test/dal/IssuesTest.java
M src/org/openbravo/base/secureApp/LoginUtils.java
M src/org/openbravo/dal/core/OBContext.java
---
(0027236)
shuehner   
2010-05-14 12:16   
Tested in pi/pgsql, rev: da4cfb0dabc7. Code-change reviewed, now using the system client language instead of the old fallback code. Tested using 'Audit Trail' popup as its translation of labels inside the grid is using the ObContext.getLanguage to retrieve the language to use. -> Working fine.
(0027304)
hudsonbot   
2010-05-14 15:28   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/d61ce2cd2892 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/36f76c8d7193 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17198.obx [^]