0013068: ComboReloadsProcessHelper.printPage can reach the 64k method size limitation

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0013068

Openbravo ERP

A. Platform

public

2010-04-22 10:06

2010-06-15 14:03

Reporter

alostale

Assigned To

alostale

Priority

urgent

Severity

major

Reproducibility

sometimes

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

2.50MP17

Merge Request Status

Review Assigned To

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0013068: ComboReloadsProcessHelper.printPage can reach the 64k method size limitation

Description

JVM specification states:

"The amount of code per non-native, non-abstract method is limited to 65536 bytes by the sizes of the indices in the exception_table of the Code attribute (§4.7.3), in the LineNumberTable attribute (§4.7.8), and in the LocalVariableTable attribute (§4.7.9)." [1]

This limitation of 64k in a method can be reached in the combo reloads for processes in case the number of processes/parameters is big enough, since there is a single method where all the logic for all the combo reloads for all the parameters in all the generated processes is implemented.

---
[1] http://java.sun.com/docs/books/jvms/second_edition/html/ClassFile.doc.html#88659 [^]

Steps To Reproduce

This issue it is difficult to reproduce (even though there is a customer suffering it). It is necessary to register in AD an amount of generated UI processes with combo parameters big enough to make the org.openbravo.erpCommon.ad_callouts.ComboReloadsProcessHelper.printPage method to exceed the 64k limit.

Proposed Solution

Two actions will be taken to solve this issue:

1. Generate a method per process instead of a single one for all the processes. printPage method should only call these new methods.
2. Currently combo reload code is generated for all parameters with combo references. This is because in general windows it is required because apart of validation, organization (which is in all windows) can affect the contents of a combo, but it is not needed for processes in case the process does not have a organization field. So if the combo has not organization field, the code for reloads will be generated only for the parameters with validation.

Additional Information