Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0013048Openbravo ERPZ. Otherspublic2010-04-20 10:232010-04-21 10:43
Reportershuehner 
Assigned Togorkaion 
PriorityimmediateSeveritycriticalReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0013048: api check build 361 fails
Descriptionhttp://builds.openbravo.com/job/erp_devel_pi-module-integrity-test/361/console [^]

Errors:

org.openbravo.erpCommon.ad_process:
Bad
method org.openbravo.erpCommon.ad_process.PaymentMonitor.updateInvoice(org.openbravo.model.common.invoice.Invoice): doesn't throw org.openbravo.erpCommon.utility.PropertyException in api-checks/java/reference/250, but throws org.openbravo.erpCommon.utility.PropertyException in /var/www/localhost/htdocs/japi/361

org.openbravo.erpCommon.utility:
Bad
method org.openbravo.erpCommon.utility.Utility.getPropertyValue(java.lang.String, java.lang.String, java.lang.String): doesn't throw org.openbravo.erpCommon.utility.PropertyException in api-checks/java/reference/250, but throws org.openbravo.erpCommon.utility.PropertyException in /var/www/localhost/htdocs/japi/361
Steps To Reproduce
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0013042 closed gorkaion Utility.getPropertyValue raises expected exception as IllegalStateException (sublcass of RuntimeException) 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-04-20 10:23shuehnerNew Issue
2010-04-20 10:23shuehnerAssigned To => gorkaion
2010-04-20 10:23shuehnerOBNetwork customer => No
2010-04-20 10:23shuehnerRelationship addedrelated to 0013042
2010-04-20 10:24shuehnerNote Added: 0026505
2010-04-20 10:28jpabloaeIssue Monitored: jpabloae
2010-04-20 10:30hgbotCheckin
2010-04-20 10:30hgbotNote Added: 0026506
2010-04-20 11:55hgbotCheckin
2010-04-20 11:55hgbotNote Added: 0026511
2010-04-20 11:55hgbotStatusnew => resolved
2010-04-20 11:55hgbotResolutionopen => fixed
2010-04-20 11:55hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/api-checks/rev/34d646b416fb0cc603dbc1d78685c32c46c6aff5 [^]
2010-04-20 16:05gorkaionStatusresolved => closed
2010-04-21 00:00anonymoussf_bug_id0 => 2990141
2010-04-21 10:43hudsonbotCheckin
2010-04-21 10:43hudsonbotNote Added: 0026529

Notes
(0026505)
shuehner   
2010-04-20 10:24   
The first problem will be resolved by changing the code in pi to avoid changing the api.

The second one is a false positive, as the method involved is new and was never published in any MP.
(0026506)
hgbot   
2010-04-20 10:30   
Repository: erp/devel/pi
Changeset: b5f915fde1b458d55d8ce0a923700490ebecbbe2
Author: Gorka Ion Damián <gorkaion.damian <at> openbravo.com>
Date: Tue Apr 20 10:44:30 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/b5f915fde1b458d55d8ce0a923700490ebecbbe2 [^]

Related to issue 13048. Changed done to avoid api break on updateInvoice method.

---
M src/org/openbravo/erpCommon/ad_actionButton/InvoicePaymentMonitor.java
M src/org/openbravo/erpCommon/ad_process/PaymentMonitor.java
M src/org/openbravo/erpCommon/ad_process/PaymentMonitorProcess.java
---
(0026511)
hgbot   
2010-04-20 11:55   
Repository: erp/devel/api-checks
Changeset: 34d646b416fb0cc603dbc1d78685c32c46c6aff5
Author: Gorka Ion Damián <gorkaion.damian <at> openbravo.com>
Date: Tue Apr 20 12:05:56 2010 +0200
URL: http://code.openbravo.com/erp/devel/api-checks/rev/34d646b416fb0cc603dbc1d78685c32c46c6aff5 [^]

Fixes issue 13048. Ack as false positive. Change on new method.

---
M java/reference/250.japi.gz
---
(0026529)
hudsonbot   
2010-04-21 10:43   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/b5f915fde1b4 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/6aaf8711c872 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17101.obx [^]