Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0013039Openbravo ERP03. Procurement managementpublic2010-04-19 14:592012-05-25 12:13
albertobg 
mirurita 
normalminoralways
closedfixed 
5
2.50MP14 
3.0MP12 
Core
No
0013039: Callout SL_RequisitionLine_Amt gets the standard and price precision from data in header instead of lines
Callout SL_RequisitionLine_Amt gets the standard precision and price precision using the select method in SL_RequisitionLine_Amt_data.xsql.
This query joins only with M_Requisition (M_Requisition.M_PriceList_ID)
It is possible to specify the pricelist at line level, so it should join first with M_RequisitionLine (M_RequisitionLine.M_PriceList_ID) and, if not found, then try with M_Requisition.
VMA-Reviewed
related to defect 0013955 closed naiaramartinez Requisition: When pricelist information is added to the header after the line was added, the prices do not get applied in line 
Issue History
2010-04-19 14:59albertobgNew Issue
2010-04-19 14:59albertobgAssigned To => adrianromero
2010-08-24 22:39fgredruelloIssue Monitored: fgredruello
2011-06-03 10:59dalsasuaAssigned Toadrianromero => dalsasua
2011-07-20 18:12dalsasuaAssigned Todalsasua => jonalegriaesarte
2011-09-16 12:02psarobeStatusnew => scheduled
2011-09-16 12:02psarobeFixed in Version => 3.0MP9
2012-02-15 19:04iciordiaAssigned Tojonalegriaesarte => vmromanos
2012-02-16 16:13vmromanosTag Attached: VMA-Reviewed
2012-02-16 16:13vmromanosRelationship addedrelated to 0013955
2012-05-10 12:13gorka_gilAssigned Tovmromanos => mirurita
2012-05-14 11:43naiaramartinezNote Added: 0048610
2012-05-18 19:44hgbotCheckin
2012-05-18 19:44hgbotNote Added: 0048778
2012-05-18 19:44hgbotStatusscheduled => resolved
2012-05-18 19:44hgbotResolutionopen => fixed
2012-05-18 19:44hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/65fa9fad25ccf98334937f7f8afa20f41dc303e0 [^]
2012-05-18 19:44hgbotCheckin
2012-05-18 19:44hgbotNote Added: 0048779
2012-05-18 19:45miruritaNote Added: 0048780
2012-05-18 19:45miruritaStatusresolved => closed
2012-05-18 19:45miruritaFixed in Version3.0MP9 => 3.0MP12
2012-05-25 12:13hudsonbotCheckin
2012-05-25 12:13hudsonbotNote Added: 0049171
2012-05-25 12:13hudsonbotCheckin
2012-05-25 12:13hudsonbotNote Added: 0049172

Notes
(0048610)
naiaramartinez   
2012-05-14 11:43   
Test Plan:

  Go to currency window and create a new record. Fill Standard Precision, costing precision and price precision with 1.

  Go to Requisition window
  Create new header. Select a pricelist
  Go to lines tab and create a new record. Fill price list field and save it. The price list field have to be different of header's price list.

  Navigate to line's price list. Change this price list's currency, and set previosly created one.

  Go back to the Requisition line and change the product. Notice that Line net amount is showing with 1 decimal.
(0048778)
hgbot   
2012-05-18 19:44   
Repository: erp/devel/pi
Changeset: 65fa9fad25ccf98334937f7f8afa20f41dc303e0
Author: Naiara Martinez <naiara.martinez <at> openbravo.com>
Date: Fri May 18 13:59:45 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/65fa9fad25ccf98334937f7f8afa20f41dc303e0 [^]

fixed bug 13039 get standard and price precision from data in lines. If data
is null it gets from header.

---
M src/org/openbravo/erpCommon/ad_callouts/SL_RequisitionLine_Amt.java
M src/org/openbravo/erpCommon/ad_callouts/SL_RequisitionLine_Amt_data.xsql
---
(0048779)
hgbot   
2012-05-18 19:44   
Repository: erp/devel/pi
Changeset: f531a3011f716677690fdfe6d09d43605596ada5
Author: Mikel Irurita <mikel.irurita <at> openbravo.com>
Date: Fri May 18 19:43:48 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/f531a3011f716677690fdfe6d09d43605596ada5 [^]

Related to issue 13039: remove not needed if condition.
getStringParameter(String parameter) calls to getStringParameter(parameter, "", null)
where default value in case of null is an empty string "" (second parameter).

---
M src/org/openbravo/erpCommon/ad_callouts/SL_RequisitionLine_Amt.java
---
(0048780)
mirurita   
2012-05-18 19:45   
code review + testing OK
(0049171)
hudsonbot   
2012-05-25 12:13   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5401e185a8b0 [^]

Maturity status: Test
(0049172)
hudsonbot   
2012-05-25 12:13   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5401e185a8b0 [^]

Maturity status: Test