Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0013023Openbravo ERP02. Master data managementpublic2010-04-16 13:152010-05-18 21:43
networkb 
harikrishnan 
urgentmajoralways
closedfixed 
5
2.40MP12 
2.40MP13 
Core
No
0013023: When completing or processing documents the updatedby column is not updated properly
 When you completing or processing documents the updatedby columns is not updated properly.

We have identify this problem on the following documents:

-Requisition
-Manage requisition
-Goods receipt/shipment
-Goods movement
-manual settlement
-Invoice (bug fixed: 0012520)
-Cash Journal
-Bank statement


-Create a document with one user
-Process or complete with other user
See that the updatedby is not properly updated.
All the documents should be reviewed because the could be an horizontal problem
that affect other documents.
No tags attached.
related to defect 00125202.40MP13 closed harikrishnan When you complete a sales invoice the database is not updated properly 
depends on backport 00130242.40MP13 closed harikrishnan When completing or processing documents the updatedby column is not updated properly 
has duplicate defect 00130212.40MP13 closed adrianromero When you process a cash journal the database is not updated properly 
has duplicate defect 00130332.40MP13 closed adrianromero The create shipment from order process does not fill well the audit fields. 
related to defect 00130312.40MP13 closed sivaraman The shipment and invoice created after complete a POS Order have wrong data in the createdby and updatedby fields 
Issue History
2010-04-16 13:15networkbNew Issue
2010-04-16 13:15networkbAssigned To => adrianromero
2010-04-16 13:15networkbSummaryWhen you completing or processing documents the updatedby columns is not updated properly => When completing or processing documents the updatedby column is not updated properly
2010-04-16 13:29networkbProposed Solution updated
2010-04-16 15:34adrianromeroRelationship addedhas duplicate 0013021
2010-04-16 15:35adrianromeroStatusnew => scheduled
2010-04-16 15:35adrianromerofix_in_branch => pi
2010-04-16 15:36adrianromeroIssue cloned0013024
2010-04-16 15:36adrianromeroRelationship addeddepends on 0013024
2010-04-16 15:40adrianromeroRelationship addedrelated to 0012520
2010-04-20 09:57adrianromeroRelationship addedrelated to 0013031
2010-04-20 09:59adrianromeroRelationship addedrelated to 0013033
2010-04-20 18:23networkbfix_in_branchpi =>
2010-04-20 18:23networkbDescription Updatedbug_revision_view_page.php?rev_id=248#r248
2010-04-21 10:31networkbDescription Updatedbug_revision_view_page.php?rev_id=249#r249
2010-05-04 11:31harikrishnanAssigned Toadrianromero => harikrishnan
2010-05-04 11:46hgbotCheckin
2010-05-04 11:46hgbotNote Added: 0026908
2010-05-04 11:46hgbotStatusscheduled => resolved
2010-05-04 11:46hgbotResolutionopen => fixed
2010-05-04 11:46hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/24838b8cf6a79cb24bff22805f9527622cd6da2d [^]
2010-05-04 11:47harikrishnanNote Added: 0026909
2010-05-04 12:37adrianromeroRelationship replacedhas duplicate 0013033
2010-05-14 13:10arunkumarNote Added: 0027248
2010-05-14 13:10arunkumarStatusresolved => closed
2010-05-15 00:00anonymoussf_bug_id0 => 3001855
2010-05-18 21:43hudsonbotCheckin
2010-05-18 21:43hudsonbotNote Added: 0027479

Notes
(0026908)
hgbot   
2010-05-04 11:46   
Repository: erp/devel/pi
Changeset: 24838b8cf6a79cb24bff22805f9527622cd6da2d
Author: Harikrishnan Raja <harikrishnan.raja <at> openbravo.com>
Date: Tue May 04 15:16:13 2010 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/24838b8cf6a79cb24bff22805f9527622cd6da2d [^]

Fixes Issue 13023: When completing or processing documents the updated-by column is not updated properly.

---
M src-db/database/model/functions/C_BANKSTATEMENT_POST.xml
M src-db/database/model/functions/C_CASH_POST.xml
M src-db/database/model/functions/C_SETTLEMENT_POST.xml
M src-db/database/model/functions/M_INOUT_CREATE.xml
M src-db/database/model/functions/M_INOUT_CREATEINVOICE.xml
M src-db/database/model/functions/M_INOUT_POST.xml
M src-db/database/model/functions/M_REQUISITIONLINE_STATUS.xml
M src-db/database/model/functions/M_REQUISITION_CREATEPO.xml
M src-db/database/model/functions/M_REQUISITION_POST.xml
---
(0026909)
harikrishnan   
2010-05-04 11:47   
Steps to test:
*Create two new user.
    1.UserA
    2.userB
*Login as UserA
*Create new record in each above mentioned section(Don't complete it or process it)
*Login as UserB and complete all the record above created.


Root cause & solution:
Audit fields are not properly updated.Hence the user id is taken from the pinstance table and used in update and insert statement.

Impact:
These are the files that are affected by this fix.
    1.C_INVOICE_POST.xml
    2.C_DEBT_PAYMENT_CREATE.xml
    3.C_DP_MANAGEMENT_POST.xml
    4.C_PAYINADVANCE_CREATE.xml
    5.C_REMITTANCE_POST.xml
    6.C_TAXPAYMENT_POST.xml
    7.C_INVOICE_CREATERECEIPT.xml
    8.C_ORDER_POST1.xml
    9.M_INOUT_CREATE.xml
    10.M_INOUT_CREATEINVOICE.xml
    11.M_REQUISITION_CREATEPO.xml
    12.M_REQUISITION_POST
    13.M_REQUISITIONLINE_STATUS.xml
(0027248)
arunkumar   
2010-05-14 13:10   
Tested working fine
(0027479)
hudsonbot   
2010-05-18 21:43   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/24838b8cf6a7 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/aa11838d5f80 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17380.obx [^]