Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0012918Openbravo ERPA. Platformpublic2010-04-09 10:162010-04-19 21:13
mtaal 
mtaal 
normalmajorhave not tried
closedfixed 
5
pi 
pi 
Core
No
0012918: DAL: Exception in commitTransaction leaves Postgres connection in illegal state
When an exception occurs when committing a transaction through the DAL the transaction is not rolledback. This leaves the connection in an illegal state which results in errors when the connection is re-used. See the stack trace below.



org.hibernate.exception.GenericJDBCException: could not load an entity: [ADUser#1000000]
    at org.hibernate.exception.SQLStateConverter.handledNonSpecificException(SQLStateConverter.java:103)
    at org.hibernate.exception.SQLStateConverter.convert(SQLStateConverter.java:91)
    at org.hibernate.exception.JDBCExceptionHelper.convert(JDBCExceptionHelper.java:43)
    at org.hibernate.loader.Loader.loadEntity(Loader.java:1874)
    at org.hibernate.loader.entity.AbstractEntityLoader.load(AbstractEntityLoader.java:48)
    at org.hibernate.loader.entity.AbstractEntityLoader.load(AbstractEntityLoader.java:42)
    at org.hibernate.loader.entity.BatchingEntityLoader.load(BatchingEntityLoader.java:82)
    at org.hibernate.persister.entity.AbstractEntityPersister.load(AbstractEntityPersister.java:3044)
    at org.hibernate.event.def.DefaultLoadEventListener.loadFromDatasource(DefaultLoadEventListener.java:395)
    at org.hibernate.event.def.DefaultLoadEventListener.doLoad(DefaultLoadEventListener.java:375)
    at org.hibernate.event.def.DefaultLoadEventListener.load(DefaultLoadEventListener.java:139)
    at org.hibernate.event.def.DefaultLoadEventListener.proxyOrLoad(DefaultLoadEventListener.java:195)
    at org.hibernate.event.def.DefaultLoadEventListener.onLoad(DefaultLoadEventListener.java:103)
    at org.hibernate.impl.SessionImpl.fireLoad(SessionImpl.java:878)
    at org.hibernate.impl.SessionImpl.get(SessionImpl.java:815)
    at org.openbravo.dal.core.SessionHandler.find(SessionHandler.java:180)
    at org.openbravo.dal.core.SessionHandler.find(SessionHandler.java:163)
    at org.openbravo.dal.core.OBContext.initialize(OBContext.java:509)
    at org.openbravo.dal.core.OBContext.setOBContext(OBContext.java:220)
    at org.openbravo.test.base.BaseTest.setBigBazaarUserContext(BaseTest.java:117)
    at org.openbravo.test.base.BaseTest.setUp(BaseTest.java:70)
    at junit.framework.TestCase.runBare(TestCase.java:132)
    at junit.framework.TestResult$1.protect(TestResult.java:110)
    at junit.framework.TestResult.runProtected(TestResult.java:128)
    at junit.framework.TestResult.run(TestResult.java:113)
    at junit.framework.TestCase.run(TestCase.java:124)
    at junit.framework.TestSuite.runTest(TestSuite.java:232)
    at junit.framework.TestSuite.run(TestSuite.java:227)
    at org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:91)
    at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:46)
    at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
    at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:467)
    at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:683)
    at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:390)
    at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:197)
Caused by: org.postgresql.util.PSQLException: ERROR: current transaction is aborted, commands ignored until end of transaction block
    at org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse(QueryExecutorImpl.java:1548)
    at org.postgresql.core.v3.QueryExecutorImpl.processResults(QueryExecutorImpl.java:1316)
    at org.postgresql.core.v3.QueryExecutorImpl.execute(QueryExecutorImpl.java:191)
    at org.postgresql.jdbc2.AbstractJdbc2Statement.execute(AbstractJdbc2Statement.java:452)
    at org.postgresql.jdbc2.AbstractJdbc2Statement.executeWithFlags(AbstractJdbc2Statement.java:351)
    at org.postgresql.jdbc2.AbstractJdbc2Statement.executeQuery(AbstractJdbc2Statement.java:255)
    at org.hibernate.jdbc.AbstractBatcher.getResultSet(AbstractBatcher.java:186)
    at org.hibernate.loader.Loader.getResultSet(Loader.java:1787)
    at org.hibernate.loader.Loader.doQuery(Loader.java:674)
    at org.hibernate.loader.Loader.doQueryAndInitializeNonLazyCollections(Loader.java:236)
    at org.hibernate.loader.Loader.loadEntity(Loader.java:1860)
    ... 31 more
No tags attached.
Issue History
2010-04-09 10:16mtaalNew Issue
2010-04-09 10:16mtaalAssigned To => mtaal
2010-04-09 21:00hgbotCheckin
2010-04-09 21:00hgbotNote Added: 0026048
2010-04-09 21:00hgbotStatusnew => resolved
2010-04-09 21:00hgbotResolutionopen => fixed
2010-04-09 21:00hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/b535611b23943a3acc30fb2dd0287e77f176ccca [^]
2010-04-15 13:08hgbotCheckin
2010-04-15 13:08hgbotNote Added: 0026251
2010-04-15 13:09iperdomoNote Added: 0026252
2010-04-15 13:09iperdomoStatusresolved => closed
2010-04-16 00:00anonymoussf_bug_id0 => 2987981
2010-04-19 21:13hudsonbotCheckin
2010-04-19 21:13hudsonbotNote Added: 0026448
2010-04-19 21:13hudsonbotCheckin
2010-04-19 21:13hudsonbotNote Added: 0026487

Notes
(0026048)
hgbot   
2010-04-09 21:00   
Repository: erp/devel/pi
Changeset: b535611b23943a3acc30fb2dd0287e77f176ccca
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Fri Apr 09 21:11:28 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/b535611b23943a3acc30fb2dd0287e77f176ccca [^]

fixes issue 12918: DAL: Exception in commitTransaction leaves Postgres connection in illegal state

---
M src/org/openbravo/dal/core/SessionHandler.java
---
(0026251)
hgbot   
2010-04-15 13:08   
Repository: erp/devel/pi
Changeset: 90e107951e847ef35c0f9208ef60c9ed3fdfc896
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Thu Apr 15 13:20:50 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/90e107951e847ef35c0f9208ef60c9ed3fdfc896 [^]

Added test case for issue 12918

---
M src-test/org/openbravo/test/dal/IssuesTest.java
---
(0026252)
iperdomo   
2010-04-15 13:09   
Tested on PI @ rev 90e107951e84
(0026448)
hudsonbot   
2010-04-19 21:13   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/b535611b2394 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/91d98bda46c1 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17088.obx [^]
(0026487)
hudsonbot   
2010-04-19 21:13   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/90e107951e84 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/91d98bda46c1 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17088.obx [^]