Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0012886Openbravo ERPA. Platformpublic2010-04-06 19:172010-05-18 12:12
Reportershuehner 
Assigned Toiperdomo 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target Version2.50MP17Fixed in Versionpi 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0012886: Deep Linking log NPE and show empty error page on invalid tabId
DescriptionUsing an invalid (non-existing) tabId for deep linking shows an NPE (on tab.getWindow()) and an empty error page to the user.

Logging an error (like invalid tabId: <value>) and going to the normal menu page would be a better way of handling that error.
Steps To ReproduceUse a deep linking url with a non-existing tabId:

example:
http://localhost:8080/openbravo/security/Menu.html?Command=NEW&tabId=221 [^]
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0011715 closed iperdomo DeepLinking: contains both windowId & tabId in link where only tabId is really needed 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-04-06 19:17shuehnerNew Issue
2010-04-06 19:17shuehnerAssigned To => iperdomo
2010-04-06 19:17shuehnerOBNetwork customer => No
2010-04-06 19:17shuehnerRelationship addedrelated to 0011715
2010-04-06 19:17iperdomoStatusnew => scheduled
2010-04-06 19:17iperdomofix_in_branch => pi
2010-04-06 19:17iperdomoTarget Version => 2.50MP15
2010-04-06 19:17iperdomofix_in_branchpi =>
2010-04-06 19:23hgbotCheckin
2010-04-06 19:23hgbotNote Added: 0025913
2010-04-06 19:23hgbotStatusscheduled => resolved
2010-04-06 19:23hgbotResolutionopen => fixed
2010-04-06 19:23hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/8af91206af1a2417bbb09d80d9b0baab6371f6b4 [^]
2010-04-06 20:08shuehnerNote Added: 0025914
2010-04-06 20:08shuehnerStatusresolved => closed
2010-04-06 20:08shuehnerFixed in Version => pi
2010-04-07 00:00anonymoussf_bug_id0 => 2982906
2010-04-19 21:12hudsonbotCheckin
2010-04-19 21:12hudsonbotNote Added: 0026420
2010-05-18 12:12gorka_gilTarget Version2.50MP15 => 2.50MP17

Notes
(0025913)
hgbot   
2010-04-06 19:23   
Repository: erp/devel/pi
Changeset: 8af91206af1a2417bbb09d80d9b0baab6371f6b4
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Tue Apr 06 19:30:53 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/8af91206af1a2417bbb09d80d9b0baab6371f6b4 [^]

Fixes issue 12886: Prevents NPE on invalid tabId

---
M src/org/openbravo/erpCommon/security/Menu.java
---
(0025914)
shuehner   
2010-04-06 20:08   
Tested on pi/psotgresql, rev: 8af91206af1a. On invalid tabId and error is logged and the user is transparently redirected to the menu.
(0026420)
hudsonbot   
2010-04-19 21:12   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/8af91206af1a [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/91d98bda46c1 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17088.obx [^]