Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0012876Openbravo ERPA. Platformpublic2010-04-06 09:492010-04-09 00:00
Reportermtaal 
Assigned Tomtaal 
PriorityimmediateSeveritycriticalReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionpiFixed in Version2.50MP15 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0012876: API change: in domain type interface
DescriptionThe domain type interfaces are used to model the primitive and foreign key types in-memory (a Domain Type corresponds to the AD_Reference).

I have committed an api change in the primitive type domain type interface class:
- added hibernate type method
- added methods to support xml conversion for a domain type

Default implementations of these methods are available in the BasePrimitiveDomainType class.

My estimate is that the impact of this api change is limited and it is low risk as:
- the api/interface has been introduced in the previous MP, so it is not old
- the documentation clearly states to preferably extend the BasePrimitiveDomainType when implementing own domain types

This is the changeset implementing the change:
http://code.openbravo.com/erp/devel/pi/rev/fb97b5f3e905e1f27e7be9961d077fa27ba63b97 [^]

It has been pushed to pi.



Steps To Reproduce
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0012632pi closed mtaal DomainType should be extended with hibernatetype and xml conversion 
depends on defect 0012633pi closed mtaal XML Conversion from integer numbers should be more robust 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-04-06 09:49mtaalNew Issue
2010-04-06 09:49mtaalAssigned To => pjuvara
2010-04-06 09:49mtaalOBNetwork customer => No
2010-04-06 09:49mtaalRelationship addedrelated to 0012632
2010-04-06 09:49mtaalRelationship addeddepends on 0012633
2010-04-06 13:29shuehnerPrioritynormal => immediate
2010-04-06 13:29shuehnerSeveritymajor => critical
2010-04-06 13:29shuehnerIssue Monitored: shuehner
2010-04-06 13:51pjuvaraAssigned Topjuvara => mtaal
2010-04-06 13:51pjuvaraStatusnew => scheduled
2010-04-06 13:51pjuvaraNote Added: 0025893
2010-04-06 13:51pjuvarafix_in_branch => pi
2010-04-07 21:15hgbotCheckin
2010-04-07 21:15hgbotNote Added: 0025962
2010-04-07 21:15hgbotStatusscheduled => resolved
2010-04-07 21:15hgbotResolutionopen => fixed
2010-04-07 21:15hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/api-checks/rev/aedb42a83ae474b24137cc0445f7f598c131b596 [^]
2010-04-08 11:41mtaalNote Added: 0025970
2010-04-08 11:41mtaalStatusresolved => closed
2010-04-08 11:41mtaalFixed in Version => 2.50MP15
2010-04-09 00:00anonymoussf_bug_id0 => 2984168

Notes
(0025893)
pjuvara   
2010-04-06 13:51   
API change accepted.

Please publish an alert and proceed.

Suggest alert severity: medium.
(0025962)
hgbot   
2010-04-07 21:15   
Repository: erp/devel/api-checks
Changeset: aedb42a83ae474b24137cc0445f7f598c131b596
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Apr 07 21:27:29 2010 +0200
URL: http://code.openbravo.com/erp/devel/api-checks/rev/aedb42a83ae474b24137cc0445f7f598c131b596 [^]

fixes issue 12876: API change: in domain type interface

---
M java/reference/250.japi.gz
---
(0025970)
mtaal   
2010-04-08 11:41   
Api change acknowledged, api-baseline file has been updated, build passes