Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0012801 | Openbravo ERP | B. User interface | public | 2010-03-25 11:06 | 2010-08-19 00:00 |
|
| Reporter | iperdomo | |
| Assigned To | iperdomo | |
| Priority | urgent | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 20 | OS Version | 2.6.30-gentoo-r5 |
| Product Version | 2.50MP13 | |
| Target Version | | Fixed in Version | | |
| Merge Request Status | |
| Review Assigned To | |
| OBNetwork customer | |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0012801: The file messages.js is included more than one time in the header of the HTML |
| Description | There is a long list of copy-pasted code that includes more than once messages.js in the header of a HTML file.
One of the first rules to improve the performance of a webapp is to minimize http request [1]
Attached you'll find the complete list of HTML templates that include messages.js more than one time.
[1] http://developer.yahoo.com/performance/rules.html#num_http [^] |
| Steps To Reproduce | * Check the attached list
* Search for messages.js in the file on the list |
| Proposed Solution | * Remove one the the messsages.js entries. Make sure that the messages.js is below the DynamicJS entry and after utils.js.
Note: Adding messages.js after utils.js helps to solve another small fix to some code. |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files |  jscheck-duplicated.log (17,062) 2010-03-25 11:06
https://issues.openbravo.com/file_download.php?file_id=2379&type=bug
 jscheck (310) 2010-08-04 10:41
https://issues.openbravo.com/file_download.php?file_id=2818&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2010-03-25 11:06 | iperdomo | New Issue | |
| 2010-03-25 11:06 | iperdomo | Assigned To | => dbaz |
| 2010-03-25 11:06 | iperdomo | File Added: jscheck-duplicated.log | |
| 2010-03-25 12:28 | dbaz | Assigned To | dbaz => shuehner |
| 2010-03-29 08:21 | alostale | Status | new => scheduled |
| 2010-03-29 08:21 | alostale | fix_in_branch | => pi |
| 2010-04-14 15:35 | shuehner | Note Added: 0026187 | |
| 2010-04-23 18:33 | shuehner | Note Added: 0026654 | |
| 2010-08-04 10:40 | iperdomo | Assigned To | shuehner => iperdomo |
| 2010-08-04 10:41 | iperdomo | File Added: jscheck | |
| 2010-08-04 10:42 | iperdomo | Note Added: 0029780 | |
| 2010-08-04 10:43 | iperdomo | Note Edited: 0029780 | bug_revision_view_page.php?bugnote_id=0029780#r646 |
| 2010-08-04 10:45 | iperdomo | Note Added: 0029781 | |
| 2010-08-04 15:58 | hgbot | Checkin | |
| 2010-08-04 15:58 | hgbot | Note Added: 0029788 | |
| 2010-08-04 15:58 | hgbot | Status | scheduled => resolved |
| 2010-08-04 15:58 | hgbot | Resolution | open => fixed |
| 2010-08-04 15:58 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/8bd78936b44611e3d2c2aff1e46b6a7b5fe2d1e9 [^] |
| 2010-08-05 09:16 | hudsonbot | Checkin | |
| 2010-08-05 09:16 | hudsonbot | Note Added: 0029807 | |
| 2010-08-18 12:47 | shuehner | Note Added: 0030112 | |
| 2010-08-18 12:47 | shuehner | Status | resolved => closed |
| 2010-08-19 00:00 | anonymous | sf_bug_id | 0 => 3048126 |
|
Notes |
|
|
|
I don't agree with the numhttp argument, as afaik even with more than one inclusion of the same js-file inside the same html it should only be downloaded once (browser cache).
But, double inclusion is useless, and forces the browser to parse end execute the js-body twice.. so the duplicates should be nevertheless removed. |
|
|
|
|
command to get an updated list of those duplicates
find src -type f -name '*.html' | xargs grep messages.js | cut -d':' -f1 | sort | uniq -c | sort -n |
|
|
|
(0029780)
|
|
iperdomo
|
2010-08-04 10:42
(edited on: 2010-08-04 10:43) |
|
find src -type f -name '*.html' | xargs -n1 /path/to/jscheck
This script check the that the messages.js is included before utils.js
|
|
|
|
|
|
The changes should also include JS inclusion order: messages.js must be included after utils.js to use getFrame() function capabilities |
|
|
|
(0029788)
|
|
hgbot
|
|
2010-08-04 15:58
|
|
Repository: erp/devel/pi
Changeset: 8bd78936b44611e3d2c2aff1e46b6a7b5fe2d1e9
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Wed Aug 04 11:10:18 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/8bd78936b44611e3d2c2aff1e46b6a7b5fe2d1e9 [^]
Fixes issue 12801: Fixes duplicated entries of messages.js and inclusion order
- Removed the duplicated entries of messages.js
- utils.js must be included before messages.js to be able to use the getFrame
function and retrieve the messages from frame: frameMenu
---
M src-wad/src/org/openbravo/wad/TemplateSortTab_Relation.html
M src-wad/src/org/openbravo/wad/Template_ActionButton.html
M src-wad/src/org/openbravo/wad/Template_Edition.html
M src-wad/src/org/openbravo/wad/Template_Relation.html
M src/org/openbravo/base/secureApp/PopUp_Close.html
M src/org/openbravo/base/secureApp/PopUp_Close_And_Refresh.html
M src/org/openbravo/base/secureApp/PopUp_Close_Refresh.html
M src/org/openbravo/base/secureApp/PopUp_Response.html
M src/org/openbravo/erpCommon/ad_actionButton/ActionButtonDefault.html
M src/org/openbravo/erpCommon/ad_actionButton/ActionButtonResponse.html
M src/org/openbravo/erpCommon/ad_actionButton/CopyFromSettlement.html
M src/org/openbravo/erpCommon/ad_actionButton/CreateFromMultiple_Receipt.html
M src/org/openbravo/erpCommon/ad_actionButton/CreateFromMultiple_Shipment.html
M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_DPManagement.html
M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_F0.html
M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_Invoice.html
M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_Settlement.html
M src/org/openbravo/erpCommon/ad_actionButton/EncryptedButtons.html
M src/org/openbravo/erpCommon/ad_actionButton/ExpenseSOrder.html
M src/org/openbravo/erpCommon/ad_actionButton/ExportReferenceData.html
M src/org/openbravo/erpCommon/ad_actionButton/RequestAction.html
M src/org/openbravo/erpCommon/ad_forms/AlertManagement.html
M src/org/openbravo/erpCommon/ad_forms/CallAcctServer.html
M src/org/openbravo/erpCommon/ad_forms/DebtPaymentUnapply.html
M src/org/openbravo/erpCommon/ad_forms/EdiFileImport.html
M src/org/openbravo/erpCommon/ad_forms/FileImport.html
M src/org/openbravo/erpCommon/ad_forms/GenerateInvoicesmanual.html
M src/org/openbravo/erpCommon/ad_forms/GenerateShipmentsmanual.html
M src/org/openbravo/erpCommon/ad_forms/InformeInOut.html
M src/org/openbravo/erpCommon/ad_forms/InitialClientSetup.html
M src/org/openbravo/erpCommon/ad_forms/InitialOrgSetup.html
M src/org/openbravo/erpCommon/ad_forms/InstanceManagement.html
M src/org/openbravo/erpCommon/ad_forms/InstanceManagementActivateLocal.html
M src/org/openbravo/erpCommon/ad_forms/InstanceManagementActivateOnline.html
M src/org/openbravo/erpCommon/ad_forms/InstanceManagementDeactivate.html
M src/org/openbravo/erpCommon/ad_forms/InvoiceVendorMultiline.html
M src/org/openbravo/erpCommon/ad_forms/InvoiceVendorMultiline_Lines.html
M src/org/openbravo/erpCommon/ad_forms/MaterialReceiptPending.html
M src/org/openbravo/erpCommon/ad_forms/ModuleManagementAdd.html
M src/org/openbravo/erpCommon/ad_forms/ModuleManagementDetails.html
M src/org/openbravo/erpCommon/ad_forms/ModuleManagementHistory.html
M src/org/openbravo/erpCommon/ad_forms/ModuleManagementInstalled.html
M src/org/openbravo/erpCommon/ad_forms/ModuleManagementSettings.html
M src/org/openbravo/erpCommon/ad_forms/ModuleManagement_ErrorCommercial.html
M src/org/openbravo/erpCommon/ad_forms/ModuleManagement_InstallLocal.html
M src/org/openbravo/erpCommon/ad_forms/ModuleManagement_InstallP1.html
M src/org/openbravo/erpCommon/ad_forms/ModuleManagement_InstallP2.html
M src/org/openbravo/erpCommon/ad_forms/ModuleManagement_InstallP4.html
M src/org/openbravo/erpCommon/ad_forms/RemittanceCancel.html
M src/org/openbravo/erpCommon/ad_forms/RequisitionToOrder.html
M src/org/openbravo/erpCommon/ad_forms/RequisitionToOrderCreate.html
M src/org/openbravo/erpCommon/ad_forms/Resultado.html
M src/org/openbravo/erpCommon/ad_forms/Role.html
M src/org/openbravo/erpCommon/ad_forms/SQLExecutor.html
M src/org/openbravo/erpCommon/ad_forms/ShowSessionPreferences.html
M src/org/openbravo/erpCommon/ad_forms/ShowSessionVariables.html
M src/org/openbravo/erpCommon/ad_forms/Translation.html
M src/org/openbravo/erpCommon/ad_forms/UpdateReferenceData.html
M src/org/openbravo/erpCommon/ad_process/ChangeOrderOrg.html
M src/org/openbravo/erpCommon/ad_process/CreateAccountingReport.html
M src/org/openbravo/erpCommon/ad_process/CreateAccountingReportPopUp.html
M src/org/openbravo/erpCommon/ad_process/CreateCashFlowStatement.html
M src/org/openbravo/erpCommon/ad_process/CreateTaxReport.html
M src/org/openbravo/erpCommon/ad_process/CreateTaxReportPopUp.html
M src/org/openbravo/erpCommon/ad_process/DeleteClient.html
M src/org/openbravo/erpCommon/ad_process/GenerateHelp.html
M src/org/openbravo/erpCommon/ad_process/PriceListCreateAll.html
M src/org/openbravo/erpCommon/ad_process/PrintInvoices.html
M src/org/openbravo/erpCommon/ad_process/RequestReOpen.html
M src/org/openbravo/erpCommon/ad_process/SendMailText.html
M src/org/openbravo/erpCommon/ad_reports/GeneralAccountingReports.html
M src/org/openbravo/erpCommon/ad_reports/GenerateModel347.html
M src/org/openbravo/erpCommon/ad_reports/MInOutTraceReports.html
M src/org/openbravo/erpCommon/ad_reports/ReportAccountingCountDimensionalAnalysesEdit.html
M src/org/openbravo/erpCommon/ad_reports/ReportAccountingCountDimensionalAnalysesEdition.html
M src/org/openbravo/erpCommon/ad_reports/ReportAccountingCountDimensionalAnalysesFilter.html
M src/org/openbravo/erpCommon/ad_reports/ReportAgingBalance.html
M src/org/openbravo/erpCommon/ad_reports/ReportAnnualCertification.html
M src/org/openbravo/erpCommon/ad_reports/ReportAssetDepreciationSchedule.html
M src/org/openbravo/erpCommon/ad_reports/ReportBank.html
M src/org/openbravo/erpCommon/ad_reports/ReportBankEdit.html
M src/org/openbravo/erpCommon/ad_reports/ReportBankJR.html
M src/org/openbravo/erpCommon/ad_reports/ReportBudgetGenerateExcel.html
M src/org/openbravo/erpCommon/ad_reports/ReportCash.html
M src/org/openbravo/erpCommon/ad_reports/ReportCashEdit.html
M src/org/openbravo/erpCommon/ad_reports/ReportCashFlow.html
M src/org/openbravo/erpCommon/ad_reports/ReportCashFlowPopUp.html
M src/org/openbravo/erpCommon/ad_reports/ReportCashFlowReload.html
M src/org/openbravo/erpCommon/ad_reports/ReportCashJR.html
M src/org/openbravo/erpCommon/ad_reports/ReportCashflowForecast.html
M src/org/openbravo/erpCommon/ad_reports/ReportDebtPayment.html
M src/org/openbravo/erpCommon/ad_reports/ReportDebtPaymentTrack.html
M src/org/openbravo/erpCommon/ad_reports/ReportExpense.html
M src/org/openbravo/erpCommon/ad_reports/ReportExpenseEdit.html
M src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedger.html
M src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedgerJournal.html
M src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedgerJournalDetail.html
M src/org/openbravo/erpCommon/ad_reports/ReportGuaranteeDateJR.html
M src/org/openbravo/erpCommon/ad_reports/ReportInventory.html
M src/org/openbravo/erpCommon/ad_reports/ReportInventoryEdit.html
M src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerDimensionalAnalysesEdition.html
M src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerDimensionalAnalysesFilter.html
M src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerDimensionalAnalysesJRFilter.html
M src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerEdition.html
M src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerFilter.html
M src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerFilterJR.html
M src/org/openbravo/erpCommon/ad_reports/ReportInvoiceDiscount.html
M src/org/openbravo/erpCommon/ad_reports/ReportInvoiceDiscountEdit.html
M src/org/openbravo/erpCommon/ad_reports/ReportInvoiceDiscountJR.html
M src/org/openbravo/erpCommon/ad_reports/ReportInvoiceVendorDimensionalAnalysesFilterJR.html
M src/org/openbravo/erpCommon/ad_reports/ReportInvoiceVendorFilterJR.html
M src/org/openbravo/erpCommon/ad_reports/ReportInvoices.html
M src/org/openbravo/erpCommon/ad_reports/ReportInvoicesEdit.html
M src/org/openbravo/erpCommon/ad_reports/ReportInvoicesJR.html
M src/org/openbravo/erpCommon/ad_reports/ReportMaterialDimensionalAnalysesFilterJR.html
M src/org/openbravo/erpCommon/ad_reports/ReportMaterialTransactionEdition.html
M src/org/openbravo/erpCommon/ad_reports/ReportMaterialTransactionEditionJR.html
M src/org/openbravo/erpCommon/ad_reports/ReportMaterialTransactionFilter.html
M src/org/openbravo/erpCommon/ad_reports/ReportNotPosted.html
M src/org/openbravo/erpCommon/ad_reports/ReportOrderNotInvoiceFilterJR.html
M src/org/openbravo/erpCommon/ad_reports/ReportParetoProduct.html
M src/org/openbravo/erpCommon/ad_reports/ReportPendingProductionEditJr.html
M src/org/openbravo/erpCommon/ad_reports/ReportPendingProductionJr.html
M src/org/openbravo/erpCommon/ad_reports/ReportPricelist.html
M src/org/openbravo/erpCommon/ad_reports/ReportProductMovement.html
M src/org/openbravo/erpCommon/ad_reports/ReportProduction.html
M src/org/openbravo/erpCommon/ad_reports/ReportProductionCost.html
M src/org/openbravo/erpCommon/ad_reports/ReportProductionJR.html
M src/org/openbravo/erpCommon/ad_reports/ReportProductionRunJR.html
M src/org/openbravo/erpCommon/ad_reports/ReportProjectBuildingSite.html
M src/org/openbravo/erpCommon/ad_reports/ReportProjectBuildingSiteJR.html
M src/org/openbravo/erpCommon/ad_reports/ReportProjectBuildingSitePop.html
M src/org/openbravo/erpCommon/ad_reports/ReportProjectProfitabilityJR.html
M src/org/openbravo/erpCommon/ad_reports/ReportProjectProgress.html
M src/org/openbravo/erpCommon/ad_reports/ReportPurchaseDimensionalAnalysesFilterJR.html
M src/org/openbravo/erpCommon/ad_reports/ReportRefundInvoiceCustomerDimensionalAnalysesEdition.html
M src/org/openbravo/erpCommon/ad_reports/ReportRefundInvoiceCustomerDimensionalAnalysesFilter.html
M src/org/openbravo/erpCommon/ad_reports/ReportRefundSalesDimensionalAnalysesEdition.html
M src/org/openbravo/erpCommon/ad_reports/ReportRefundSalesDimensionalAnalysesFilter.html
M src/org/openbravo/erpCommon/ad_reports/ReportSalesDimensionalAnalyzeJRFilter.html
M src/org/openbravo/erpCommon/ad_reports/ReportSalesOrderFilterJR.html
M src/org/openbravo/erpCommon/ad_reports/ReportSalesOrderInvoicedJasper.html
M src/org/openbravo/erpCommon/ad_reports/ReportSalesOrderOpenItem.html
M src/org/openbravo/erpCommon/ad_reports/ReportSalesOrderOpenItemJR.html
M src/org/openbravo/erpCommon/ad_reports/ReportSalesOrderProvidedJR.html
M src/org/openbravo/erpCommon/ad_reports/ReportShipmentDimensionalAnalyzeJRFilter.html
M src/org/openbravo/erpCommon/ad_reports/ReportShipmentEditionJR.html
M src/org/openbravo/erpCommon/ad_reports/ReportShipmentFilterJR.html
M src/org/openbravo/erpCommon/ad_reports/ReportShipper.html
M src/org/openbravo/erpCommon/ad_reports/ReportStandardCostJRFilter.html
M src/org/openbravo/erpCommon/ad_reports/ReportTaxInvoice.html
M src/org/openbravo/erpCommon/ad_reports/ReportTaxInvoiceEdit.html
M src/org/openbravo/erpCommon/ad_reports/ReportToInvoiceConsignment.html
M src/org/openbravo/erpCommon/ad_reports/ReportToInvoiceConsignmentJR.html
M src/org/openbravo/erpCommon/ad_reports/ReportTotalProductTemplate.html
M src/org/openbravo/erpCommon/ad_reports/ReportTotalProductTemplateEdit.html
M src/org/openbravo/erpCommon/ad_reports/ReportTrialBalance.html
M src/org/openbravo/erpCommon/ad_reports/ReportTrialBalanceDetail.html
M src/org/openbravo/erpCommon/ad_reports/ReportValuationStock.html
M src/org/openbravo/erpCommon/ad_reports/ReportWarehouseControl.html
M src/org/openbravo/erpCommon/ad_reports/ReportWarehouseDetailInventoryJR.html
M src/org/openbravo/erpCommon/ad_reports/ReportWarehousePartnerJR.html
M src/org/openbravo/erpCommon/ad_reports/ReportWorkRequirementDaily.html
M src/org/openbravo/erpCommon/ad_reports/ReportWorkRequirementDailyEnv.html
M src/org/openbravo/erpCommon/ad_reports/ReportWorkRequirementDailyEnvEdit.html
M src/org/openbravo/erpCommon/ad_reports/ReportWorkRequirementJR.html
M src/org/openbravo/erpCommon/ad_workflow/WorkflowControl_Redirect.html
M src/org/openbravo/erpCommon/ad_workflow/WorkflowControl_Response.html
M src/org/openbravo/erpCommon/businessUtility/Buscador.html
M src/org/openbravo/erpCommon/businessUtility/PrinterReports.html
M src/org/openbravo/erpCommon/businessUtility/TabAttachments_F1.html
M src/org/openbravo/erpCommon/businessUtility/TabFilter.html
M src/org/openbravo/erpCommon/info/Account.html
M src/org/openbravo/erpCommon/info/AttributeSetInstance.html
M src/org/openbravo/erpCommon/info/SearchUniqueKeyResponse.html
M src/org/openbravo/erpCommon/obps/ErrorActivatedInstancesOnly.html
M src/org/openbravo/erpCommon/security/Login_F1.html
M src/org/openbravo/erpCommon/security/Login_Options_F1.html
M src/org/openbravo/erpCommon/utility/Home.html
M src/org/openbravo/erpCommon/utility/OpenPentaho.html
M src/org/openbravo/erpCommon/utility/PoolStatus.html
M src/org/openbravo/erpCommon/utility/PopupLoading.html
M src/org/openbravo/erpCommon/utility/SetPriority.html
M src/org/openbravo/erpCommon/utility/TaskDefault.html
M src/org/openbravo/erpCommon/utility/VerticalMenu.html
M src/org/openbravo/erpCommon/utility/VerticalMenuLoading.html
M src/org/openbravo/erpCommon/utility/WindowTree.html
M src/org/openbravo/erpCommon/utility/reporting/printing/EmailOptions.html
M src/org/openbravo/erpCommon/utility/reporting/printing/PrintOptions.html
M src/org/openbravo/erpCommon/utility/reporting/printing/PrintStatus.html
M src/org/openbravo/erpReports/ReportPaymentFilter.html
M src/org/openbravo/erpReports/ReportRegisterFilter.html
M web/js/messages.js
---
|
|
|
|
|
|
|
|
|
Diff reviwed. there seem to be no other js file in web/js which calls any function from within messages.js directly when parsing/including this other js file. So no problem with the different inclusion order here.
Randomly picked some files of the diff to verify that the error messages are still shown fine in both classic and new layout. -> Closing |
|