Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0012779Openbravo ERPA. Platformpublic2010-03-23 19:292022-02-01 08:08
Reportershuehner 
Assigned ToTriage Platform Base 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusnewResolutionopen 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0012779: 'Create columns from db' should warn or skip column with names >30 as those are not allowed
DescriptionColumn with length or the name >30 chars don't work in oracle so erp has a validation to warn about them.

However 'Create column from db' happily creates those without warnings and only later on validation/export you get a note and need to rename all columns again.

The ad_table_import process should either skip and warn or just warn about those columns directly.
Steps To Reproduce
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-03-23 19:29shuehnerNew Issue
2010-03-23 19:29shuehnerAssigned To => alostale
2010-03-23 20:17camcalIssue Monitored: camcal
2010-03-23 20:32camcalNote Added: 0025690
2010-03-24 12:10shuehnerNote Added: 0025698
2010-03-25 17:45camcalNote Added: 0025735
2010-07-27 16:00rafarodaIssue Monitored: rafaroda
2010-10-19 23:09stalkerNote Added: 0031993
2017-04-10 14:39alostaleAssigned Toalostale => platform
2022-02-01 08:08alostaleAssigned Toplatform => Triage Platform Base

Notes
(0025690)
camcal   
2010-03-23 20:32   
Actually the issue occurs when you try to install a module that has a column with more than 30 characters, on another instance of OB.

During the rebuild it says that the column name has more than 30 character, but during the development it says "ERROR=value too long for type character varying(40)" using a column with more than 30 characters.

This happens when you try to create columns using "Create Columns from DB" button, and the column has more than 40 characters.

Also if you try to manually create a column, it allows you to type a name up to 40 characters long without warnings.

I want to emphasize that the 30 characters error occurs during the rebuild, not on the export, update, package or compile.development tasks.
(0025698)
shuehner   
2010-03-24 12:10   
Hi camcal,

i can't agree completely as current version of openbravo do the 30 character name length validation when exporting/packaging a module, only some older MP's did not yet have this check.

With that in place the installation parts gets less scary as you get told when exporting/packaging modules/updates already.
(0025735)
camcal   
2010-03-25 17:45   
Hi huehner.

I would say that the validation must be at the moment of the creation of the columns, so the developer can make the respective modifications before using them on a window, tab, alert, etc.

If you create a few columns, let's say 20, and you use them for filtering purposes, you will have to wait until the export/package task to realize that this columns doesn't fullfill the restrictions.

That means that the developer will have to rename all the columns and make the respective modifications on every single place that they are being used.

I'm telling you this, due the problems that i faced for this issue.

I had to made several modifications to my module replacing the names on every single place that i used them.
(0031993)
stalker   
2010-10-19 23:09   
(a weak voice from community crowd)

May be its worth considering to make a switch for developers?
something like... "Allow >30 chars for relnames" or... "Oracle rules!" )
Its always developer's (implementor's or partner's) decision which platform to utilize or consider... so why make all around send curses to Oracle?... )