Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0012650Openbravo ERP07. Sales managementpublic2010-03-11 12:492010-03-17 15:40
Reporternetworkb 
Assigned Toadrianromero 
PriorityimmediateSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version2.50MP13 
Target Version2.50MP14Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0012650: You can not delete a good shipment line so you can not delete the good shipment
DescriptionYou can not delete a good shipment line so you can not delete the good shipment.
When trying to delete the line you get the following error:

      
ERROR: record "new" is not assigned yet Detail: The tuple structure of a not-yet-assigned record is indeterminate.
Steps To Reproduce-Go to good shipment window
-Create a shipment
-Create a line and save it
-Try to delete the line.
Proposed SolutionThis bloque of code of the m_inoutline_trg is always executed:

 IF (:NEW.C_ORDERLINE_ID IS NOT NULL) THEN
    SELECT COUNT(*) INTO V_COUNT FROM C_ORDERLINE ol
    WHERE ol.C_ORDERLINE_ID = :NEW.C_ORDERLINE_ID
    AND :NEW.MOVEMENTQTY > ol.QTYORDERED;
          IF(V_COUNT <> 0) THEN
            RAISE_APPLICATION_ERROR(-20000, '@MovementQtyCheck@');
          END IF;
  END IF;
 IF (UPDATING) THEN

When deleting is not possible to use the new.

This should be done when inserting or updating only.
Additional Information
TagsRegression
Relationships
related to defect 00119772.50MP12 closed rafaroda It is possible to create a Good Shipment with more quantity thant Sales Order 
has duplicate defect 0012769 closed adrianromero Cannot delete goods shipment lines - error message for non-humans is presented 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-03-11 12:49networkbNew Issue
2010-03-11 12:49networkbAssigned To => adrianromero
2010-03-11 13:09networkbSeveritycritical => major
2010-03-11 13:16networkbProposed Solution updated
2010-03-11 16:10rafarodaIssue Monitored: rafaroda
2010-03-11 16:17rafarodaRelationship addedrelated to 0011977
2010-03-11 16:43hgbotCheckin
2010-03-11 16:43hgbotNote Added: 0025241
2010-03-11 16:43hgbotStatusnew => resolved
2010-03-11 16:43hgbotResolutionopen => fixed
2010-03-11 16:43hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/90e5934baefaa2aef4dc120934786aa48a1a8cd7 [^]
2010-03-11 16:49hgbotCheckin
2010-03-11 16:49hgbotNote Added: 0025242
2010-03-11 16:49hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/90e5934baefaa2aef4dc120934786aa48a1a8cd7 [^] => http://code.openbravo.com/erp/devel/pi/rev/cdc783c1056a6c48aea18b1ac000d7e7ea1a581f [^]
2010-03-11 16:53adrianromeroNote Added: 0025243
2010-03-12 22:41hudsonbotCheckin
2010-03-12 22:41hudsonbotNote Added: 0025428
2010-03-12 22:41hudsonbotCheckin
2010-03-12 22:41hudsonbotNote Added: 0025429
2010-03-15 08:14arunkumarNote Added: 0025443
2010-03-15 08:14arunkumarStatusresolved => closed
2010-03-16 00:00anonymoussf_bug_id0 => 2970945
2010-03-17 15:40psarobeTag Attached: Regression
2010-03-23 17:47adrianromeroRelationship addedhas duplicate 0012769

Notes
(0025241)
hgbot   
2010-03-11 16:43   
Repository: erp/devel/pi
Changeset: 90e5934baefaa2aef4dc120934786aa48a1a8cd7
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Thu Mar 11 16:48:41 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/90e5934baefaa2aef4dc120934786aa48a1a8cd7 [^]

Fixes issue 0012650: You can not delete a good shipment line so you can not delete the good shipment

---
M src-db/database/model/triggers/M_INOUTLINE_TRG.xml
M src/org/openbravo/erpCommon/ad_callouts/SL_InOutLine_Product.java
---
(0025242)
hgbot   
2010-03-11 16:49   
Repository: erp/devel/pi
Changeset: cdc783c1056a6c48aea18b1ac000d7e7ea1a581f
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Thu Mar 11 16:55:12 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/cdc783c1056a6c48aea18b1ac000d7e7ea1a581f [^]

Fixes issue 0012650: You can not delete a good shipment line so you can not delete the good shipment
Reverting SL_InOutLine_Product.java that does not belong to this commit

---
M src/org/openbravo/erpCommon/ad_callouts/SL_InOutLine_Product.java
---
(0025243)
adrianromero   
2010-03-11 16:53   
To test this issue just follow the reproduction steps and notice that now it is possible to delete good shipment lines
(0025428)
hudsonbot   
2010-03-12 22:41   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/90e5934baefa [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/631c626866c1 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.16685.obx [^]
(0025429)
hudsonbot   
2010-03-12 22:41   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/cdc783c1056a [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/631c626866c1 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.16685.obx [^]
(0025443)
arunkumar   
2010-03-15 08:14   
Tested & Working fine