Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0012582Openbravo ERP03. Procurement managementpublic2010-03-06 09:152010-03-23 00:00
Reporterbalamurugan 
Assigned Tobalamurugan 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionCommunity Appliance
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0012582: "Line Net Amount is not Correct" Error message is displayed when we try to save any Purchase/Sales Invoice Line
Description"Line Net Amount is not Correct" Error message is displayed when we try to save any Purchase/Sales Invoice Line
Steps To Reproduce1. Go to Sales Management || Transactions || Sales Order || Header >> Lines tab
2. Select any product, and enter the following values.
  - Ordered Quantity=7
  - Now, the remaining fields like Net Unit Price, Net Standard price. etc., are populated as per the setup.
  - check the Edit Line Net Amount field and change the value of Line Net Amount to 45.33
  - Please realize that the Net Unit Amount is changed based on the Line Net Amount entered.
  - click Save.
  - Now, "Line Net Amount is not Correct" Error message is displayed when we try to save.
Proposed SolutionIn SL_Invoice_Amt callout, Net Unit Price calculation is done based on Standard Precision , but it has to be done based on Price Precision.

priceActual = LineNetAmt.divide(qtyInvoice, StdPrecision, BigDecimal.ROUND_HALF_UP); => priceActual = LineNetAmt.divide(qtyInvoice, PricePrecision, BigDecimal.ROUND_HALF_UP);
Additional Information
TagsNo tags attached.
Relationships
depends on defect 0012581 closed balamurugan In Purchase/Sales Order Lines tab, while editing Line Net Amount, it is changed when we save. 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-03-06 09:15balamuruganNew Issue
2010-03-06 09:15balamuruganAssigned To => adrianromero
2010-03-06 09:15balamuruganOBNetwork customer => No
2010-03-06 09:16balamuruganRelationship addeddepends on 0012581
2010-03-06 09:17balamuruganAssigned Toadrianromero => dalsasua
2010-03-08 08:37dalsasuaAssigned Todalsasua => balamurugan
2010-03-08 08:39dalsasuaNote Added: 0025106
2010-03-09 07:22hgbotCheckin
2010-03-09 07:22hgbotNote Added: 0025157
2010-03-09 07:22hgbotStatusnew => resolved
2010-03-09 07:22hgbotResolutionopen => fixed
2010-03-09 07:22hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/331ea7f7c2e5628f41e3ad3b51a106f03f14e486 [^]
2010-03-12 22:41hudsonbotCheckin
2010-03-12 22:41hudsonbotNote Added: 0025406
2010-03-22 07:22arunkumarNote Added: 0025631
2010-03-22 07:22arunkumarStatusresolved => closed
2010-03-23 00:00anonymoussf_bug_id0 => 2974925

Notes
(0025106)
dalsasua   
2010-03-08 08:39   
This is the desired behavior. Systems checks that line net amount is quantity per net unit price. If are not correct, throws this error.

Please realize that there do not exists any value with standard precision in small bazaar for Euros (2 digits) that makes this equation work:
7*UnitPrice=45.33
as:
7*6.47=45.29
7*6.48=45.36

Furthermore, proposed solution wouldn't help here. If we use price precision (4 digits in small bazaar), then the error will arise again using higher quantity (500, for example):
500*0.0906=45.30
500*0.0907=45.35

The calculated unit price due to the line amount entered by the user is rounded to the price precision. If the line amount is not a valid one (using the price precision, it doesn't exists any possible value for unit price) system will raise that in the moment of saving.

Nevertheless, if actually system is rounding to standard precision, and not to price precision in the call-out, when calculating unit price from the given line amount, please fix that.

Thanks.
(0025157)
hgbot   
2010-03-09 07:22   
Repository: erp/devel/pi
Changeset: 331ea7f7c2e5628f41e3ad3b51a106f03f14e486
Author: Balamurugan Ramadoss <balamurugan.ramadoss <at> openbravo.com>
Date: Tue Mar 09 11:56:34 2010 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/331ea7f7c2e5628f41e3ad3b51a106f03f14e486 [^]

Fixes Issue 12582: \"Line Net Amount is not Correct\" Error message.

---
M src/org/openbravo/erpCommon/ad_callouts/SL_Invoice_Amt.java
M src/org/openbravo/erpCommon/ad_callouts/SL_Order_Amt.java
---
(0025406)
hudsonbot   
2010-03-12 22:41   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/331ea7f7c2e5 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/631c626866c1 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.16685.obx [^]
(0025631)
arunkumar   
2010-03-22 07:22   
As per David's notes if we enter the net unit amount as 45.33 and ordered quantity as 7 it calculates the net unit price as 6.48 and recalculates the net unit amount as 45.36

Discussed with the developer and confirmed with the results.

Tested & Working fine.