Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0012579Openbravo ERP07. Sales managementpublic2010-03-05 16:492010-06-03 22:49
Reporternetworkb 
Assigned Tosivaraman 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version2.50MP12 
Target Version2.50MP18Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0012579: There is a combo empty on a filter window
DescriptionThe combo 'Transaction Document' is empty on the filter window of Sales Invoices and Sales Order
Steps To Reproduce-As Openbravo Admin go to Sales Management || Transactions || Sales Invoice or Sales Order
-Click 'Search Record'
-Realize that the combo 'Transaction Document' is empty
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 00111712.50MP11 closed alostale Sales order window: Pop-up search->Transactional document combo box empty 
has duplicate defect 00121362.50MP17 closed adrianromero Filter Column 
has duplicate defect 0013116 closed alostale Document Type Filter on Sales Invoice and Purchase Invoice. 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-03-05 16:49networkbNew Issue
2010-03-05 16:49networkbAssigned To => adrianromero
2010-03-08 16:05jpabloaeTarget Version2.50MP14 => 2.50MP15
2010-03-08 16:52adrianromeroStatusnew => scheduled
2010-03-08 16:52adrianromerofix_in_branch => pi
2010-04-23 12:57adrianromeroRelationship addedrelated to 0011171
2010-04-23 12:58adrianromeroNote Added: 0026619
2010-04-23 12:58adrianromeroStatusscheduled => closed
2010-04-23 12:58adrianromeroResolutionopen => no change required
2010-04-23 13:12networkbNote Added: 0026621
2010-04-23 17:14adrianromeroNote Added: 0026643
2010-04-23 17:14adrianromeroStatusclosed => new
2010-04-23 17:14adrianromeroResolutionno change required => open
2010-04-23 17:15adrianromeroStatusnew => scheduled
2010-04-29 13:56adrianromeroRelationship addedhas duplicate 0012136
2010-05-03 08:56alostaleRelationship addedhas duplicate 0013116
2010-05-19 17:19networkbTarget Version2.50MP15 => 2.50MP19
2010-05-19 17:19networkbfix_in_branchpi =>
2010-05-21 12:32adrianromeroAssigned Toadrianromero => shuehner
2010-05-21 15:11networkbTarget Version2.50MP19 => 2.50MP18
2010-05-26 16:25shuehnerAssigned Toshuehner => adrianromero
2010-05-26 16:25shuehnerNote Added: 0027752
2010-05-28 14:06sivaramanAssigned Toadrianromero => sivaraman
2010-05-28 14:09hgbotCheckin
2010-05-28 14:09hgbotNote Added: 0027814
2010-05-28 14:09hgbotStatusscheduled => resolved
2010-05-28 14:09hgbotResolutionopen => fixed
2010-05-28 14:09hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/3b31299bcca29a244befb55132bcecd4826589cb [^]
2010-05-28 14:26sivaramanNote Added: 0027815
2010-05-31 07:56arunkumarNote Added: 0027825
2010-05-31 07:56arunkumarStatusresolved => closed
2010-06-01 00:00anonymoussf_bug_id0 => 3009680
2010-06-03 22:49hudsonbotCheckin
2010-06-03 22:49hudsonbotNote Added: 0027934

Notes
(0026619)
adrianromero   
2010-04-23 12:58   
As explained in 11171 It is mandatory now to select one of the organizations in order to be able to see documents in the combo. If we leave the organization as empty or * then we will not be able to see any documents in the "Transaction document" combobox.
(0026621)
networkb   
2010-04-23 13:12   
Adrián, some comments on this:

*Organization *, should not appear in this combo.
*It makes sense that if a organization is selected, all its documents must appear.

However, right now, it is not possible to search for a type of document.
It is not possible to search all POS Orders, from a Client.

If POS order document type is registered for * organization, it makes sense that diferent POS orders are created in diferent organizations. If we can search using this logical, it is not possible.

Document type combo should show (when no organization is selected) all document types used in organizations that user can access.

Please, reopen the ticket.
(0026643)
adrianromero   
2010-04-23 17:14   
The current validation restrict the document types based on the value of 'ad_org_id' probably what we (perhaps) want is no restriction if there is ad_org_id == null or == ''.


If this case can only happen in the search poppup and the normal window always has ad_org_org != '' then modifying the validation sql to not filter with ad_org_id == '' could give us the behavior we want.
(0027752)
shuehner   
2010-05-26 16:25   
Reassigning to functional team, as no platform/core code change is required. Mail with possible solution send to adrianromero.
(0027814)
hgbot   
2010-05-28 14:09   
Repository: erp/devel/pi
Changeset: 3b31299bcca29a244befb55132bcecd4826589cb
Author: Sivaraman Rajagopal <sivaraman.rajagopal <at> openbravo.com>
Date: Fri May 28 17:37:58 2010 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/3b31299bcca29a244befb55132bcecd4826589cb [^]

Fixes issue 12579: There is a combo empty on a filter window

Validation code has been modified for Transaction Document field in C_ORDER and C_INVOICE tables in order to list values in Transaction Document combo box when no organization is selected. Also, New validation rule has been added for organization field of C_ORDER and C_INVOICE tables in order to remove * from the combo box of filter window. Since C_ORDER and C_INVOICE are also used for Purchase Order and Purchase Invoice respectively, This change will reflect in purchase module also.

---
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_REF_TABLE.xml
M src-db/database/sourcedata/AD_VAL_RULE.xml
---
(0027815)
sivaraman   
2010-05-28 14:26   
Steps to test:

1. Log on to Openbravo with 'Openbravo Admin' role
2. Sales Management || Transactions || Sales Invoice or Sales Order
3. Search Record
4. Verify if Transaction Documents are listed in the combo box when no organization is selected
5. Verify if * is not available in the organization combo box

Please note: This is fixed at table level (C_ORDER and C_INVOICE). Therefore, the fixed behavior will also reflect on Purchase Order and Purchase Invoice as they are using the same tables internally. So, verify the same in Purchase Order and Purchase Invoice.
(0027825)
arunkumar   
2010-05-31 07:56   
Tested working fine
(0027934)
hudsonbot   
2010-06-03 22:49   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/3b31299bcca2 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/c011484a38d9 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17407.obx [^]