Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0012510Openbravo ERP09. Financial managementpublic2010-03-01 16:212010-04-16 00:00
Reportermirurita 
Assigned Todalsasua 
PriorityurgentSeveritytrivialReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionCommunity Appliance
Product Versionmain 
Target VersionFixed in Version2.50MP15 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0012510: General Ledger Report: project name is displayed instead of the project identifier
DescriptionIn the general ledger report the name of the project is displayed instead of the identifier of the Project table: value + name.

It happens for the html, pdf and xls output.
Steps To Reproduce1) Go to Financial Management || Accounting || Analysis Tools || General Ledger Report

2) Fill the following fields:
 - Accounting schema
 - From / To Date
 - Group by: project

3) Click on search / pdf / xls button


Proposed SolutionUse ad_column_identifier function to get the table identifier.

Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-03-01 16:21miruritaNew Issue
2010-03-01 16:21miruritaAssigned To => dalsasua
2010-03-01 16:21miruritaOBNetwork customer => No
2010-03-08 18:01pjuvaraNote Added: 0025149
2010-03-08 18:01pjuvaraPrioritynormal => urgent
2010-03-09 11:30miruritaNote Added: 0025167
2010-03-11 19:48hgbotCheckin
2010-03-11 19:48hgbotNote Added: 0025253
2010-03-11 19:48hgbotStatusnew => resolved
2010-03-11 19:48hgbotResolutionopen => fixed
2010-03-11 19:48hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/5224213157be13d07d65eb6833d0297b1c7ef67b [^]
2010-03-12 22:41hudsonbotCheckin
2010-03-12 22:41hudsonbotNote Added: 0025432
2010-03-15 08:11arunkumarNote Added: 0025442
2010-03-15 09:05dalsasuaNote Added: 0025449
2010-03-15 10:52pjuvaraNote Added: 0025456
2010-03-15 11:08arunkumarNote Added: 0025459
2010-03-15 11:08arunkumarStatusresolved => new
2010-03-15 11:08arunkumarResolutionfixed => open
2010-03-15 11:09arunkumarStatusnew => scheduled
2010-03-15 11:09arunkumarfix_in_branch => pi
2010-03-15 11:44dalsasuaNote Added: 0025465
2010-03-15 12:03pjuvaraNote Added: 0025470
2010-03-15 12:10dalsasuaNote Added: 0025471
2010-03-15 14:34hgbotCheckin
2010-03-15 14:34hgbotNote Added: 0025477
2010-03-15 14:34hgbotStatusscheduled => resolved
2010-03-15 14:34hgbotResolutionopen => fixed
2010-03-15 14:34hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/5224213157be13d07d65eb6833d0297b1c7ef67b [^] => http://code.openbravo.com/erp/devel/pi/rev/594c63d5321a28373c08e63d0582b02707011a50 [^]
2010-03-15 15:41hgbotCheckin
2010-03-15 15:41hgbotNote Added: 0025479
2010-03-15 15:41hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/594c63d5321a28373c08e63d0582b02707011a50 [^] => http://code.openbravo.com/erp/devel/pi/rev/5a269b5f4b167fe727401497b312fd14899ed0e2 [^]
2010-03-17 09:01hudsonbotCheckin
2010-03-17 09:01hudsonbotNote Added: 0025548
2010-03-17 09:01hudsonbotCheckin
2010-03-17 09:01hudsonbotNote Added: 0025549
2010-04-15 16:59psarobeNote Added: 0026280
2010-04-15 16:59psarobeStatusresolved => closed
2010-04-15 16:59psarobeFixed in Version => 2.50MP15
2010-04-16 00:00anonymoussf_bug_id0 => 2987962

Notes
(0025149)
pjuvara   
2010-03-08 18:01   
Although this issue is trivial, we need to fix this as soon as possible since we very recently reviewed this report and this type of issue should not be there now.
(0025167)
mirurita   
2010-03-09 11:30   
It's also reproducible for Business Partner and Product: name is displayed instead of the identifier.
But in these cases the name column matches with the identifier of the table in a default Openbravo installation.
(0025253)
hgbot   
2010-03-11 19:48   
Repository: erp/devel/pi
Changeset: 5224213157be13d07d65eb6833d0297b1c7ef67b
Author: Salvador Zapata <salvador.zapata <at> openbravo.com>
Date: Thu Mar 11 19:26:24 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/5224213157be13d07d65eb6833d0297b1c7ef67b [^]

Fixed bug 12510: Group by project identifier instead of by name

---
M src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedger.java
M src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedger_data.xsql
---
(0025432)
hudsonbot   
2010-03-12 22:41   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/5224213157be [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/631c626866c1 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.16685.obx [^]
(0025442)
arunkumar   
2010-03-15 08:11   
While testing this fix I can see for project ** is displayed. Is this the right behavior? Can you please confirm?
(0025449)
dalsasua   
2010-03-15 09:05   
Please make sure you have a project with permissions for current user.
(0025456)
pjuvara   
2010-03-15 10:52   
Guys, I tested this behavior and it appears that ** is used to group by project transactions that are not related to any project.
This seems to be a side effect (the outcome of an outer join) rather than an intentional design choice. If it were a choice, it would be a poor UI choice as ** is very confusing.

Better options would be:
1) List "N/A" or even better "Not applicable". Question: how do we make it translatable?
2) Leave the field blank.

To me this bug must be re-opened.

Side note related to dalsasua's remark: let's make sure that we do not require financial staff to have direct access to projects in order to run a General Ledger report. That would be functionally very incorrect as it breaks proper segregation of duties.
(0025459)
arunkumar   
2010-03-15 11:08   
According to pjuvara's notes I am reopening this issue. David please take care of this issue.
(0025465)
dalsasua   
2010-03-15 11:44   
@Paolo. Maybe I didn't explain correctly. I was thinking about a user that cannot see the project because, for example, belongs to another organization, although they share the accounting schema.

@Salva: please have a look to your changeset, and add a case in the select, so whenever ad_column_identifier returns '**', shows an empty string, instead of '**'.

Thanks all. Regards.
(0025470)
pjuvara   
2010-03-15 12:03   
David,

let me state two different scenarios here:

1) Grouping by project transactions that are not associated to any project. See my comment and proposed solutions above.

2) User does have access to the accounting entry but does not have access to the project either because of functional (no privilege to open the project window) or organizational (no access to the organization of the project) restriction.
In this case, in the windows we display **<object name>, to indicate that object exists but you do not have access to it.
For reports, we do not have a specific convention (I am not sure how consistently this is implemented, but I would not be surprised if the level of consistency is very low). If we need to establish a convention now, I would choose the same we use in windows and display **<object name> instead of only **.

Can you please make sure that both cases are properly handled in this fix and properly tested?

As you do this, please make sure that the same does not only apply to projects but also to products and business partners.

Also, the same applies to the case where you do not group.
(0025471)
dalsasua   
2010-03-15 12:10   
Sure, both scenarios will be tested for projects, products and business partners. I will take care of that.
(0025477)
hgbot   
2010-03-15 14:34   
Repository: erp/devel/pi
Changeset: 594c63d5321a28373c08e63d0582b02707011a50
Author: Salvador Zapata <salvador.zapata <at> openbravo.com>
Date: Mon Mar 15 14:05:26 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/594c63d5321a28373c08e63d0582b02707011a50 [^]

Fixed bug 12510: Group by project,product,business partner identifier instead of by name

---
M src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedger_data.xsql
---
(0025479)
hgbot   
2010-03-15 15:41   
Repository: erp/devel/pi
Changeset: 5a269b5f4b167fe727401497b312fd14899ed0e2
Author: Salvador Zapata <salvador.zapata <at> openbravo.com>
Date: Mon Mar 15 15:23:20 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/5a269b5f4b167fe727401497b312fd14899ed0e2 [^]

Fixed bug 12510: ** removed

---
M src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedger_data.xsql
---
(0025548)
hudsonbot   
2010-03-17 09:01   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/594c63d5321a [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/859b8a1e96e9 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.16735.obx [^]
(0025549)
hudsonbot   
2010-03-17 09:01   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/5a269b5f4b16 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/859b8a1e96e9 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.16735.obx [^]
(0026280)
psarobe   
2010-04-15 16:59   
Tested working fine