Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0012465Openbravo ERP07. Sales managementpublic2010-02-25 09:482010-07-14 17:53
Reporternetworkb 
Assigned Toadrianromero 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version2.50MP11 
Target Version2.50MP14Fixed in Version2.50MP14 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0012465: Copy Lines on Sales Invoice does not wprk properly
DescriptionWe have a sale invoice from a spanish partner with a tax.
We create a new sale invoice from a foreign partner, and use 'Copy Lines'.
The line created has the same tax without the possibility of change.
Steps To Reproduce-As Openbravo Admin go to Master Data Management || Business Partner
-Select Mafalda and go to Location/Address.
-Change Location/Address: Country: Slovakia.
-Save and go to Sales Management || Transactions || Sales Invoice
-Create a new record:
   -Partner: McGiver
-Save and go to Lines:
   -Tax: 16%
-Save, complete and create a new record.
   -Partner: Mafalda.
-Click 'Copy Lines' and select the McGiver's Invoice created.

-Go to Lines.
-Realize that the tax is the same and it does not exist the possibility of change
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00139232.50MP13 closed adrianromero Copy Lines on Sales Invoice does not wprk properly 
related to feature request 00125872.50MP14 closed adrianromero wrong price in process "copy lines" of invoice 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-02-25 09:48networkbNew Issue
2010-02-25 09:48networkbAssigned To => adrianromero
2010-02-25 10:23adrianromeroStatusnew => scheduled
2010-02-25 10:28psarobeNote Added: 0024808
2010-03-05 06:03hgbotCheckin
2010-03-05 06:03hgbotNote Added: 0025070
2010-03-05 06:03hgbotStatusscheduled => resolved
2010-03-05 06:03hgbotResolutionopen => fixed
2010-03-05 06:03hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/163ab0500a0c8b1a77ceccfada0ba68cf4e6073a [^]
2010-03-05 06:05sivaramanNote Added: 0025071
2010-03-08 07:37arunkumarNote Added: 0025104
2010-03-08 07:37arunkumarStatusresolved => closed
2010-03-08 07:37arunkumarFixed in Version => 2.50MP13
2010-03-08 14:04rafarodaIssue Monitored: rafaroda
2010-03-08 14:14rafarodaRelationship addedrelated to 0012587
2010-03-08 16:04jpabloaeFixed in Version2.50MP13 => 2.50MP14
2010-03-08 16:05jpabloaeTarget Version2.50MP13 => 2.50MP14
2010-03-10 17:24anonymoussf_bug_id0 =>
2010-03-10 18:30anonymoussf_bug_id => 2968106
2010-03-12 22:40hudsonbotCheckin
2010-03-12 22:40hudsonbotNote Added: 0025393
2010-07-08 13:39adrianromeroIssue cloned0013923
2010-07-08 13:39adrianromeroRelationship addeddepends on 0013923
2010-07-14 17:53hgbotCheckin
2010-07-14 17:53hgbotNote Added: 0029314

Notes
(0024808)
psarobe   
2010-02-25 10:28   
Two things.

1. You can change it unless the invoice is complete and this is correct. So no issue in here

2. The issue is here. When you copy a sales invoice the taxes for every product must be calculated again and not just copy what it was in the original line.
(0025070)
hgbot   
2010-03-05 06:03   
Repository: erp/devel/pi
Changeset: 163ab0500a0c8b1a77ceccfada0ba68cf4e6073a
Author: Sivaraman Rajagopal <sivaraman.rajagopal <at> openbravo.com>
Date: Fri Mar 05 10:35:26 2010 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/163ab0500a0c8b1a77ceccfada0ba68cf4e6073a [^]

Fixes issue 12465: Copy Lines on Sales Invoice does not work properly

---
M src/org/openbravo/erpCommon/ad_actionButton/CopyFromInvoice.java
M src/org/openbravo/erpCommon/ad_actionButton/CopyFromInvoice_data.xsql
---
(0025071)
sivaraman   
2010-03-05 06:05   
Steps to reproduce

1. Log on to Openbravo
2. Change role to Openbravo Admin
3. Go to Financial Management || Accounting || Setup || Tax Rate || Tax
4. Create new record with following values and Save
       Name : Testing - Slovakia
       Valid from Date : 01-01-2010
       Tax Category : VAT 16%
       Rate : 25.00
       Country : Spain
       Destination Country : Slovakia
5. Go to Master Data Management || Business Partner
6. Select Mafalda and go to Location/Address
7. Change Location/Address: [Country: Slovakia] and Save
8. Go to Sales Management || Transactions || Sales Invoice
9. Create a new record
       Partner : McGiver
10. Save and go to Lines. Create new record as below, save and complete
       Product : Grand Beer
       Tax : VAT 16%
11. Create new record
       Partner : Mafalda
12. Click 'Copy Lines' and select the McGiver's Invoice created.
13. Go to Lines

Result:
The taxes for every product must be recalculated again as per the
partner's default tax rates.
(0025104)
arunkumar   
2010-03-08 07:37   
Tested & Working fine
(0025393)
hudsonbot   
2010-03-12 22:40   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/163ab0500a0c [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/631c626866c1 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.16685.obx [^]
(0029314)
hgbot   
2010-07-14 17:53   
Repository: erp/stable/2.40
Changeset: a1b488652ed4e43677f3a2dfbaf33198c2aa650a
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Wed Jul 14 17:52:53 2010 +0200
URL: http://code.openbravo.com/erp/stable/2.40/rev/a1b488652ed4e43677f3a2dfbaf33198c2aa650a [^]

0013923: Copy Lines on Sales Invoice does not wprk properly
It has been backported the fix for issue 12465

---
M src/org/openbravo/erpCommon/ad_actionButton/CopyFromInvoice.java
M src/org/openbravo/erpCommon/ad_actionButton/CopyFromInvoice_data.xsql
---