Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0012267Openbravo ERP09. Financial managementpublic2010-02-15 10:352010-05-18 12:12
Reporternetworkb 
Assigned Toharikrishnan 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version2.50MP11 
Target Version2.50MP17Fixed in Version2.50MP15 
Merge Request Status
Review Assigned To
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0012267: "Line" number shown makes no sense in Asset amortization tab
DescriptionWhen an amortization plan is calculated for an asset, it shows a field called "Line" which shows, line number in Amortization window.
This information does not make sense, it should show line number regarding to asset amortization line, ordered by date. This solution will help to sort by date.
Steps To ReproduceGo to Financial management > Asset > Transactions > Asset.
Create a new register.
Fill its name, "Linear" as Depreciation Type, "Time" as Calculate Type,
"Monthly" as Amortize, 12 as Usable Life - Months, 01-01-2004 as Depreciation
Start Date and Purchase Date, 1000 as Depreciation Amt and Asset Value.
Press "Create Amortization".
Go to Asset Amortization tab.
Go to Amortization link.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0012184 closed adrianromero Line No not auto-incremented when Create Amortization. 
blocks defect 00128992.50MP17 closed adrianromero Amortization lines are not displayed in sequence of year 
Attached Filespng assets amortization.PNG (37,318) 2010-02-15 11:26
https://issues.openbravo.com/file_download.php?file_id=2218&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2010-02-15 10:35networkbNew Issue
2010-02-15 10:35networkbAssigned To => dalsasua
2010-02-15 10:35networkbOBNetwork customer => Yes
2010-02-15 10:40rafarodaRelationship addedrelated to 0012184
2010-02-15 10:41rafarodaNote Added: 0024246
2010-02-15 10:41rafarodaNote Added: 0024247
2010-02-15 10:53psarobeNote Added: 0024250
2010-02-15 10:53psarobeAssigned Todalsasua => adrianromero
2010-02-15 10:53psarobeStatusnew => feedback
2010-02-15 11:03networkbNote Added: 0024253
2010-02-15 11:03networkbStatusfeedback => new
2010-02-15 11:03networkbSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=29#r29
2010-02-15 11:25psarobeNote Added: 0024256
2010-02-15 11:25psarobeStatusnew => feedback
2010-02-15 11:26psarobeFile Added: assets amortization.PNG
2010-02-23 09:52adrianromeroStatusfeedback => scheduled
2010-02-23 09:52adrianromerofix_in_branch => pi
2010-02-23 10:19psarobeNote Added: 0024725
2010-02-23 11:29adrianromeroNote Added: 0024732
2010-03-08 16:05jpabloaeTarget Version2.50MP14 => 2.50MP15
2010-04-07 04:51harikrishnanAssigned Toadrianromero => harikrishnan
2010-04-07 04:55hgbotCheckin
2010-04-07 04:55hgbotNote Added: 0025918
2010-04-07 04:55hgbotStatusscheduled => resolved
2010-04-07 04:55hgbotResolutionopen => fixed
2010-04-07 04:55hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/2a0f92919112fa4c73a9621fe243274059efcbce [^]
2010-04-07 04:57harikrishnanNote Added: 0025919
2010-04-07 15:41adrianromeroRelationship addedblocks 0012899
2010-04-07 15:42adrianromeroStatusresolved => new
2010-04-07 15:42adrianromeroResolutionfixed => open
2010-04-07 15:44adrianromeroStatusnew => scheduled
2010-04-07 15:44adrianromeroNote Added: 0025947
2010-04-08 16:15harikrishnanNote Added: 0025982
2010-04-08 16:15harikrishnanNote Added: 0025983
2010-04-08 17:49adrianromeroStatusscheduled => resolved
2010-04-08 17:49adrianromeroFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/2a0f92919112fa4c73a9621fe243274059efcbce [^] => https://code.openbravo.com/erp/devel/pi/rev/f806ff1950f4e606e3d29b8d60744e4fba7cd952 [^]
2010-04-08 17:49adrianromeroResolutionopen => fixed
2010-04-15 13:40psarobeNote Added: 0026257
2010-04-15 13:40psarobeStatusresolved => closed
2010-04-15 13:40psarobeFixed in Version => 2.50MP15
2010-04-16 00:00anonymoussf_bug_id0 => 2987951
2010-04-19 21:12hudsonbotCheckin
2010-04-19 21:12hudsonbotNote Added: 0026423
2010-05-18 12:12gorka_gilTarget Version2.50MP15 => 2.50MP17

Notes
(0024246)
rafaroda   
2010-02-15 10:41   
Is this issue duplicated of 0012184?
(0024247)
rafaroda   
2010-02-15 10:41   
Can you copy-paste the steps to reproduce? Thanks.
(0024250)
psarobe   
2010-02-15 10:53   
Hi,

As you mention the line number is based in the amortization header and not in the asset header.
Clearly this might misunderstand the end user. So the solution must be:
1. Hide this field in that tab (edit/grid mode)
2. Create a feature request for having a new column for this purpose in the corresponding table
(0024253)
networkb   
2010-02-15 11:03   
If line is not correct, it must be treated as a bug, not a FR.

It is not needed to hide this column. Only, recalculate properly its value
(0024256)
psarobe   
2010-02-15 11:25   
Hi,

Maybe I didn't explain well:

1. That column is well calculated so there is not a bug on that. As you mention in the description that column is calculated based in the amortization not in the asset and this is correct. This is a very typical issue rejected several times
2. So to hide the field is the correct solution to avoid mislead the user because we are showing a field that corresponds with another info. Take into account that this table shares different info for different windows
Said this:
3. Why is not enough with the dates? why would you also like to have the line no?
4. So my question was, Is it really needed to have this column? Does it add any value?
Since it is not a bug, that's why it is a feature request in any case

See attach
(0024725)
psarobe   
2010-02-23 10:19   
Final solution:

1. Hide that field in that tab. That field is just for the window Amortization tab lines
2. Create a new column that is similar to the above one and calculate the number line based on the asset.

Note: You have to be carefully with the stored procedure A_ASSET_POST
(0024732)
adrianromero   
2010-02-23 11:29   
To explain the solution to myself:

* A_AMORTIZATION_LINE currently has SEQ_NO field properly defined as lines for the header A_AMORTIZATION.
* There is needed to add to A_AMORTIZATION_LINE another SEQ_NO_2 for the header A_ASSET, and define a default value similar to the other sequence field.
* When done in the window A_ASSET there is needed to hide the old SEQ_NO field and show the new SEQ_NO_2 field
* That should be enough. But review the process A_ASSET_POST to verify that the calculation of sequences here is done properly.
(0025918)
hgbot   
2010-04-07 04:55   
Repository: erp/devel/pi
Changeset: 2a0f92919112fa4c73a9621fe243274059efcbce
Author: Harikrishnan Raja <harikrishnan.raja <at> openbravo.com>
Date: Wed Apr 07 08:36:12 2010 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/2a0f92919112fa4c73a9621fe243274059efcbce [^]

Fixes Issue 12267: \"Line\" number shown makes no sense in Asset amortization tab.

---
M src-db/database/model/functions/A_ASSET_POST.xml
M src-db/database/model/tables/A_AMORTIZATIONLINE.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_FIELD.xml
---
(0025919)
harikrishnan   
2010-04-07 04:57   
*New Column is added in the DB for storing the line number for AmortizationLine under the Asset window.
*Follow the steps to reproduce for testing the issue.
(0025947)
adrianromero   
2010-04-07 15:44   
Reopened because it is not properly fixed. It raises also the issue 12899. It is required to fix this issue properly and after verify that issue 12899 does not appear anymore.
(0025982)
harikrishnan   
2010-04-08 16:15   
Repository: erp/devel/pi
Changeset: e871ecee3de7f379628813019a537cd9fd0abfe2
Author: Harikrishnan Raja <harikrishnan.raja <at> openbravo.com>
Date: Thu Apr 08 10:08:35 2010 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/e871ecee3de7f379628813019a537cd9fd0abfe2 [^] [^]

Fixes Issue 12899: Amortization lines are not displayed in sequence of year

---
M src-db/database/model/functions/A_ASSET_POST.xml
---
(0025983)
harikrishnan   
2010-04-08 16:15   
Repository: erp/devel/pi
Changeset: f806ff1950f4e606e3d29b8d60744e4fba7cd952
Author: Harikrishnan Raja <harikrishnan.raja <at> openbravo.com>
Date: Thu Apr 08 19:54:51 2010 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/f806ff1950f4e606e3d29b8d60744e4fba7cd952 [^] [^]

Fixes Issue 12899: Amortization lines are not displayed in sequence of year

---
M src-db/database/model/functions/A_ASSET_POST.xml
---
(0026257)
psarobe   
2010-04-15 13:40   
Tested, working fine
(0026423)
hudsonbot   
2010-04-19 21:12   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/2a0f92919112 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/91d98bda46c1 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17088.obx [^]