Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0012224Openbravo ERPZ. Otherspublic2010-02-11 10:122010-03-10 18:29
Reportershuehner 
Assigned Tomarvintm 
PriorityimmediateSeveritycriticalReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0012224: api check build 287 fails - part2
Descriptionhttp://builds.openbravo.com/job/erp_devel_pi-module-integrity-test/287/console [^]

Problem is:
two Datasets with associated columns/rows were removed.
Steps To Reproduce
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0012223 closed shuehner api check build 287 fails - part1 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-02-11 10:12shuehnerNew Issue
2010-02-11 10:12shuehnerAssigned To => marvintm
2010-02-11 10:12shuehnerOBNetwork customer => No
2010-02-11 10:23marvintmNote Added: 0024151
2010-02-11 10:23marvintmAssigned Tomarvintm => pjuvara
2010-02-11 12:01rafarodaRelationship addedrelated to 0012223
2010-02-11 12:01rafarodaIssue Monitored: rafaroda
2010-02-11 13:22pjuvaraNote Added: 0024165
2010-02-11 13:22pjuvaraStatusnew => scheduled
2010-02-11 13:22pjuvaraAssigned Topjuvara => marvintm
2010-02-11 13:22pjuvarafix_in_branch => pi
2010-02-11 13:40hgbotCheckin
2010-02-11 13:40hgbotNote Added: 0024168
2010-02-11 13:40hgbotStatusscheduled => resolved
2010-02-11 13:40hgbotResolutionopen => fixed
2010-02-11 13:40hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/api-checks/rev/560130da1313ed9b778d763a065f4aa680b1feb1 [^]
2010-02-11 16:25marvintmStatusresolved => closed
2010-02-12 00:00anonymoussf_bug_id0 =>
2010-03-10 18:29anonymoussf_bug_id => 2968049

Notes
(0024151)
marvintm   
2010-02-11 10:23   
Hi,

Indeed, the datasets ADCS and DS were removed. The reason for this is that these datasets are only used by dbsourcemanager, and we've changed the way we use datasets to read the application dictionary data. As part of these changes, we found out that these two datasets were redundant, and in fact didn't work with the new update.database.

Modules shouldn't have added rows to these datasets, and if they did, they wouldn't work with the new dbsm anyway. It's important to note that nobody would need to add tables to these datasets except for some obscure reason which is only relevant for Openbravo platform development, as these datasets contain the definition of the actual Application Dictionary.

There shouldn't be any issue if we remove them.
(0024165)
pjuvara   
2010-02-11 13:22   
Accepted as exception.

Please add it to the list and send the alert.

Risk classification should be low.
(0024168)
hgbot   
2010-02-11 13:40   
Repository: erp/devel/api-checks
Changeset: 560130da1313ed9b778d763a065f4aa680b1feb1
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Thu Feb 11 13:40:06 2010 +0100
URL: http://code.openbravo.com/erp/devel/api-checks/rev/560130da1313ed9b778d763a065f4aa680b1feb1 [^]

Fixed issue 12224. API change related to removal of datasets ADCS and DS.

---
M model/sourcedata/AD_DATASET.xml
M model/sourcedata/AD_DATASET_COLUMN.xml
M model/sourcedata/AD_DATASET_TABLE.xml
---